From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C6EC5475B for ; Sat, 9 Mar 2024 01:53:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EAC36B00A7; Fri, 8 Mar 2024 20:53:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 975476B00A8; Fri, 8 Mar 2024 20:53:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 814F86B00A9; Fri, 8 Mar 2024 20:53:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6E2DC6B00A7 for ; Fri, 8 Mar 2024 20:53:20 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ADFC71C1771 for ; Sat, 9 Mar 2024 01:53:19 +0000 (UTC) X-FDA: 81875828118.12.B908710 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id AC815100015 for ; Sat, 9 Mar 2024 01:53:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XdAyec9x; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709949198; a=rsa-sha256; cv=none; b=gcdCxmZATRLobjpRjLnonZFufqLKZnVkgITLpoFYlVIrpYQcowVBCdjTMTSdc/v3U+RJGZ ohtOHfPtIt+d15rTeNgMqzsfK8nOnU0UdHf28MPRBzYv03P6/Nu+0KRErw7EgbRNkL97Fv IyMgGTQ7ayxvJgG/IjoS31xdq/uKfLs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XdAyec9x; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709949198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mLS7Mc55mFQ4GnN547qoofA5tnx+J8LSeNfoQBgZ7bw=; b=wsD5S75H6qP0ycT7RNffsf+Kyf2V37sV0zB97yA1yLQR2tnaWCDkPyRq1OdTM7K8uo1nja 8bJDgmt3ws/VbUSnrFxfaa/vHyq+iZsATVldTfoWTW0mFGp9Cq32yMFQ5080uyRnNzO2Gp UVBDDtLvOXZQ3MIulJ7Sjy5LCaBBZTU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3D01CCE2A71; Sat, 9 Mar 2024 01:53:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0E0DC433F1; Sat, 9 Mar 2024 01:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709949193; bh=2knyzT26kc/AoacFUv5gxCg0MX3pdvSH3cxpNCbbYtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XdAyec9xU/ehyjyfJwe7qad+5r2egSexq8GXPXFLTw/wvmpAHxSLb9RsAXp2iJfHl AXLYRsMDs6Iv7r/wcMsKA1sRKlctdDv2IIEIj9m2XN6gH+qWydxczRmjCSDaOZYCFi WtLIoXdBINcFQOhRbPZvZ+Mk+b21HMlxN/Yp4J1pxNPLMJrSuOkozvhfpEaXph9ZJM qVpnfq/JyxY5OENt2OkgvaZe1SRgD71Ipd4m5Oh0K3imAJY2vU4YKYNpsP9EQFxt5D TIhYCU5jAf/IPZGjCb8J1jEFZM+EYRal1W2oYpiy/Y2wn0jjet/1EZ85l/CJPcVUDF SSIH04uWuZnAg== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , honggyu.kim@sk.com, hyeongtak.ji@sk.com, kernel_team@skhynix.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] mm/damon/paddr: support DAMOS filter type YOUNG Date: Fri, 8 Mar 2024 17:53:11 -0800 Message-Id: <20240309015311.45954-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307030013.47041-4-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AC815100015 X-Stat-Signature: u938o7mgz4y46qwrw143py3paqdh57yn X-HE-Tag: 1709949197-226641 X-HE-Meta: U2FsdGVkX19gNaZFQYZyq6QTnoQOMFu3YWGvtiqqdJsRp4ti7fixDPXxzjhQ/3xxd1vNNi21iL8F8KybiFfpV4w/cq9jrS+Ec6nxoU+/ni/q67yzRy5C+GFb/GRXXLzhNDr5e9Gytf7emWxxSz4x7LKwUJYVRGa8DOOL5C9U4+sRfDzsVItuOwaj5gM7njYWMVI5R1JtrbbuMjfEHtvNY+HOWmY6xU/3pG4JavP0+VvxFtPVQXLqklzUzm2L7yRg0ztHjU12Ywd0WE2DBXsCaosixm6IGNvT1y8UbI4qbe9BzUBerBV7FdN3c1mP4+X8CqyPfJKPe/6eYGtwL2iQWTG1jhela6Ck8nBW8WEnrc8LDPlmwjJF9mmVsqRRlUbzKmT5hvzIF1hBFppZZnQ9y8Dm9xpUJbshdN9V4hBCGHa1QGOJ+DVKnJUPWz3lWtaIvR7Y5b2ttxDj0cjax9FoQOLo3nUXKPsrd5fW3ykxAbN5hlNaGiT5K04YY27Y9bdf5/R+z7RewChHLYZyhqIuZU2rpIEJMJ2iJWs+ZprMdtrdUS7QMzf6y9qwoBEbAN1A4sU9MSiOjqXt7aAAG3pPo4PYMkDMNCPkuTyuvb3wtjI7bZeRU1iZu0YEmmQPu3kDy/EDoLch5gSWezf/7H08B8WCy8eoBC9Qz9ZzZuhL2eRhGS1gTJ4L/szW3ayGIdU0EWx9EzCujXGbDj4gJ9I/9cgdH0AXZwFPzOrbzygQl53fn39tJzrS/FpzRedV/9KnyRHgWQQtYxEFZ+je3wmujhUcl03bGMkEgt+S3fC2U3I4aZcIHiyeKRzPxOw1FK5biF3s9zMWf/Hf1XcmNfSeq4N5ON5gKrafIyQbNdQ8SjT59utpYOXe2Jv5EqGTQO7xea41TGY46t3z4W6/Jg+iu5/fMM9bYoeMPFWNOs59FFXlUf0JirZmccLuu2jEVxwMB1Z39Jd1xp/SOpxr0+/ BlWq0E5W 9CIvp9AXi1rI2ETZfpcV3Da6oQUKUPMNpR/yrdvmWlWjP3rON61GmJuxO6jN+HOSlAxgxlX+ZqNRcEzUE6H8svaZb7uT4qXbUzKl4jSvtNKV7Y9SixfIYxRH8tKwG/JizbD6704oG2tjIpOuAM0YfiJcPUH2hbVr2ycqi8pRw8gyVgO6ziNi2OJ6LWy8dFTHH3KGQyMIkAhNqit1NV1RAZgPp7OubwQOSWWx6u2eESmg/ABE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 6 Mar 2024 19:00:13 -0800 SeongJae Park wrote: > DAMOS filter of type YOUNG is defined, but not yet implemented by any > DAMON operations set. Add the implementation to the DAMON operations > set for the physical address space, paddr. > > Signed-off-by: SeongJae Park > --- > mm/damon/paddr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index deee0fdf2e5b..52e4be7351cc 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -209,6 +209,9 @@ static bool __damos_pa_filter_out(struct damos_filter *filter, > matched = filter->memcg_id == mem_cgroup_id(memcg); > rcu_read_unlock(); > break; > + case DAMOS_FILTER_TYPE_YOUNG: > + matched = damon_folio_young(folio); > + break; damon_folio_young() doesn't reset the Accessed bit of the folio. Hence, unless something is resetting the bit, this damon_folio_young() call will repeatedly return true even if there was no access to the folio since last check. We should implement Accessed bit test-and-reset variant of this function and replace this, or call damon_pa_mkold() when 'matched' is 'true'. I will fix this in the next spin. Thanks, SJ > default: > break; > } > -- > 2.39.2