From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFC6C5475B for ; Mon, 11 Mar 2024 05:38:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8024A6B006E; Mon, 11 Mar 2024 01:38:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B26F6B0072; Mon, 11 Mar 2024 01:38:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67A1A6B0074; Mon, 11 Mar 2024 01:38:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 596326B006E for ; Mon, 11 Mar 2024 01:38:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00BBC120DD5 for ; Mon, 11 Mar 2024 05:38:29 +0000 (UTC) X-FDA: 81883653180.13.04BC27A Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf26.hostedemail.com (Postfix) with ESMTP id C60BE140007 for ; Mon, 11 Mar 2024 05:38:27 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=eEhbnREV; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf26.hostedemail.com: domain of quic_svaddagi@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_svaddagi@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710135508; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ddYhWpZ6UFYa7XqP0w1UUiujo7MlM6KsRadAKbQ22Rw=; b=09Ydd1vJqDpwaqJZDmpaFkjI5GbeDELEeaWO3LLJZXvJ+naxw+d7W+T7justTPjFrK/zpX /aqlL9qtEERYvbNxf0Q/uEEi6lnbvBbKNP79N/PTqxWrJLF66AbNAsPi9PbDEHPtDKAyWc TWC6ZDkM+v2Rjc/79I0V7YcIUsAcbvE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=eEhbnREV; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf26.hostedemail.com: domain of quic_svaddagi@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_svaddagi@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710135508; a=rsa-sha256; cv=none; b=66mMe7NIn+fraligVJJZSPKK94fBrgnWd4FIeHG/BlzF3rZ6tmnbJp5XVvHE4WDzQh21zc GQBiV3Y6fj3tJhEY6Ib9oCmpHQsHVRLWG1qm62Hu4PVS1oSJ//XGNsLiJKhcOB46aiWfjB 0uC5MPdnyTbD/Onv9M7vifYdmpCQpI4= Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42B5J5MF003578; Mon, 11 Mar 2024 05:38:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-type:in-reply-to; s=qcppdkim1; bh=ddYhWpZ6 UFYa7XqP0w1UUiujo7MlM6KsRadAKbQ22Rw=; b=eEhbnREV5Wa3zXvIJZx+lqnS anX5OBKzDgYK8YL2a9FZsSpKCT+rvAk7E5B4fgcg50OjuQOWEKY7F7beXLUDB5K7 3dUgPq6x93l8cN/khCTxxdryGgFyKuy2qOIkr4RDAsa4nAzTTHY4nAbD6ZD1ayCF qEtqsVESmgxfylmOleSjdphQc3BEW1l0ogVwllLgYEtmPei+TYlJg4lSA1yaoRnz XxbFaWA/ddpvyTm94jLZEgOPt/N0SjetgA4mhW4LyODsq53ZmzQX0pIHkL6Lwr2n 5DqzbTNLj2M4HeD1PalYjXKTOV1+BvRhIcPdb3x93kIb9o62cOy/lWmDhLqywg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wresbtsmr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 05:38:19 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42B5cI2M007024 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 05:38:18 GMT Received: from quicinc.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 10 Mar 2024 22:38:10 -0700 Date: Mon, 11 Mar 2024 11:08:06 +0530 From: Srivatsa Vaddagiri To: Elliot Berman CC: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , "Fuad Tabba" , Sean Christopherson , "Andrew Morton" , , , , , , Subject: Re: [PATCH v17 12/35] virt: gunyah: Add resource tickets Message-ID: <20240311053806.GL440762@quicinc.com> Reply-To: Srivatsa Vaddagiri References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-12-1e9da6763d38@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline In-Reply-To: <20240222-gunyah-v17-12-1e9da6763d38@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ZEy7XYUtlKeA49q6fTfq0MIjfbi1DK-L X-Proofpoint-GUID: ZEy7XYUtlKeA49q6fTfq0MIjfbi1DK-L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_02,2024-03-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 adultscore=0 clxscore=1011 malwarescore=0 spamscore=0 suspectscore=0 mlxlogscore=860 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403110041 X-Rspam-User: X-Stat-Signature: 66qgeqh334izfsqu8h3be6wnmjmgnypb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C60BE140007 X-HE-Tag: 1710135507-694353 X-HE-Meta: U2FsdGVkX19V7u7q/xA/mSaTVlF8o6tH/5dIGDeAdfCVSBuLGfZTMmcrVtc1MW6KQddaRiZ/nO/tEB8quQISfDmt3vQTe0CZ6dlvIrwFRbBObThxeMAhNiPtfZd15RydR5SfUX2XyTgXBU99lpPp8CfHBfscuLZ1S2CTbK6BCWn+b7djpCeT9xQhgpAjfx02P6wnou3quiVMQLg2plQVd78LSjtZUWf3ryx6U10yJsF/rzm2gNbd35O2BSP8BgKCP75MnFIzxlI8JvMra13TaYJXSTdJlhJP6aZwRA9J/SuOjkGAWXXGfhducWeIpt8+dWMUt92lBNZmI99Vw3VyL/jUbIPwx7vPFLhidEQ+nmQx+7da/dE5FwEIiDDuIFDfL8XukP40dT5oONDCUndli80KjT/BE9F4p4CVoQeLvl5KlMuN5OWRpf+eJLefZNcpryEgcfZUSYwg3H/Ms1v4FPrUnXpHwolWq6ABrXIWBb7hu96eRV4Fb7qQvV7E5iGn1RHr7k/turz5kg9ZP7kge+uT7frq2NA8gO0S0cZwEbSEWMLS4y/hzwfGPH7730Xa+3aIC/2ABeCddxwMdB9ZrY+HfqMwUYXc1x2q1e7+UR2GqD+S7KcVCUc2q7iIvTja8D0AsatAGujEsUsXRg0gjM5dl6Q8qNlTN3YWfWCT+vR2DP5HpF9df+lSI6bXpdjiRQqykwivww8f//zIO7NpwsiiFaSrIiBK2dsM+KKk5SV9eqZHrKU3Q/kkOQLLtaXYZKeq2sTgdJezzsDc7BzttYTVezxobtqoSwe9GtC18t+90KOmCSBXzvJVBpMbjI99kUxs0VHWKOzLQ6N75AVYnlWPVUYT5h1To9Nj9wQRaHxiez6VU0BOJNCqSvfYrnQtCr3vmj/CuyDHIL8wfarQRuTqNcQr9l0vqASrN0CQ0UGciWf1B6+7Xr/CmFoj9/LpDugVRmre4BpQ0GuPRAq RAfCDM0R gFC3Tr9beeW9Rq+2yzkgDdSktf761nDN06rvjePq1BWc3SuFIa0AvAubigsi2oMh7PGW1GJxwA3XMmrrf9wZH8XSVzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Elliot Berman [2024-02-22 15:16:35]: > Gunyah doesn't process the label and that makes it > possible for userspace to create multiple resources with the same label. I think that description conflicts with what is implemented in this patch? int gunyah_vm_add_resource_ticket(struct gunyah_vm *ghvm, struct gunyah_vm_resource_ticket *ticket) { mutex_lock(&ghvm->resources_lock); list_for_each_entry(iter, &ghvm->resource_tickets, vm_list) { if (iter->resource_type == ticket->resource_type && iter->label == ticket->label) { ret = -EEXIST; goto out; } } // > @@ -134,6 +246,25 @@ static int gunyah_vm_start(struct gunyah_vm *ghvm) > } > ghvm->vm_status = GUNYAH_RM_VM_STATUS_READY; > > + ret = gunyah_rm_get_hyp_resources(ghvm->rm, ghvm->vmid, &resources); > + if (ret) { > + dev_warn(ghvm->parent, > + "Failed to get hypervisor resources for VM: %d\n", > + ret); > + goto err; > + } Where do we free memory pointed by 'resources' ptr? > + > + for (i = 0, n = le32_to_cpu(resources->n_entries); i < n; i++) { > + ghrsc = gunyah_rm_alloc_resource(ghvm->rm, > + &resources->entries[i]); > + if (!ghrsc) { > + ret = -ENOMEM; > + goto err; > + } > + > + gunyah_vm_add_resource(ghvm, ghrsc); > + }