From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99CB1C54E58 for ; Tue, 12 Mar 2024 20:22:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 315698E0018; Tue, 12 Mar 2024 16:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C5828E0011; Tue, 12 Mar 2024 16:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B3948E0018; Tue, 12 Mar 2024 16:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0C36B8E0011 for ; Tue, 12 Mar 2024 16:22:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DCE171A0E09 for ; Tue, 12 Mar 2024 20:22:42 +0000 (UTC) X-FDA: 81889510164.07.EE86485 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id E4C6820014 for ; Tue, 12 Mar 2024 20:22:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JMWslwId; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710274960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f950I9DA6InL9WeqO03KJL02LHxnT+fxujYUhBAlvo8=; b=ubk9PbM3bqakKb1LHpmtLezXEHAWRCk1ciSNkjHlbEfNI3K195tUhGD4yGnb+6H14he3m3 KfIkNnkg+YTt5nvIC6ZcPKddAxAfcftHU7mpj9FW3uCVwBLx06sga2S9HsIclvot0en7a+ 6rpsbccYjdxQDIuorvwSFX/1AFOpkZE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JMWslwId; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710274960; a=rsa-sha256; cv=none; b=WUokgQRU8JZMrCHYkZNOxXC6gv9jK56WigcSFB/M5vZbLa3naBZIfLnDQ2LE/MzQCZ5Kj2 4PZcUG7Ot1e5F5BT1KNif/ezBhGGC/bmzp3eZ7dGF8PgMfGPprvEjvZzAhkOST9wxe3RWo j30HoDkTmZbBripKPIkvtlf3LixyMmg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0D15ECE18CA; Tue, 12 Mar 2024 20:22:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB5D0C433C7; Tue, 12 Mar 2024 20:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1710274954; bh=Pr5lhOrEPrMJqPAwR3vdY7dlJDIhGLkhSYZOK85QpNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JMWslwIdP4OWf5ct0J5wlCAlOEXwLAlFAYm+rpdZuRElOApbGIZ0KcNkJ2S3qG6b+ fGQkSlgljL2lZyAwVOiEzbdcv+3noDCbQtArckxN/voeH/K5KOFFGLOeQ5eYCbj4c8 aWDQufFjOWDNbpL/L7XxWZsj5Mii5d0ZR+29Dm4E= Date: Tue, 12 Mar 2024 13:22:33 -0700 From: Andrew Morton To: "Verma, Vishal L" Cc: "Williams, Dan J" , "Jiang, Dave" , "osalvador@suse.de" , "david@redhat.com" , "gregkh@linuxfoundation.org" , "Huang, Ying" , "linux-cxl@vger.kernel.org" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "willy@infradead.org" , "nvdimm@lists.linux.dev" Subject: Re: [PATCH v7 1/5] dax/bus.c: replace driver-core lock usage by a local rwsem Message-Id: <20240312132233.4a04a742c7bae02a31eed78f@linux-foundation.org> In-Reply-To: References: <20240124-vv-dax_abi-v7-0-20d16cb8d23d@intel.com> <20240124-vv-dax_abi-v7-1-20d16cb8d23d@intel.com> <65f0b5ef41817_aa222941a@dwillia2-mobl3.amr.corp.intel.com.notmuch> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: fnm3spiuiaqf5wrpmencsd8fu7j93cri X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E4C6820014 X-HE-Tag: 1710274959-818853 X-HE-Meta: U2FsdGVkX1+YitkUevUiz6FxjGBd9UCETYnmMHupPvcLAkv76WRpYkGGyMPvT55IulyBx4fQZBpEH0nMdTcJYN1RPvNCKndnvoGXZGoeaA4p+Gs2zx7nDMHsde92GC3iQBzFjEcD2ncgX/ufGT4HKMvE/SB+5VLtDx0fEt3AQyvFP/5SlV7csYFz1sO3YLbePI6WIJoFTxRxIdfFzqJmo8RnxUN69Hgq1qKMCXKkOw3k8iZ/RnrrIJ7pwlOUngRHCndhzYGhg72en/i8kwaVSJOxSxxtx/eOLBHXPwWWxMzp5g/b0yfRzkptuuaKr2l3faFM2dcULldtcX1W0X56mOSg8Qv+i8dLHfZzyvH6WywsBalZtgVdtQ4RHIBFh59IL1oek0cjBYFuw5Q4x8sHlJLhRGAXhOzLxE9XeY7GOAioCqCMVtcVut/N6XrDZZw9E/R0xPZv3Bjt/63qpeE8KPFzh8jhY29DRjR6hBNJILWK0nDnT7Z78rP3S5R5XKVdhfe553EbqZ/7QmY+JsgxR/tMJQGcsoJdilqvSBOt1P2+wFmydu2HngZDLNoLHCSjwNdwwbRkvVJyogh8IX4rbU276wGIZGgyNk0VojCx4F4KiTuMIMGy2kfb8pFg9Ps/8iMrIfchivv4C+N9SHU+y9nYgYAjIavx8T4NROr0CZOYHiJ5k70iHIutfvjVcP1C1LO21O2P/ARDLAE4FYQ8DlehU02Skq8CJ1m4EIVtKE/Zp6c/ToOGiqLjU5DAZGkUaghCoN43LlmczVTEMKZsqDlpuMB5Km2Vbet+KtDvUHDke1siCqxjP8TtV6PAZnTsvU+tUQJ376wLn6lktRF8g/tDlr94LYba6EFL6DTs3t10EQjuhjI9pmucKufXbS9AwiIdyk165I5SbQaATsruNaChNoyTk+CSM6oyOlpvJykxYzx0x22vfaopWaDZZRLCrLObjdTvPzAbcSpvS8i 7jQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Mar 2024 20:20:17 +0000 "Verma, Vishal L" wrote: > > All of these WARN_ON_ONCE() usages should be replaced with > > lockdep_assert_held() and lockdep_assert_held_write() where appropriate. > > Makes sense - I can send a patch post -rc1 to change these if that's okay Andrew? Please do.