From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EAEC54E58 for ; Wed, 13 Mar 2024 07:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB48894001B; Wed, 13 Mar 2024 03:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E64EB940010; Wed, 13 Mar 2024 03:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2C5894001B; Wed, 13 Mar 2024 03:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C5923940010 for ; Wed, 13 Mar 2024 03:46:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9AF351C12DD for ; Wed, 13 Mar 2024 07:46:44 +0000 (UTC) X-FDA: 81891233928.20.A922A95 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id EB7AD180017 for ; Wed, 13 Mar 2024 07:46:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LhEelchk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710316003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oFPojxUGJwzVDoSGUKb9k5Rr3J1glGg6PTtT6ACJHaM=; b=4unXLa3aWVlgOrH2526pJFwxyTF4sYM6vnkqUkdP/CYJBIEl8HDkAjhX6dsZsi4/vVSR91 fb5rHPhJNrDvmH8fR/T7vEr67dyGgNHS1EAtEf+6VMbOF0zc3DDG6iUHKWl8STGuaQU/DH sWMUuDG9/2PVwldVR/83nKI1MRlKc6U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LhEelchk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710316003; a=rsa-sha256; cv=none; b=ngIJOxLd8srM5Xx2ii0wFQ1CiefnSPrZkvSRRM+9bZtgMEEOxoNat13hc0+sf4WbNcsAI3 DgYqVdHNa3SpxE3tThKA/UfXRdghovd0td0eVFq8H11DRPsW1poRxoTu2z+cXsxfggp9A7 jEWCJdZcS53UbGyf4orf6WIBN5f1QNA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AAFA16138B; Wed, 13 Mar 2024 07:46:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F8EC433C7; Wed, 13 Mar 2024 07:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710316001; bh=Kr6b9zwRiK0qe/FQtkWwwcr3AdM/iJQ3Tm5R/ItJ+kI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LhEelchk241d2G+Q3NZ+eugtycNa64C11tlGZNDKxCvzTX75Q00BDeucxxI33dSuA 4+eCRt8kMMEc5PKj3RKm6EMledYaAfqv5JZuQB7Y+lqGf4dv4bsr9x0TpKJG1q4wXj 5wL8HqXvVMagJHMFg5lnkHWIqzUSGVvjZwviYWQ8IepvQMcWBnKkAG8KoyC2Qj/Dk9 zhjs+9wAPOXEebb1i/MdTgpoDqE40AetcQZI0F5BBxVL9DwWbmHiXrd3y6wILhONqN 9PPx8kGlpLaHCN3ApgnEaZsraA27U8tPpWQjwzmxyOAzAxTPkrSjUTlSjBaxCZCGej iazuJwD6oD4iQ== Date: Wed, 13 Mar 2024 09:46:36 +0200 From: Leon Romanovsky To: Christoph Hellwig Cc: Jason Gunthorpe , Robin Murphy , Marek Szyprowski , Joerg Roedel , Will Deacon , Chaitanya Kulkarni , Jonathan Corbet , Jens Axboe , Keith Busch , Sagi Grimberg , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, Bart Van Assche , Damien Le Moal , Amir Goldstein , "josef@toxicpanda.com" , "Martin K. Petersen" , "daniel@iogearbox.net" , Dan Williams , "jack@suse.com" , Zhu Yanjun Subject: Re: [RFC RESEND 00/16] Split IOMMU DMA mapping operation to two steps Message-ID: <20240313074636.GV12921@unreal> References: <20240306174456.GO9225@ziepe.ca> <20240306221400.GA8663@lst.de> <20240307000036.GP9225@ziepe.ca> <20240307150505.GA28978@lst.de> <20240307210116.GQ9225@ziepe.ca> <20240308164920.GA17991@lst.de> <20240308202342.GZ9225@ziepe.ca> <20240309161418.GA27113@lst.de> <20240310093513.GB12921@unreal> <20240312212844.GA3018@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240312212844.GA3018@lst.de> X-Rspamd-Queue-Id: EB7AD180017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ko53p689quw64mz3x7xx5xhs5pw9o4qf X-HE-Tag: 1710316002-106463 X-HE-Meta: U2FsdGVkX18t/s9vp9akNP9x0/33BrxW0rDvlwpABL0VqH1sB41mgil3eWD+itV+dONwj+euHST5FRtTyNjD3DHEXfyMn5r3ri9+Jq7QVO0a7mhEcNGRGdnayIcrufv3glB5HP18eZeJbegt+iD8U/n0YHuA1aeJNNOWCGmrQ68kY7QUrfJXZN5iVo4nhceF2gcL+2+GuYYsIWm1ilJtXqMKg2xkOI4GC7mhl1igxQOjxFlDt9h8vaOE1M90OZb7oTDK5wCKYAM58oCXSCpDVop12+jWyzJ4PLSOl+oau1lxZDrjQYBfUJssYbu6YRw8zPWytXF+jc8MaJ1qEXeD+iDCDBHFVG1Ln29JJZ9BIIulwXPrcHtUg5CzNH0DloUspteLa70jJmCCHySXLxd7XezwfndRVCZHE1u5wG+No3jdksmTdW33ZFBOSVUP+xvyml+ktP4QxIOh2UuwYZKMY1Ok6V7PtbmdQTEgPSAsZ7sYryeA15Iue4RdgxZdKv5/hmktsX1ujCgr3KmIhb+CXCmsSjyXPdXqYTvHqnUqpKaNxFqWis2Lh4j0UoM9LUODuKrMqLtsA5zt9sKjF7+GWYULX6dIlkI2psHNvvJ0KKcTBegJAlS1Ur5Ye6t7NcrR7/+s8TLsSCa5I+tnbAdESLk1qQeN49XYFJ6XziOWyuZdYwYKqeigwbf3raeDW+NlUGZlEIorc/3f9oCQ4M6+D58cfd1S3Sc5b7mbyWBTawLykPGaxPVAjiW8JMtpV9X95p4zPpd+2JnmhWLjZTlcOPI/agvwXZfWXVG0AXM5Gzt7g1m5BrPQQp+YuRyYdeyreo7dard+C3swBR2vB2u4DYnAPbpEJeJKsX9uiLoQmB5nZEBVOK/7ZY4wS4RgzRF589PVz9GNi+rmECwu+FboY5SdlDYzGMVSpVF/Z6RXThDchEiyAsqeEwGI3aKmRu58cFNuMU1vhxjbQ7Lzo42 9WFkBlOp OSVcY5dN0RkXw2bPfDMXJ4+WjM5Uuq6DwNQOoxAk3xam2QQVAM3uYB7VT4y6jizgt0TZiasMfSY/u+M1iDKonDVmFHD2mHxZj2ncoAATVlxg/WqwGDlEYwwlkZJ5S0QAcWfZ+3xOZfpdJwakaKgUXvYUf3QvgaqGyBXXPCRV0HtP3CQ0wiTXLeGR645GIoLWsCPMO13svCmwFjxwKaTT0VYNczjfSoOEU6FN0J/Te0FSm934= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 10:28:44PM +0100, Christoph Hellwig wrote: > On Sun, Mar 10, 2024 at 11:35:13AM +0200, Leon Romanovsky wrote: > > And you will need to have a way to instruct that pin_user_pages() variant > > to continue anyway, because you asked for FOLL_PCI_P2PDMA. Without that > > force, you will have !FOLL_PCI_P2PDMA behaviour. > > I don't understand what you mean. Jason talked about the need to call to pin_user_pages(..., gup_flags | FOLL_PCI_P2PDMA, ...), but in your proposal this call won't be possible anymore. > > > When you say "simplify the overall interface", which interface do you mean? > > Primarily the dma mapping interface. Secondarily also everything around > it. OK, thanks