From: Jiri Pirko <jiri@resnulli.us>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, vbabka@suse.cz,
roman.gushchin@linux.dev, 42.hyeyoo@gmail.com,
peterz@infradead.org, mingo@kernel.org, danielj@nvidia.com
Subject: [patch RFC] mm/slab: introduce KZALLOC_FREE() cleanup-ed allocation macro
Date: Fri, 15 Mar 2024 14:22:49 +0100 [thread overview]
Message-ID: <20240315132249.2515468-1-jiri@resnulli.us> (raw)
From: Jiri Pirko <jiri@nvidia.com>
With introduction of __free() macro using cleanup infrastructure, it
will very likely become quite common to see following pattern:
type *var __free(kfree) = kzalloc(sizeof(*var), GFP_KERNEL);
To follow the CLASS() flow from cleanup.h, introduce a simple macro
KZALLOC_FREE() to wrap this over and allow the same flow.
Show an example usage in gpio-sim driver.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
drivers/gpio/gpio-sim.c | 3 +--
include/linux/slab.h | 3 +++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index c4106e37e6db..997237b3d80c 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -1496,8 +1496,7 @@ gpio_sim_config_make_device_group(struct config_group *group, const char *name)
{
int id;
- struct gpio_sim_device *dev __free(kfree) = kzalloc(sizeof(*dev),
- GFP_KERNEL);
+ KZALLOC_FREE(struct gpio_sim_device *, dev, GFP_KERNEL);
if (!dev)
return ERR_PTR(-ENOMEM);
diff --git a/include/linux/slab.h b/include/linux/slab.h
index b5f5ee8308d0..baee6acd58d3 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -711,6 +711,9 @@ static inline __alloc_size(1) void *kzalloc(size_t size, gfp_t flags)
return kmalloc(size, flags | __GFP_ZERO);
}
+#define KZALLOC_FREE(_type, var, _gfp_t) \
+ _type var __free(kfree) = kzalloc(sizeof(*var), _gfp_t)
+
/**
* kzalloc_node - allocate zeroed memory from a particular memory node.
* @size: how many bytes of memory are required.
--
2.44.0
next reply other threads:[~2024-03-15 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 13:22 Jiri Pirko [this message]
2024-03-15 21:39 ` [patch RFC] mm/slab: introduce KZALLOC_FREE() cleanup-ed allocation macro David Rientjes
2024-03-16 15:41 ` Jiri Pirko
2024-03-21 16:26 ` Re " Przemek Kitszel
2024-03-25 19:00 ` Dan Williams
2024-03-27 7:23 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315132249.2515468-1-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=danielj@nvidia.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox