From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BD4C54E5D for ; Mon, 18 Mar 2024 22:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D304C6B0085; Mon, 18 Mar 2024 18:27:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE0146B0087; Mon, 18 Mar 2024 18:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA7F56B0088; Mon, 18 Mar 2024 18:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ABF286B0085 for ; Mon, 18 Mar 2024 18:27:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 458E1140C85 for ; Mon, 18 Mar 2024 22:27:37 +0000 (UTC) X-FDA: 81911597754.28.0733799 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf15.hostedemail.com (Postfix) with ESMTP id 5D0EFA001C for ; Mon, 18 Mar 2024 22:27:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PG9J8wie; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710800855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwWkU8lgVBm7GfNdi57Ea5vfTMMbO/0kw3dtIaZC8Is=; b=Px6ZG56JisYAD4XOBPDa9DD8BHbwwLvXCm1/SZ2LO3p5DbhWEOA4FnL7LSCn9gSCWdpMcU GH3x4bKltswb5hXDFME8kTZC0lO9ps1Z077YZcmfWEhoV1rAUjdMLQyTVMyCXQm24qSpha MGQZHiZH6WvpoQpvOmUuiMSvRwifJ98= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PG9J8wie; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710800855; a=rsa-sha256; cv=none; b=VYexbTz7vvO4HcsMoXzakRZcL1UqrZeBepDPPNVaJXTqXbga1KfbThH6ywoA/wLWW3xwkH pikAvJU49lhtaKddeC5ObhIACkKSZJtzOppTGmx2q1ca8Jo7g1d/Fs6D7og+spexRlCaho yqyyith73b2w/jP/eJMGE6Ag6k+MOrM= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dd955753edso39218225ad.1 for ; Mon, 18 Mar 2024 15:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710800854; x=1711405654; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DwWkU8lgVBm7GfNdi57Ea5vfTMMbO/0kw3dtIaZC8Is=; b=PG9J8wieyPRFHmuOXsp7y+lbvZ4BAazeiyalFdZ4dpIM5U18t23Jo8hs7AiO1hEJVx tdmZSMQablFJIZX6Qqd+xxkW3qK/vu22txmg0ba58QbLmELB5LNb1Yf074GB5S6Lfehp 4aXr420g8Q9XUyl1Zmk8F7GvwVzObDoMsvHtrUPxfsgOlHvbeHELAmzBTrZut4VTtFsN PrZmuil70KQ016msK/4pd2tpxDoM4osmztRYZlS1HcmYKZZmX04rwkq36j90Mn7y/eFM z5BWziAOE56tf2m/YTP7XwJhf/uSoUjtvxH3kG/chgD8nYY1oj1/ah41f6qm395uQ7JX xkUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710800854; x=1711405654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DwWkU8lgVBm7GfNdi57Ea5vfTMMbO/0kw3dtIaZC8Is=; b=oFv1L5mXMLxX9wrGbiyvCCHlW5Ek3cqU2FgGPza1FIyaGNrRYzqvMpuXDw5J5id6jb PesTSmafP8eiDukNXPNjuoa2zWU4+mxc7EKXCKAPApKiBh/IrD49ZR98C2+wlNTmSBwI Jc0mHSyEaRNFU5v+niaHb98YWqA4ioynqE3RmM+mONOekbmSXqBNzIOB/QGU3j7XOPuR DzKdMGsCkpd0VhdTGmw97EMUd4TXClYPOzRshZnIDYuGV4qCW6DPQ/PbpDpd2GRZwjCs 6mP7m0jtjXUoHTjY2ECJT7jqaLn5IZpre+KOGRLTAaEg6CQEAUkVHsBhfKL0y2hB0EmQ OG1Q== X-Forwarded-Encrypted: i=1; AJvYcCV/GOc28b0VyL97veee5iGaxSBl7AkaUP+rS/qLcE59L9Mu5Gx2T3heJDrx/frPCGkbF23ewXuRNMVrK/krOp+YZB0= X-Gm-Message-State: AOJu0YwPgfWV4yH62g35yCmxCVYQX3wTmL4zj6qC1ACUBbeIejvDKtIZ 3cym20lXB7U2HqWaRgRyQ/oglRB5FEn78BBTsInoAaG/eYi3dM8G X-Google-Smtp-Source: AGHT+IG6hhx5i/qrmjLWaWWDMuYJHbPbaHZ0eKWQm0hdxSqcnjN/F78ReNMMizTbAWTH9kp3nP/aUA== X-Received: by 2002:a17:902:ecc7:b0:1de:faa3:755 with SMTP id a7-20020a170902ecc700b001defaa30755mr13364190plh.37.1710800854078; Mon, 18 Mar 2024 15:27:34 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id n18-20020a170902d2d200b001dee0e175c1sm9124586plc.118.2024.03.18.15.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 15:27:33 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, syzkaller-bugs@googlegroups.com, yosryahmed@google.com Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one Date: Tue, 19 Mar 2024 11:27:15 +1300 Message-Id: <20240318222715.86329-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <0000000000009221d60613f58726@google.com> References: <0000000000009221d60613f58726@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5D0EFA001C X-Stat-Signature: htapcngz8pdkhorejm5goqusfbsbezfx X-HE-Tag: 1710800855-507089 X-HE-Meta: U2FsdGVkX1//ryvhUCxZWBsPsHDa//efnFBuvEz+od4To+ubTD664uhHQLYrxXe8paPZF2nSm2NgTP4hqQfValZpgYnqwjMqcpwAvk0AO+zBrBc0Zl7UJg4gxv8uIGIT8HA/TpXNxQh7zyOeD5msQQnKQzA1MosBX+hhq+rr0z56lMpaOTjekDKFAfi09kh8GLK6dCTKNkcd3iSAlaLS6mGFGX/CcYs6al2QULnSDOuH+dX8EYRCPES1q6mUZZHMKLSObmOFpyQIXsoMOU3547mjH7d7tHEbvuPbJwId5rMBk5vXZcyVU25/rHZpzM4fK/aolL+LnM8JtrDjldmxENk3jwgQ+EqjzmPS4pMPet9n2vwmRgXU8jHoiktPNMbp+OJ3/gizpQrdB+2e4wzrFVHbTjL9+vsZwd55ONowypk0jskxHNydO0nGhHJgBXIM6VIvwRgx8T1zABIYXTYkOb81lStq8N4J+tlYWTcj32J83ciUdqPQPxiP087qUuWZFOQ72lcJg2ngp5i1EoOca0ShFSoRL2Haqcsz95kiPfClEIh+pXGScjSe9rssmyGgiFWxuHjwCtwfnOKYayRGVtQ5NQibP3eFLfZ796RAyoXLGKtJMaMw8IpnvLcnfkMuICt5HhIqM4H/W/etV+NnM4E+bbXsBGHoeYWUBC0T+wOfe48YzvXDo2ZZAExqGdE6si0s6AuZnOr6PQqte8Tl67eFngB4KxgJ8XavJ0Sg7UHhc8MsmIBYH/E+D2ucWDc8ugjKX7GN19lPV6qE9/XIo2jKEdigBcPQS6xD42ZpTWzB/YokCzo3zubsP5S/M/4mnonxFy0KLtOtnBHJeSRgGK0W0ipjX0DT3wlZYYE/vPOCXfVZX4UhAMOjt7IYy3K5a0/aYCuyKsPVrfESwTxN3gKbKS42oV4AovXuyTrj0f5oR27akCusRjmGRlbA64Vyy7xgriB5XWYxZc3Mn2y FtECxTP+ MTRf3317ZJPUS1H6sOar2gf4yX5ZY7vs2zisxZerqKtAZi5eHcvP3o7YyswcPc0pNhIOaHyiTf92oAc7GM9cxzId2EYwxz3Mkhp4DB/OPr2KPF+7cuB/il9Ysxzg5cG8M7ozgmdH14jUpcTKROdFyjKgHkZq/g7bIA7FKGy1yJ0QuEO5mh4gCEvJKoIaKiS6gZA5yRmdQjgOt0+fl9O98AYop3xGgnFz4EfJKNWtA5RcrGDycW5FK+fmOG/2q44AwG8ZfNMw8pxuzT5w/lzhHlKMQaxsAiZ0ldV/S4FLiXycQitLiCk2MuBdbXvwiyWLxfnyJ9iJdu7B2sDvmFh7ntmUjSo+9J+h9QHdhX7EOJAQE2CCzUGSG06iF9Q7UzFPKXDEeRrdfzzQqjg8vUWli9R8LYmtTk5R7LnysgSmvJ2MyYU2lh2FNDdIAZfymoWlCLv2Wiw7u7Ry04PNc/2vCK2XO9dsSN7PTzASy8dZEYQYtZ9oxRpfsCZiETY2Vq4Ub15GgcTo8IjsCyXaagND3ykj0c7a7oMvXV4srzy7971GXkiUEmoIcgEzmM5DQhDdUiTV/GkOAw0K4zFjTa+hp2MoK+7K9pELFDpANyXREsAgkShYPa+6O3f3hIwxm9iFrbS7fsV0kFiSQgr2I9Fhg9UqsD9QVOMuXWd8KGEZ4N0m3YyBfIX9M81fJpyQt3woED5USRjpX+g7IK+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > syzbot has tested the proposed patch but the reproducer is still triggering an issue: > WARNING in __kmap_to_page > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 3529 at mm/highmem.c:167 __kmap_to_page+0x100/0x194 mm/highmem.c:167 > Modules linked in: > Kernel panic - not syncing: kernel: panic_on_warn set ... > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e5eb28f6d1afebed4bb7d740a797d0390bd3a357 diff --git a/mm/zswap.c b/mm/zswap.c index 9dec853647c8..17bf6d87b274 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1080,7 +1080,8 @@ static void zswap_decompress(struct zswap_entry *entry, struct page *page) mutex_lock(&acomp_ctx->mutex); src = zpool_map_handle(zpool, entry->handle, ZPOOL_MM_RO); - if (acomp_ctx->is_sleepable && !zpool_can_sleep_mapped(zpool)) { + if ((acomp_ctx->is_sleepable && !zpool_can_sleep_mapped(zpool)) || + !virt_addr_valid(src)) { memcpy(acomp_ctx->buffer, src, entry->length); src = acomp_ctx->buffer; zpool_unmap_handle(zpool, entry->handle); @@ -1094,7 +1095,7 @@ static void zswap_decompress(struct zswap_entry *entry, struct page *page) BUG_ON(acomp_ctx->req->dlen != PAGE_SIZE); mutex_unlock(&acomp_ctx->mutex); - if (!acomp_ctx->is_sleepable || zpool_can_sleep_mapped(zpool)) + if (src != acomp_ctx->buffer) zpool_unmap_handle(zpool, entry->handle); }