From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4A9C54E71 for ; Tue, 19 Mar 2024 16:37:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B31F06B0083; Tue, 19 Mar 2024 12:37:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE1CD6B0085; Tue, 19 Mar 2024 12:37:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A9BE6B0088; Tue, 19 Mar 2024 12:37:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8BD9B6B0083 for ; Tue, 19 Mar 2024 12:37:04 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 08A70A11B9 for ; Tue, 19 Mar 2024 16:37:04 +0000 (UTC) X-FDA: 81914343168.20.356F16A Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf08.hostedemail.com (Postfix) with ESMTP id 74A20160016 for ; Tue, 19 Mar 2024 16:37:02 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zzhQoLcz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 3Lb_5ZQYKCMguzwrs5u22uzs.q20zw18B-00y9oqy.25u@flex--glider.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3Lb_5ZQYKCMguzwrs5u22uzs.q20zw18B-00y9oqy.25u@flex--glider.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710866222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Pe97FWHITdYkiCtSSFDy2YJv9pSAbWKeZZSBy5Rk1y0=; b=zVqN9mYZwN5wxfUlz0WMsX6hk64jqB9nYDJTt3W2Q5L/y0x0A+Nh9PUBVIjmOkZW+svQxS 2uonO4xaqNkxgqqHAtxYuXkyXWqA1OwNTYDXy0WGa1w2Zv8gZnABrnPR6R9UsaGdYXUnKX MyJGdMbD61HIk+gDdXAC78NPLrl4yE4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zzhQoLcz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 3Lb_5ZQYKCMguzwrs5u22uzs.q20zw18B-00y9oqy.25u@flex--glider.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3Lb_5ZQYKCMguzwrs5u22uzs.q20zw18B-00y9oqy.25u@flex--glider.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710866222; a=rsa-sha256; cv=none; b=4254Mo2bMk30jY3U6nWdT/wqQypsr8OWuZj9IVIMgr+nBz/sHYuHSEl6SNAdyngT9igYsJ 1RNb8/ZFRXFnCPOiUN3XgngM4QUwcHIohCZfWpQGYaOZL5oTLornhGYwlmrlnDDf/7SMfx Ww5uPckEVJJpEN12nvASbOUcNQ2YiDA= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60a2b53b99eso124173087b3.3 for ; Tue, 19 Mar 2024 09:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710866221; x=1711471021; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Pe97FWHITdYkiCtSSFDy2YJv9pSAbWKeZZSBy5Rk1y0=; b=zzhQoLczN9J20T4Nmd91lgUKW44PbEXVpkqw+8Gczpc3klJh5Hvv5/L0Bv43+P3SBs zb7p2ZfP1tuQwUqU49qdfcoAW0un71XZaOVW35xwpMTA66P+ygCH3WT8oOP3B06W8D8s umNBFQYk+MVNpoJyA5/DiTkFxu8nl1Rw2uyyi+bNH7wwvmN3sldVuY144fsWsaSheePI 9oLO460D4eIZdYPDbpz5lgf8/kf+I/jQzqZbu8eVTnycwumx+wlsGyJ+mPN+UXLlQeyr HiTHrGuww40h9SMABVCH7g1hfk1eflUkrhT466yP0LFq5V94ry8ELIFEmpv8HpabhHvC ffgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710866221; x=1711471021; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Pe97FWHITdYkiCtSSFDy2YJv9pSAbWKeZZSBy5Rk1y0=; b=v8UrwdwcsqH6ugFav93mXvvQSKDunDPTvMXYpvg/DVZLyqENcSRuJqUb5IF6u/QoTV XBdmI8msu7KQamJAis+nFVuhj11weJLyICCUNbu0xnOovOTs59Ee+dWwfwR4pUQ7YTYQ Mnz9CWJE4W6Nf6R9KY6JRARFVKUVtuPcPBJ0zJwU7ucVEIvQnyx6ugBs/f1nY4Te7i1f V36DRmSTWAuuR02vHhc1p8mjZvGzeJaXBMJZq1lfpEaBM3jrSKzgmh+ZJ7ELfKvqgO/7 NclFeaDi2Fts8jzNkBW7C86CUILQFcXLsxIvYBGLiWFJb/mHXeVuJuojJJX3HvGSv6gO U3Gg== X-Forwarded-Encrypted: i=1; AJvYcCV2Nt/MB8nyN6kuN4q5W2ygJXX0AB0Q3xCQIFFpTDLGuMiC/+QkmBDN8oH6a90XGeA19GWCYsQiWSm54J2SWlaafoY= X-Gm-Message-State: AOJu0YwO1VRyQGMfCeKYpdpxVOMQE4vNVzfe97VbuIfGNyqZE0UWH4qt O2Zta1lMc9DWxq2Pbun5iHFWSTBD399kuuw6O5QTEtS95Mss9mJ6q+Ea06igr3aDIvl68UANkQc Aeg== X-Google-Smtp-Source: AGHT+IEz30VBiIgqKB2uLCoDK46fqUug5yjDscbPTqKHvlX6fQbTCw7l6zHUNahzxmdhiA2a5cr8piuX0n4= X-Received: from glider.muc.corp.google.com ([2a00:79e0:9c:201:2234:4e4b:bcf0:406e]) (user=glider job=sendgmr) by 2002:a81:4941:0:b0:610:c60a:bd27 with SMTP id w62-20020a814941000000b00610c60abd27mr1741328ywa.0.1710866221483; Tue, 19 Mar 2024 09:37:01 -0700 (PDT) Date: Tue, 19 Mar 2024 17:36:54 +0100 Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.291.gc1ea87d7ee-goog Message-ID: <20240319163656.2100766-1-glider@google.com> Subject: [PATCH v1 1/3] mm: kmsan: implement kmsan_memmove() From: Alexander Potapenko To: glider@google.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, tglx@linutronix.de, x86@kernel.org, Tetsuo Handa , Dmitry Vyukov , Marco Elver , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74A20160016 X-Stat-Signature: xguy73fx743586sh1r883dtqooqtx936 X-HE-Tag: 1710866222-399471 X-HE-Meta: U2FsdGVkX1/hED9HNg67olAyDBol88AkCjB4NGqAIuWI2cEO5uujK8N0EAhyd0iAaAz3X7DaBtNyJTN6SGvoXumc2ITRvmE8m0MBDDiBGBWfBy5t6OSlqQUPpbyB4BK8K0b/MIdwCtCA3kB1T5mXCDxPlyoHMS/zmsJkAfWyvcdoL/pKJ0Qnw70jnKRoIAvtfq4lvRTfhTddCvBBUO3GItYvVPXhj+7h7kZcohQVNnu5bVrPh1/pZ7REoKoWSaUgxrOqcM60P3PqrAznEmtyEDO7zZH+DWWaLQW+g/Y2yUh96dNAJsZ1pKcpFvIlewuHfU9Jzl0VYhyDlFIlRF6MNu1GcdDi5Zn0IxXKbyL8/6irrxNMFitIlm5YF4Owe8MuSxspfzYQKfwJoaCiV2l3IcUk8yI5n+h+x9wSC3JzSm2vCitAzJyRV2SG+RDLRGLrzJxnqJR1EB5he4aMLYKrumC6nOIbjT0LWbvOt8qZTRlMCnqMfABXPcRwU9l2dh4/HzdDm//AA9Y8obdMo94dOdGl8IV7kCq2NZMTUHe9EKrV8iaWKc1/U1zXF+2QkPXFj52C8uvRXFDSw7J7E17Wbgwk/A2ElkkI01sAoIXQ5yOPnt6A5a2ZmnPgPkgfto4i/gmk6KT8pqKPVhqxSQeLKBg+qMjVLYWtIpJU8CORizMhbuN1BOKQCE4N0EkcHK9N8RBlwIHkzRGt0fax5wsV2VBUO1Q/W1UdCie2XwV0hOmH9wpUGwd2joof5zWuNKBLlcUu6TiwBOg3N/XcEulurANq1kptRXc920KkiEh8OXLaZgPpDbTrVzr5hbe6Ajt1/cSUD6ywo9n9f8I/zeryORcWAAvBIMbpro6LLNQmM66LErniTBDuqFTm2dB5j1zmdfMroOh9z/UvB9hDwOVvjNHN75/vPt6Sk5W0MP+pcu2W+4cfDFZX1N7K7A0BZm+aMHHF34F71L4eRCuY4d+ TXE9msXi pyYf0aAJCEVxFC4h6PKUTHGBxF6jinTUjHXZBY7SPzqrlNenoQTBwEUgQtFwVJdRJuprOMPQiQZ1mVyQAmz/8UoJaAz3djWOyE6PBpZGLp730lU7JiFH0KVVQE4UrMzhALEDET+mTzt9yzI02lcr7T75S1fRbH1KHq4y2URY8An3e7dMxrWahOQRNLx6qTXjqND8E1MR6CtfuBancLy6Q0H4PO3EDQvOJ7YOh9Q+il0uqUYNoUSgYfrb8FWtNiW3kTv1Ei0O8rw5FLVbhAJFLjJupT4F6/BjvVca/mWwYoW1O0nkMbLu7BKIu8vkokuygm7P/MRfaOl+MsWBoC7tKQ/SQfgYKwOXMezMv6dQVdc9f+OB7WgJ0ytylk4UUBIi3AMEXW1upVsxT0I4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Provide a hook that can be used by custom memcpy implementations to tell KMSAN that the metadata needs to be copied. Without that, false positive reports are possible in the cases where KMSAN fails to intercept memory initialization. Link: https://lore.kernel.org/all/3b7dbd88-0861-4638-b2d2-911c97a4cadf@I-love.SAKURA.ne.jp/ Suggested-by: Tetsuo Handa Signed-off-by: Alexander Potapenko Cc: Dmitry Vyukov Cc: Marco Elver Cc: Linus Torvalds --- include/linux/kmsan-checks.h | 15 +++++++++++++++ mm/kmsan/hooks.c | 11 +++++++++++ 2 files changed, 26 insertions(+) diff --git a/include/linux/kmsan-checks.h b/include/linux/kmsan-checks.h index c4cae333deec5..e1082dc40abc2 100644 --- a/include/linux/kmsan-checks.h +++ b/include/linux/kmsan-checks.h @@ -61,6 +61,17 @@ void kmsan_check_memory(const void *address, size_t size); void kmsan_copy_to_user(void __user *to, const void *from, size_t to_copy, size_t left); +/** + * kmsan_memmove() - Notify KMSAN about a data copy within kernel. + * @to: destination address in the kernel. + * @from: source address in the kernel. + * @size: number of bytes to copy. + * + * Invoked after non-instrumented version (e.g. implemented using assembly + * code) of memmove()/memcpy() is called, in order to copy KMSAN's metadata. + */ +void kmsan_memmove(void *to, const void *from, size_t to_copy); + #else static inline void kmsan_poison_memory(const void *address, size_t size, @@ -78,6 +89,10 @@ static inline void kmsan_copy_to_user(void __user *to, const void *from, { } +static inline void kmsan_memmove(void *to, const void *from, size_t to_copy) +{ +} + #endif #endif /* _LINUX_KMSAN_CHECKS_H */ diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c index 5d6e2dee5692a..364f778ee226d 100644 --- a/mm/kmsan/hooks.c +++ b/mm/kmsan/hooks.c @@ -285,6 +285,17 @@ void kmsan_copy_to_user(void __user *to, const void *from, size_t to_copy, } EXPORT_SYMBOL(kmsan_copy_to_user); +void kmsan_memmove(void *to, const void *from, size_t size) +{ + if (!kmsan_enabled || kmsan_in_runtime()) + return; + + kmsan_enter_runtime(); + kmsan_internal_memmove_metadata(to, (void *)from, size); + kmsan_leave_runtime(); +} +EXPORT_SYMBOL(kmsan_memmove); + /* Helper function to check an URB. */ void kmsan_handle_urb(const struct urb *urb, bool is_out) { -- 2.44.0.291.gc1ea87d7ee-goog