From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D6ADC54E58 for ; Thu, 21 Mar 2024 20:31:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC3AB6B0087; Thu, 21 Mar 2024 16:31:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4C176B0088; Thu, 21 Mar 2024 16:31:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ECC86B0089; Thu, 21 Mar 2024 16:31:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 89A8B6B0087 for ; Thu, 21 Mar 2024 16:31:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52E8B1409DD for ; Thu, 21 Mar 2024 20:31:53 +0000 (UTC) X-FDA: 81922192506.02.A7FB6BA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id B2AFB40028 for ; Thu, 21 Mar 2024 20:31:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=myqqqaYb; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711053111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5bivwr0w6V4Aq5kxqPnIVYurFU/PCEOCVDjr9lQ9raQ=; b=xc5EaI4RuxGf3hRhLT1Vh00x4EXdiJbGIza7yF23putz8ycfiJx8NCUEXuJg294oIft7Di os8YWCokZBXrS46tpRn8uMQeV6ePFZnOPnHOOHKh2bkwMbyLSxOk5rj0bAgVgLpo5++fjl B5uRhlPzhohpRSPf9jSbIGMk7K03FEo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711053111; a=rsa-sha256; cv=none; b=lE1L2Bbn805DcRn7G/CQpL22hJ6SriuKOl12g3ePTVzD3RGL/Z536VebZD4vhy9zHVCa9D 035/ntEkBfzTiSTlAMbJxPfiZwQVhUUH/hCUle0Wwcwq+mgQiX/5/dYN90NOX2rKb4oKsJ IuK8ncvDSXeZusnGZKsrN6LVmYqqsa0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=myqqqaYb; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6DE5C6122A; Thu, 21 Mar 2024 20:31:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C826DC433C7; Thu, 21 Mar 2024 20:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711053110; bh=baRa6A2qOinOd5YVAtWej5lfyO2Yw47YmlHbzlE1Jvg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=myqqqaYbliRJE7PVgZhrPNW4VsZSILLB+0SlZqyShzqltI9nE6pTdWnygoFZn4dbb cd7SNGeTgLc7GfmU2xwl33gTqeb9pkt91tBji4fk8llEMAbUkAQtFXJU5/LCiWBvgC EtAkHaVZ9tqLwxhvUHQb1iYeHrpwdBWq8Zx/XJf4= Date: Thu, 21 Mar 2024 13:31:47 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Subject: Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro Message-Id: <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> In-Reply-To: <20240321163705.3067592-6-surenb@google.com> References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-6-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B2AFB40028 X-Rspam-User: X-Stat-Signature: c1zg3cmi9yg39qessq8dxr6smzjau3du X-Rspamd-Server: rspam03 X-HE-Tag: 1711053111-47821 X-HE-Meta: U2FsdGVkX1/NiXOIkbwUyvnuPsOQkT38RjdvSGYwMwtZHginEXPk/w6+gJD16ZDt6iYvHjCzTqmjSAcNP2JLfESdR+VhEhTVILoZ9+9Yhm4ppBPAo0zstDIUpuAh8mLe6XJIQv+bj8GAN8aWhTgr5FzrG1Y6bv8jaQhlvDI/vxlhZZyzETtkrf8eRxvO3MVv5O+GPkyCwXc6bYlRGDW3eA/OZlXcVlednCfNxBo8Uo0jbigv64m9mZ6v+JSpN1G0ElP/RU/m/j3z4DSM3T4CwtznSh+yj4gLY/AhSAIiwK1fkJ2t5Uj76aEtuz7/s7/3jW+b7mrzeQSeNJWw3XF9LVteJB9nGITg8qEf5JGEaVjo+mCZ0BVxF2Ubnm0P5fFuMgf1kGD8HBHB2CP9E0poUEj8kmBEIlgUFLU0kOF4gVYe2rt2sbEXEDw4w8cJZ4D9e1q8ehZkLA1+8UIBz4FgRjvaGy6ggoliQVQKOeV8K7CVdn2zYl3g0yBi6+yPohXqf1eSJD4PZg00jC0mHIOR3UxtheH3dlyvOv96JQs+0I5Ds+6raW06Qbwwr7Ujxtw5YIk9ctjoasbE0W2/gZiqw8xaCeshDV6tOCDmOSY0pgsbvrEPS1hyLEqRuYRnPgiPUMIII3dTpi96rHG51QTphkCyObDsx/5MbqKMeBaesDyTcFuhNUu9U4J8q/PfD1JeEYrG7qdMVgqeltknSTNaT81WfpE01NmjZtZd4ZjDWc3CW0lhxwHBpJQIQ4YiEQL1Z/2eZW4G7dEodUtBmzMhSbtJd2x8w94xAPsmctITCjVpWYTJCVb7p9ue/2VtNM1befn6wu6kr03xnzN/uFpe25TgLG9JPFO4r8MLuiG+KNArS3/L3o77og79xXOKM4Wegg+y6uJ1S2F8t6F5tFNaRJhnqjQDP/KqP8zZ6PE370P9h1Fiz3mHli7lScqhKc4SHWg9C9xKebZMpr0Z1NV OJfrlIKW CkPrvCIXceC/EavpKDo4//gqCSB2iGUJmGXPqvTi9GfICPIXd3bnRhnND1AhmMf3lxKAw46N/xFVIM3E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan wrote: > From: Kent Overstreet > > We're introducing alloc tagging, which tracks memory allocations by > callsite. Converting alloc_inode_sb() to a macro means allocations will > be tracked by its caller, which is a bit more useful. I'd have thought that there would be many similar inlines-which-allocate-memory. Such as, I dunno, jbd2_alloc_inode(). Do we have to go converting things to macros as people report misleading or less useful results, or is there some more general solution to this? > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3083,11 +3083,7 @@ int setattr_should_drop_sgid(struct mnt_idmap *idmap, > * This must be used for allocating filesystems specific inodes to set > * up the inode reclaim context correctly. > */ > -static inline void * > -alloc_inode_sb(struct super_block *sb, struct kmem_cache *cache, gfp_t gfp) > -{ > - return kmem_cache_alloc_lru(cache, &sb->s_inode_lru, gfp); > -} > +#define alloc_inode_sb(_sb, _cache, _gfp) kmem_cache_alloc_lru(_cache, &_sb->s_inode_lru, _gfp) Parenthesizing __sb seems sensible here?