linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret'
@ 2024-03-21 11:56 kernel test robot
  2024-03-22  2:54 ` Zhijian Li (Fujitsu)
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-03-21 11:56 UTC (permalink / raw)
  To: Li Zhijian; +Cc: oe-kbuild-all, Linux Memory Management List, Helge Deller

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e7528c088874326d3060a46f572252be43755a86
commit: 0688d3b1d882dd1dcf73305306e71ebf1653f595 [13900/14187] fbdev: panel-tpo-td043mtea1: Convert sprintf() to sysfs_emit()
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403211931.wVl6ymAV-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: In function 'tpo_td043_gamma_show':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' [-Wunused-variable]
     228 |         int ret;
         |             ^~~


vim +/ret +228 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c

f76ee892a99e68 Tomi Valkeinen 2015-12-09  222  
f76ee892a99e68 Tomi Valkeinen 2015-12-09  223  static ssize_t tpo_td043_gamma_show(struct device *dev,
f76ee892a99e68 Tomi Valkeinen 2015-12-09  224  	struct device_attribute *attr, char *buf)
f76ee892a99e68 Tomi Valkeinen 2015-12-09  225  {
f76ee892a99e68 Tomi Valkeinen 2015-12-09  226  	struct panel_drv_data *ddata = dev_get_drvdata(dev);
f76ee892a99e68 Tomi Valkeinen 2015-12-09  227  	ssize_t len = 0;
f76ee892a99e68 Tomi Valkeinen 2015-12-09 @228  	int ret;
f76ee892a99e68 Tomi Valkeinen 2015-12-09  229  	int i;
f76ee892a99e68 Tomi Valkeinen 2015-12-09  230  
0688d3b1d882dd Li Zhijian     2024-03-19  231  	for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
0688d3b1d882dd Li Zhijian     2024-03-19  232  		len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
0688d3b1d882dd Li Zhijian     2024-03-19  233  	if (len)
f76ee892a99e68 Tomi Valkeinen 2015-12-09  234  		buf[len - 1] = '\n';
f76ee892a99e68 Tomi Valkeinen 2015-12-09  235  
f76ee892a99e68 Tomi Valkeinen 2015-12-09  236  	return len;
f76ee892a99e68 Tomi Valkeinen 2015-12-09  237  }
f76ee892a99e68 Tomi Valkeinen 2015-12-09  238  

:::::: The code at line 228 was first introduced by commit
:::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb

:::::: TO: Tomi Valkeinen <tomi.valkeinen@ti.com>
:::::: CC: Tomi Valkeinen <tomi.valkeinen@ti.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret'
  2024-03-21 11:56 [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' kernel test robot
@ 2024-03-22  2:54 ` Zhijian Li (Fujitsu)
  2024-03-22  6:05   ` Helge Deller
  0 siblings, 1 reply; 3+ messages in thread
From: Zhijian Li (Fujitsu) @ 2024-03-22  2:54 UTC (permalink / raw)
  To: Helge Deller
  Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List,
	kernel test robot

Helge

Should I send a new version(v4) to fix this.



Thanks
Zhijian

On 21/03/2024 19:56, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   e7528c088874326d3060a46f572252be43755a86
> commit: 0688d3b1d882dd1dcf73305306e71ebf1653f595 [13900/14187] fbdev: panel-tpo-td043mtea1: Convert sprintf() to sysfs_emit()
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202403211931.wVl6ymAV-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>     drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: In function 'tpo_td043_gamma_show':
>>> drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' [-Wunused-variable]
>       228 |         int ret;
>           |             ^~~
> 
> 
> vim +/ret +228 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
> 
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  222
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  223  static ssize_t tpo_td043_gamma_show(struct device *dev,
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  224  	struct device_attribute *attr, char *buf)
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  225  {
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  226  	struct panel_drv_data *ddata = dev_get_drvdata(dev);
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  227  	ssize_t len = 0;
> f76ee892a99e68 Tomi Valkeinen 2015-12-09 @228  	int ret;
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  229  	int i;
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  230
> 0688d3b1d882dd Li Zhijian     2024-03-19  231  	for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
> 0688d3b1d882dd Li Zhijian     2024-03-19  232  		len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
> 0688d3b1d882dd Li Zhijian     2024-03-19  233  	if (len)
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  234  		buf[len - 1] = '\n';
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  235
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  236  	return len;
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  237  }
> f76ee892a99e68 Tomi Valkeinen 2015-12-09  238
> 
> :::::: The code at line 228 was first introduced by commit
> :::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb
> 
> :::::: TO: Tomi Valkeinen <tomi.valkeinen@ti.com>
> :::::: CC: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret'
  2024-03-22  2:54 ` Zhijian Li (Fujitsu)
@ 2024-03-22  6:05   ` Helge Deller
  0 siblings, 0 replies; 3+ messages in thread
From: Helge Deller @ 2024-03-22  6:05 UTC (permalink / raw)
  To: Zhijian Li (Fujitsu)
  Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List,
	kernel test robot

On 3/22/24 03:54, Zhijian Li (Fujitsu) wrote:
> Helge
>
> Should I send a new version(v4) to fix this.

No, it's ok.
I've fixed it up already.

Thanks!
Helge

>
>
>
> Thanks
> Zhijian
>
> On 21/03/2024 19:56, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   e7528c088874326d3060a46f572252be43755a86
>> commit: 0688d3b1d882dd1dcf73305306e71ebf1653f595 [13900/14187] fbdev: panel-tpo-td043mtea1: Convert sprintf() to sysfs_emit()
>> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/config)
>> compiler: sh4-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202403211931.wVl6ymAV-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>      drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: In function 'tpo_td043_gamma_show':
>>>> drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' [-Wunused-variable]
>>        228 |         int ret;
>>            |             ^~~
>>
>>
>> vim +/ret +228 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
>>
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  222
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  223  static ssize_t tpo_td043_gamma_show(struct device *dev,
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  224  	struct device_attribute *attr, char *buf)
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  225  {
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  226  	struct panel_drv_data *ddata = dev_get_drvdata(dev);
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  227  	ssize_t len = 0;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 @228  	int ret;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  229  	int i;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  230
>> 0688d3b1d882dd Li Zhijian     2024-03-19  231  	for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
>> 0688d3b1d882dd Li Zhijian     2024-03-19  232  		len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
>> 0688d3b1d882dd Li Zhijian     2024-03-19  233  	if (len)
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  234  		buf[len - 1] = '\n';
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  235
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  236  	return len;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  237  }
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09  238
>>
>> :::::: The code at line 228 was first introduced by commit
>> :::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb
>>
>> :::::: TO: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> :::::: CC: Tomi Valkeinen <tomi.valkeinen@ti.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-22  6:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-21 11:56 [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' kernel test robot
2024-03-22  2:54 ` Zhijian Li (Fujitsu)
2024-03-22  6:05   ` Helge Deller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).