From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F55C54E64 for ; Mon, 25 Mar 2024 17:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35DB6B0087; Mon, 25 Mar 2024 13:49:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6056B0088; Mon, 25 Mar 2024 13:49:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D38D56B0089; Mon, 25 Mar 2024 13:49:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C0FD66B0087 for ; Mon, 25 Mar 2024 13:49:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6E5EC1A0710 for ; Mon, 25 Mar 2024 17:49:44 +0000 (UTC) X-FDA: 81936299088.27.DD11E1F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id ACA291A0011 for ; Mon, 25 Mar 2024 17:49:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bKfexc/+"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711388982; a=rsa-sha256; cv=none; b=01fi5D7yHvvm61mDGtxvRd9PWtq8sFs+PA0u+t1f1YgjcAu4zAlc+ddA2aXVOq+QqsTOTr QI+FQ4hjmrUF/345q051zba2zoFEBzxcIZWsLObVocjD0Ti9YEQfaENt/WddrvBi1QsOg0 042zOIfbLuhNeRR67HkQ2PQO4AepFys= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bKfexc/+"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711388982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K+GhxBixP5JjAGdOkr+lUVwgcmucBfd7EsXTC56o3cw=; b=3ATmyZxPGwNvZqkCI8v+h2yIHB3HNcSLwCxbU6DzRa7MKasvYjlM0PFsOBlRU/QRGWqTZ3 9mo/xAy/XFs2nWAZaRW0H8Ph/loc7PsUK7hlr4yY51wB5ODjraoincj2soIF2Ea6LdjhCh M4A2WArSNNTbThe87+xKS8QHtFnF+Us= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8694C61195; Mon, 25 Mar 2024 17:49:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4ADB6C433C7; Mon, 25 Mar 2024 17:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711388981; bh=kJfO/BrlPE8tCgQXkg2kSQI8OJ92v+1fHUZt71+VhVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bKfexc/+lfT4SRm62Lng7zX6lZq75sOyRRJUXmJKIlK+QAS+taJkEcsby4Kfz4xkr YALAT4dZAnKbriRzIpLLWbSbSSRnq9e6ANpPcgklTK+s/aEdiCKBbBjt2kPW6aVcuw KbBvOWooB+yiCkVCAW+EqtxXVSmIYTUhvFZNh6eEJUFUzqRwAulocVWnHSmTgpP43R QbaUcExk5jihHzQqE6B1MuhEUIF0QGFsRwuoz5n4cL/Y/omAfQchozrH1NxycImg+n 2EMv+dn1NmOtYMPhp2TO1/FxfJ5bScasT+boWP5/5F6m1gskQ6ZkcnH3EnxU+Q0732 SSgtXbLrUBrDQ== From: SeongJae Park To: Suren Baghdasaryan Cc: SeongJae Park , mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 30/37] mm: vmalloc: Enable memory allocation profiling Date: Mon, 25 Mar 2024 10:49:34 -0700 Message-Id: <20240325174934.229745-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ACA291A0011 X-Stat-Signature: dxmqmsxb5twuuxpfhkwoy8wthj57ydmw X-HE-Tag: 1711388982-722577 X-HE-Meta: U2FsdGVkX1+pH20exOzfqo/2E8Rdcyc5LatqG6m/9TKd+oN9wTZCrk3326tCBucUDzg+JHfWC4iKeiJ/wVxdGND2zxVNBh6M4fLQL68ab0FSYnTCC/E/ua1NgPHLKvXbq/PhJWmXvif+uXgZTXn/CdgEjvDNTiRPVp8u+oqYz0IvPuV+0e5vXm0YAC6663PoqLOClMJJ6mouJurG9JMI1dRmOfeCLC8ZDt616m0B5lB2CHE51qMIG/qYFWEgDxVZzdfJgGjBUxPDeCwoU7MMYKYzhxSnfwX0mJ+GcGr72zlH6Td4VENBqdctUKVkfHOSxvLV5cqEai+X4MAoacYzFEzLMlgsb9I3e0dqQtSktH6NljtM6QgR3/K6/U2tN+3PqQIwORv7GBJDou3MY0hcArN5oIdvG/jdPU9bZsWKFN6FzXMq0X7yp4heUD35AkZ3o2Yuq5e4TQUg0zWnH5xYsyfU1Yj/o3en8CCBYUYcr5y+uy77KNjj/gIaZCrqaYcrpc+6GlsZKfuRlNA8D8/On8QhE5SpwNEg66LB6FmD61D9HcA10ohWei3BJmPGjelupfdPWanTD0ojY1Tk34CMYeu5QD37DDwiwGKjxx1wdTGzWoj7VeNDFb57LKiZqZkUMPj6/7QXOIcE4nHjP0vKUZfjqjlvmxN9DGJiDLeQEHYMaDCmh2wFQIE/rGPo7PnFFIDEI1hVA+cMW3SSEvzO8Qn2BAS/qwZmU7bSfCotBTSad6Fv08Bohuao6E+mnt222TzrmvF+KGzSy6uZLUpNbfIjNSS2pT2GuArPAgsTnR7/BcPS5YJmIRBS0+6+B7r8kiR0W+BmtzBDUfUrND1SELgmIOXiEKw61KIMUHncHIqV+je1gU5MONzn+V4e8Fy0gVemk58I1osT+qfUKK5LqcOt53s9XLMzbothoF63KRsLoK0YDmOtnpHeg72vu4OdRWLQ788MEJTRkr8Xock cHNrJPF4 Eokxq/MWa6l6ilxX794PKkaiFFUJeXu2TFAEyZWLwNq2UGMsCLBvFTvrQbKqgnOL+KQ2dO5l6BcjIsxqAslnkCwUMJZudgm2b7gDhF7gBJF7mMk+uFJKmByktf2IT03hPJI8bYjxSH4+39hIeTy0agqzLpgpKJoJjM9oZxzUEFs85KyaxgkFRDV7IMhUQcz1DCRQRbYQhnbIgfqMCHer0DiavZYmvkmj8ex6TWOG4oobDKDRv6SJdk68iMAaPWiEWEDZ2nzcZZxW3HQezmPRlU1wvLw4XPjfOXhsP5+jxEUX018ki0jN1911TQ12iOzjLKtTO7f6stu+asZzbLFURkjOpGEPouyQ82441ZllQ3HlK3Ukd4zyl9fmDBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 25 Mar 2024 14:56:01 +0000 Suren Baghdasaryan wrote: > On Sat, Mar 23, 2024 at 6:05 PM SeongJae Park wrote: > > > > Hi Suren and Kent, > > > > On Thu, 21 Mar 2024 09:36:52 -0700 Suren Baghdasaryan wrote: > > > > > From: Kent Overstreet > > > > > > This wrapps all external vmalloc allocation functions with the > > > alloc_hooks() wrapper, and switches internal allocations to _noprof > > > variants where appropriate, for the new memory allocation profiling > > > feature. > > > > I just noticed latest mm-unstable fails running kunit on my machine as below. > > 'git-bisect' says this is the first commit of the failure. > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > [10:59:53] Configuring KUnit Kernel ... > > [10:59:53] Building KUnit Kernel ... > > Populating config with: > > $ make ARCH=um O=../kunit.out/ olddefconfig > > Building with: > > $ make ARCH=um O=../kunit.out/ --jobs=36 > > ERROR:root:/usr/bin/ld: arch/um/os-Linux/main.o: in function `__wrap_malloc': > > main.c:(.text+0x10b): undefined reference to `vmalloc' > > collect2: error: ld returned 1 exit status > > > > Haven't looked into the code yet, but reporting first. May I ask your idea? > > Hi SeongJae, > Looks like we missed adding "#include " inside > arch/um/os-Linux/main.c in this patch: > https://lore.kernel.org/all/20240321163705.3067592-2-surenb@google.com/. > I'll be posing fixes for all 0-day issues found over the weekend and > will include a fix for this. In the meantime, to work around it you > can add that include yourself. Please let me know if the issue still > persists after doing that. Thank you, Suren. The change made the error message disappears. However, it introduced another one. $ git diff diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c index c8a42ecbd7a2..8fe274e9f3a4 100644 --- a/arch/um/os-Linux/main.c +++ b/arch/um/os-Linux/main.c @@ -16,6 +16,7 @@ #include #include #include +#include #define PGD_BOUND (4 * 1024 * 1024) #define STACKSIZE (8 * 1024 * 1024) $ $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ [10:43:13] Configuring KUnit Kernel ... [10:43:13] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=../kunit.out/ olddefconfig Building with: $ make ARCH=um O=../kunit.out/ --jobs=36 ERROR:root:In file included from .../arch/um/kernel/asm-offsets.c:1: .../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes] 9 | void foo(void) | ^~~ In file included from .../include/linux/alloc_tag.h:8, from .../include/linux/vmalloc.h:5, from .../arch/um/os-Linux/main.c:19: .../include/linux/bug.h:5:10: fatal error: asm/bug.h: No such file or directory 5 | #include | ^~~~~~~~~~~ compilation terminated. Thanks, SJ [...]