From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48389C6FD1F for ; Tue, 26 Mar 2024 15:40:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C04976B0092; Tue, 26 Mar 2024 11:40:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB43D6B0095; Tue, 26 Mar 2024 11:40:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2E466B009E; Tue, 26 Mar 2024 11:40:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 90CF56B0092 for ; Tue, 26 Mar 2024 11:40:07 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6212A160D56 for ; Tue, 26 Mar 2024 15:40:07 +0000 (UTC) X-FDA: 81939601254.17.2D32625 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id AD5AFC000F for ; Tue, 26 Mar 2024 15:40:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qyKA41Y/"; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711467605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dx9N7OwJ25HB8abimiLLiOJ4v7dk6iTkAyGBqy6/tXU=; b=pK79Sj869dOXsTU2r30GZd6VZZVWcOqV3rZN19z3iFX4wGs4taOiENvULwxw2nS3lQ4d29 KbbJMToNseo7tF9P04fIlMUw0ULQlPZm/2JzlwqcziD4P/ObI18ReYpvZvacMXRkG6oulb YaijJ54TinU98grQmTB9h+CQZXbU/RU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711467605; a=rsa-sha256; cv=none; b=XkM3Ln0ulVT1KyqTSOeG7YF/ztDP4qdxvs9lNal7wgv8VfJQNPNVtepPlDIZAPdBuwqdZb +gcXhVDRFy/MPIStzHVm9X9l/VdzNjUXGtIRabaTcMy1ZAirkWd3mkYymg+SHvgQPDUmo5 1JjOqWTN4wYnMQtThniWTUiUCGRP8ys= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qyKA41Y/"; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 58967CE1F82; Tue, 26 Mar 2024 15:40:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9697C433F1; Tue, 26 Mar 2024 15:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711467600; bh=ztmkPAB0U1ULXqxkAJmpV7w+Ysid9k8KKpLkRxinnKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qyKA41Y/u8Cszywiz7OK3FbbmiKGQ9C4dXlmSowzO0eODtV3XQMYhndL6LqSSCExc gSr5KriK7AK/eduOXCzUuM9/M/JTph42YYV7yXqy/Ep5e4C8RdOMDwEY3NB+TWhosG ynhFk3x5fLusreKA62Lb5K8LI+Hrn02SMQKKQERtg/F9T4BStRFCcanXEuZXn7koxg lsnbct8Q5TAF/wUov8x/pcO/9j1j/+eoZC8z34hhlBPd/+k36MCtc3hIUbdc3qsQoD O7ZTB0GZ/L4AyBehCj5ri1j5aP5jWLIf/OTq2a320InuObeAqCv/u7gXamunek3p0/ fkdWsgil6eNBQ== From: SeongJae Park To: Suren Baghdasaryan Cc: SeongJae Park , hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 30/37] mm: vmalloc: Enable memory allocation profiling Date: Tue, 26 Mar 2024 08:39:54 -0700 Message-Id: <20240326153954.89199-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AD5AFC000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: t6k886mt3kxugjbh9ccm9j8eazqkrrs1 X-HE-Tag: 1711467604-772039 X-HE-Meta: U2FsdGVkX18xqvBExrf8826Gal0QJhsSGrvwDC0TnaojJ/YS1LhEpZGpgv0XwrLqstxoQ8pvo8aCgO96g4aVjthfjxROuAvkT7cu+IdVyml9oO7MQ1FzZSdLrkuLWx1KBOReNdUudYZm6T/sGEubXpCMb8+pN9Mg8HmZAvXxGgzzHtswmh6PytBzZ5CPalCJ+8k/WJofFeXW4jiV9dfFQcEdq7TOS0nJp0VPVKVuxckLAHgsiBCrTnJ2ALrMLvCj9UepbFfrmUAQ8l4uMAlPklZuYbF3ZaZYUK8iawCY4uMr5B00AJQTrBarsyQEzZF0w8U3jrz3MhGuWplCKfJ8UzHNGsyVelDQA3fD6xmcvlxwmZpcZEGbqmcWCItR6Y7rLRKh2JipQOJ1Dc1Wev6CImjdBIN8lTqAVNl+Y2nKxmHEiSx08pX38hoU9BlM+wruUvpYREW1fC7lqV5Mnj+jek2PpyuxAN6QwOExdCthygg4VfJHFezRUQ1wHpU7yHQtJb3lEwrVbSGLjoLZgHkVhsAeYMC4z0bn0kSp6u/LOtNbwcsu1uvXeD3tvd+C1V9OEaf3N+Al7Kp9ICy7id6kfsW1AW+tede4IifW8Mz0kLJ/gW7B9lqG+5EMaq5usdHBDPVPVDrkmozdUsd5HdFKYHAywyo3TmVi6rQF5r3ynMLlwOGUPrJ49OlPOUKK0h4nZAE6ahfBn/iBrFxeB8w/o5fMwaAshxENdoBKXqxUX622BwnqY39P8UNe0JExkVpk9w1HvFnAnqk33mQAdGjFuOibT49otRfYUlGQlLXaZ3PT3qhGGM52BymCvxuhHJQS0lK5T01R7Kgs6VATyfHBJ+dXVoHnwCT+L3wmf5LWXB6QMBEUBWlCnpx8rvhYaWEWaTl4tmybgHvHipWe2Waz2NnC5gYu4GvhlqCSTA1UOFprXWQfmuBIH+UIzlhoxP4dsPf/S54Eu9LFIqf5jZL JeA0pG77 LEKf9iwBy7fEMliOE/5h1dc1iK84gRwfaiXYLXfrkakKwuFYdwwyy0rASDPcz12MWXwAXbt7ZUeg+/GlJBL4wb9j952F17UB2xGASq46q95Ad/w500n/OGxIFPULpZSweRFxPIFqVq3X9YDXhiKQSKZendrc6xVawk+GM3FrUuMzN3wdiB6ae1oYLp5f7OPicmJx5hh6iuB3MDZPsOxy55CZwAaw1qDuifvxHFW6+P5C26gJu4aFRE5uGa6vNVFEG3COUq1wRh5qtRiBJx0vLMM5iBqstpklabC+A5o2Rm9f7hoxfgeUB8ntr3wUrqH5Q95pue+nJgDO/8XdBETz27Qyq5t/FFV9Pr2ICXe1EKHJPFX+DxAo/sAZ/KA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 26 Mar 2024 00:51:21 -0700 Suren Baghdasaryan wrote: > On Mon, Mar 25, 2024 at 11:20 AM SeongJae Park wrote: > > > > On Mon, 25 Mar 2024 10:59:01 -0700 Suren Baghdasaryan wrote: > > > > > On Mon, Mar 25, 2024 at 10:49 AM SeongJae Park wrote: > > > > > > > > On Mon, 25 Mar 2024 14:56:01 +0000 Suren Baghdasaryan wrote: > > > > > > > > > On Sat, Mar 23, 2024 at 6:05 PM SeongJae Park wrote: > > > > > > > > > > > > Hi Suren and Kent, > > > > > > > > > > > > On Thu, 21 Mar 2024 09:36:52 -0700 Suren Baghdasaryan wrote: > > > > > > > > > > > > > From: Kent Overstreet > > > > > > > > > > > > > > This wrapps all external vmalloc allocation functions with the > > > > > > > alloc_hooks() wrapper, and switches internal allocations to _noprof > > > > > > > variants where appropriate, for the new memory allocation profiling > > > > > > > feature. > > > > > > > > > > > > I just noticed latest mm-unstable fails running kunit on my machine as below. > > > > > > 'git-bisect' says this is the first commit of the failure. > > > > > > > > > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > > > > > [10:59:53] Configuring KUnit Kernel ... > > > > > > [10:59:53] Building KUnit Kernel ... > > > > > > Populating config with: > > > > > > $ make ARCH=um O=../kunit.out/ olddefconfig > > > > > > Building with: > > > > > > $ make ARCH=um O=../kunit.out/ --jobs=36 > > > > > > ERROR:root:/usr/bin/ld: arch/um/os-Linux/main.o: in function `__wrap_malloc': > > > > > > main.c:(.text+0x10b): undefined reference to `vmalloc' > > > > > > collect2: error: ld returned 1 exit status > > > > > > > > > > > > Haven't looked into the code yet, but reporting first. May I ask your idea? > > > > > > > > > > Hi SeongJae, > > > > > Looks like we missed adding "#include " inside > > > > > arch/um/os-Linux/main.c in this patch: > > > > > https://lore.kernel.org/all/20240321163705.3067592-2-surenb@google.com/. > > > > > I'll be posing fixes for all 0-day issues found over the weekend and > > > > > will include a fix for this. In the meantime, to work around it you > > > > > can add that include yourself. Please let me know if the issue still > > > > > persists after doing that. > > > > > > > > Thank you, Suren. The change made the error message disappears. However, it > > > > introduced another one. > > > > > > Ok, let me investigate and I'll try to get a fix for it today evening. > > > > Thank you for this kind reply. Nonetheless, this is not blocking some real > > thing from me. So, no rush. Plese take your time :) > > I posted a fix here: > https://lore.kernel.org/all/20240326073750.726636-1-surenb@google.com/ > Please let me know if this resolves the issue. I confirmed it is fixing the issue, and replied to the patch with my Tested-by: tag. Thank you for this kind fix, Suren. Thanks, SJ [...]