From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9B8C54E67 for ; Wed, 27 Mar 2024 17:40:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831466B008C; Wed, 27 Mar 2024 13:40:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2276B0092; Wed, 27 Mar 2024 13:40:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AA026B0095; Wed, 27 Mar 2024 13:40:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4BDA56B008C for ; Wed, 27 Mar 2024 13:40:19 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F12E8140DDF for ; Wed, 27 Mar 2024 17:40:18 +0000 (UTC) X-FDA: 81943532916.21.3E1619E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 8AF5580021 for ; Wed, 27 Mar 2024 17:40:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lyan0XKk; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711561217; a=rsa-sha256; cv=none; b=GI28aujrxg9Y4lAsAdtTdteidPkAlD5hbLA4gWbbx2TGA7ObmQmspa6ZWybsudSJ7iNdGW WF0tC9wBeh3xHoD7YlkBb/Y627pYAOfGpS0agpVIJOQ98vPc6Rx+n2v8EZPEGqAZ76PLsw iOPbElhpJd+wkcDy/6DIdok+hOAktuQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lyan0XKk; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711561217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9gUhvWDGuBI65NBfJdGMw/ZAutbEHQFUXBDUQkIrlrs=; b=UEBpgdd10zCQUSCWFSSswEefpztjjzo+gMJQ53K3XhgeFG8wZyos7eJE0XkAVpWvahsku4 fhthbkfuDvcMdQSATEBZUJRHnH2EMXxfoEAu0OHYKN+UOfx4Yhnqtf/8xM6r5+BzqQLIwR Eq+/izdA1n0OEnFM4I2OpXS5C4O7u4M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0411FCE26E9; Wed, 27 Mar 2024 17:40:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2EFC433C7; Wed, 27 Mar 2024 17:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711561211; bh=I6x60ia+rggB1OgVHo+pcCe2/5EmZUntXUlWS6xFGsQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lyan0XKkyPAmuDpmWQRdO4kPwUWsHKKFPRzR+jFMTZhBNdgDY1mzOh8Zvhp4h94Hf VQ0ynNWRsVmi8yXVhWA+xbqA28k23Dd1JQMjKNX4Jw0ahspmVHeKybdifIdb4XAofD UjdseAN13zD79wSDoh/4LweFnooobhxtunWjgEkM= Date: Wed, 27 Mar 2024 10:40:10 -0700 From: Andrew Morton To: Kemeng Shi Cc: willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-Id: <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> In-Reply-To: <20240327155751.3536-1-shikemeng@huaweicloud.com> References: <20240327155751.3536-1-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8AF5580021 X-Stat-Signature: 6pofxeduujqscaaz4om4oug7d5cnmhfp X-Rspam-User: X-HE-Tag: 1711561216-950330 X-HE-Meta: U2FsdGVkX19KXPpsOeRGU/YZKNbhn2QRKVEl/rT//7UMgQXSkNDQWM/SoeYfjei6/TTLqW9wCr75YBXd8Utb8w+7W/HHZzSSGoS1NW607ShnPQNvZn0haQScWqE9eH7Ve0pCXMFEQ48pw5Eay5HsprBUrUwT3Vh1ijb5EEwlpFl0NwoxlhF4YjNU8G9di3+BH/mM0rjFJHZUStco8DFwvuDNi7n1cX206TRbS3fzCDVqHIZg1UbVyc7OZulF4ioM97DHp4Xq1zsMOMKTC/99/u17LZLC9jk6WitBCy2ZdtaJWc+cezhvNsLHg1jjSuQiFhubgqcanZAPG/rcZQzXtO0ZKSkxEaJMHFvFjzLYAV6AdZ282ANhlXhdkLASySWJzPH4MD+X/gBxHlbmRVcwWzCnj/BKs3Jfn3CMLAIDDY4CKfXYrSfLvj9v9GDzGYxsJopz9M99PBTBTuh8wfj0Nh64bDe1yBhEl4p5Gjvlso3clohn8BWoa2rIOjNy6ACPWgjCE3wgICCVbfqqWC8TlM+qYW1paP0wJ6YO6QpRvIR4rzCMtLcQ1VN+Z5kN5rfeN8uiiICU16Y5+DYWvOeRs61X4xqGivOKWhwbRRTzh1LyrImffox9sQtvyvA9c3T1/UXLU87Mo90fsXHViYimNCdlO4FzJ+CMwxUB14rR5UUhCd1/+n4LLOubkVYktaBC13iaRQf4uKy5b3a0lKgCX5fBphLNtk/79dUCBtgX9mqHkIsKSGTr8/KCG9oYSjkRSFgOYGagrfhCG7e83jTXa7K3UK7LJyMjs5/dPm42RPGLNu76VJsCcGj/lzkm4IGGvIcodD+Kfz0bQHfABrfbWVtZkPFtYFMpCIXK268bC9b7F9u81xkYR65bpSULHBvw2dtJQPSqQ8bz0UmyUXqVS4LP/AEYpB/lDbcrnWvJTP2RJr6xmmi+SgsPUpUzLcVgZpKZplVsa0Ca4Rc15ui cOptObmZ 7aa1CoLOXcXiYoiWQAIO9WUN7iIMbOFsUj6wv0daKs+Vqc1G/XSu4e1AKl+j9jm2kQwygRzFU/fSUTGGnliUCPvigSr1B7LLXvYuFV2u1tvcI4WLkAZzmRhkFRTN3T9zLMfvzgIten2in4xP6unDjGUy6IwSZbcl2b9tNK3pdY15J8irUkpai4XQVxPdcXBaxUkl/ijy7ZoQxpGT5n29O0yeFjlSNhxBf7OBdR5suCl0mK7BOHrHbdodNgeBa5eM2Sr+i/fMeuyKuc6bSRuO9lhWiHutaq2Dzd3QW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > This series tries to improve visilibity of writeback. Well... why? Is anyone usefully using the existing instrumentation? What is to be gained by expanding it further? What is the case for adding this code? I don't recall hearing of anyone using the existing debug instrumentation so perhaps we should remove it! Also, I hit a build error and a pile of warnings with an arm allnoconfig build.