From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28478C54E67 for ; Wed, 27 Mar 2024 18:46:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A39D66B0083; Wed, 27 Mar 2024 14:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E9FD6B0085; Wed, 27 Mar 2024 14:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88A946B0087; Wed, 27 Mar 2024 14:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6AFCB6B0083 for ; Wed, 27 Mar 2024 14:46:42 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 369E61A051B for ; Wed, 27 Mar 2024 18:46:42 +0000 (UTC) X-FDA: 81943700244.24.A13B198 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf16.hostedemail.com (Postfix) with ESMTP id E926718000C for ; Wed, 27 Mar 2024 18:46:38 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZrZct37q; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf16.hostedemail.com: domain of lkp@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711565199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3TKNB5M5qskTyhKOGE5IlIDAMXy+A7HP0wJDfVl/Qz4=; b=nodrHe0RPTaOceqbJ95byyFzhn1uduBERcUSjgaqkdBgX3tzWqNC08ZJjzixPpeJnpZI5R tErt8fcB60nlat/WlSkr77GdhhB25KJZtiJ3zqV86oNp0TIxMpSfGztuCSdYJ1ymmCwhys ZS+EDmyVhb5xWYXydt/8z6uwnfNbO1Y= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZrZct37q; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf16.hostedemail.com: domain of lkp@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711565199; a=rsa-sha256; cv=none; b=HhsAG2aoq+Bf0oUuDTtSGI8K7QCwpxtLlSicCtos57d2HEdzcNEaftiND2suGXarqkzpLM AUBhU5Nb6BUjZCWBFNXBYwYLqe/+o/ohi15qGUDemH6cIeJSP+WKldeSWwBVkelOf7g1yT epQ8s4OzvpJTtPovoQZhQq7GCHytIgk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711565199; x=1743101199; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ieOUOpGzjx2JrI1c7nzuCkZNqnSREw7sXC7rWf+mwa0=; b=ZrZct37qYXm7XXLE3FxkftzuPAHhOPfhfqEIQC5sw1vBIjgYRHRzuCfX 1D5NtKIMAdH6nQXdAXxNmeKDUq6cRYiP2Sd3Nxyi4qwIHkN/DhFnL91G6 OmCXVl5tRbcR9GhEqTpUQnq22OFfmN2HAhqd7TUCWvezlaqmNGEIkZO2s sRzdj9n7oNAyQ0VHhRlEq6NrRF4rjXa3DhHXTHNniNGIuRzDto+jwXSN0 NZ9A2T5erkzrPCcs9ed6OUgMYqklAXxhPswOLt5a/aoTZfF+xNRoitJSw 3TRAvGkpu0aGQD3PHFf+3WshV1PgFrsMTeO6KyyVbFnK11zbj4Yp6BJOw w==; X-CSE-ConnectionGUID: r7MKG+AwRdeqeo/MxJBqRQ== X-CSE-MsgGUID: I9S0ojOOQXa61ACWDzPzAg== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="7292299" X-IronPort-AV: E=Sophos;i="6.07,159,1708416000"; d="scan'208";a="7292299" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 11:46:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,159,1708416000"; d="scan'208";a="16420701" Received: from lkp-server01.sh.intel.com (HELO be39aa325d23) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 27 Mar 2024 11:46:36 -0700 Received: from kbuild by be39aa325d23 with local (Exim 4.96) (envelope-from ) id 1rpYIE-0001NS-0b; Wed, 27 Mar 2024 18:46:34 +0000 Date: Thu, 28 Mar 2024 02:45:40 +0800 From: kernel test robot To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Matthew Wilcox (Oracle)" Subject: Re: [PATCH 01/10] sh: Remove use of PG_arch_1 on individual pages Message-ID: <202403280209.6eW34UZ5-lkp@intel.com> References: <20240326171045.410737-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326171045.410737-2-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E926718000C X-Stat-Signature: kjrzxaqhctosxxmc7c66kua6t33esfqr X-HE-Tag: 1711565198-101837 X-HE-Meta: U2FsdGVkX19rdqOBinJciqOQ2UP0sgfOc8IywFjUY75lBPd1uqeA1YhQNAjAV1JGUj2m+TcDzecaydTi/+RkeeOFmJrxyfk9O5Bmgl9GN258cWpWl3TDQx4W1hZSfJpuUNi8nm51J8S1d8RVR9G07UBnNa1+0RkSwLR9Jmq2N9qh1qxTSvPT7FZWU6nK7QwtgadWwqiYU+UynxI2jEV2unRSxt4G1tTfpipQ+Couj0WYkVM7jX9rYJhxUMpq2p1Y1l+9Bo3d5XQQpRbV0K9YUrTH/MqiNnQmp0FIB6z1K4WVO3ZUcKXYO/GSOSe/4nlm9fJHoEJuZzglcB0S//Q+QukEZ+QoAMKRgqMexL1WoHchmmkD1Cku8P9OBt8E2ohqAUthZLD+kveNFjJyNkbhmY1SwAjrLWnUVgJVrKj7cVKfgTJV7tRyfylY8KtTxIw5KWBEFKIoQvQyGZUSgOb/Bd3S/+gC00BZcbrXO+qPxv37PG4vc/v1LTKg3FtUOb6AmqUBBoEFrUbMVuw3tpdMSHrnY+BVy43HzZolFFVSSNzIAu1Y6T0l7NATk9K9WJOAjD/lmqNH0ydgm3EaZrsAQZLKBGL6lceS5/vDpzn5+pE2aEToH5gYl8ARrGQZRzN9AnmUC2ETIq8z9MgPwUwaE3NN1sr56E56AnXlXmc1GpeUsuAjInUB9DRyIrSLSRK2H5/k9L4T1GxW9GbGlAR7Z6pTsGzNWUxmLSEKMcQYYFBl6W/908JY3B+9xEm86HXSZbpq749K3lI4zrWO21oaUJlM2YvmNGot4jcfVa9OTczt8sc2OtgRRQstb45psNu2AuYFLdSW16jRzkG3oExYb9mjgOYcxX5fLwLZ2FEqbv0G+gD6h+RlvzkRZlUBLsdXesSCmq2v9rOeO4KIutJIrzHpz68+cjcq+aFwAeurqXE1RkoOTCSgQGwjbMl5B5zPrAFiEBc6tdpOwPQHRRG GI97ikG+ Y7NdfwySqOXg2urDp+NGRR9aUQkvPgvyqRG25LoLMa8BHaOCBVK0eQ4OFeJul84T08mkJ/Q7+guMKtKZwHLQEzio4HPEW1/JfDgC+zxYrIMpCk0a+F5T5dmqa9Olq9qZnbEIDwgHw8RkH/dCHnljTSOrP/cMSCRgQmuiAy8k+CUmfns3EjOg9KcT3FpVPRs2kMyIMUtpXV6FalrPu8VVD5HdXMnHIUs8qDTtlqF8odGY6D67tkVeXlUuS2c/PhsYzZLmyTdk98jMdpOwp8RyctJSdqoaSIP4DNP0Gd3fe+YGGYyclNY9dGf2+WLLNYhHy6ivRRcXKFKxfutGiIvKRvml9veUK6s2dTQhDjjrLxxR1oBPHqe6UfrPGLBdpjsrPOSDB9c5GsZjEbbp9xr9fpZD7jA7yJd7XN0FTdk0hK9oM3WEwC4vnVJlb5VesxLAPnVdY8p7xdIZSHgJQK8fpoNsG9D8L09lT9gJ9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Matthew, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on jcmvbkbc-xtensa/xtensa-for-next arm64/for-next/core s390/features tj-cgroup/for-next linus/master vbabka-slab/for-next v6.9-rc1 next-20240327] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/sh-Remove-use-of-PG_arch_1-on-individual-pages/20240327-011221 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240326171045.410737-2-willy%40infradead.org patch subject: [PATCH 01/10] sh: Remove use of PG_arch_1 on individual pages config: sh-defconfig (https://download.01.org/0day-ci/archive/20240328/202403280209.6eW34UZ5-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240328/202403280209.6eW34UZ5-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202403280209.6eW34UZ5-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/thread_info.h:27, from include/asm-generic/preempt.h:5, from ./arch/sh/include/generated/asm/preempt.h:1, from include/linux/preempt.h:79, from include/linux/spinlock.h:56, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/mm.h:7, from arch/sh/mm/cache-sh4.c:14: arch/sh/mm/cache-sh4.c: In function 'sh4_flush_cache_page': >> arch/sh/mm/cache-sh4.c:250:51: error: too few arguments to function 'folio_flags' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~~~~ include/linux/bitops.h:50:44: note: in definition of macro 'bitop' 50 | __builtin_constant_p((uintptr_t)(addr) != (uintptr_t)NULL) && \ | ^~~~ arch/sh/mm/cache-sh4.c:250:25: note: in expansion of macro 'test_bit' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~ In file included from include/linux/mmzone.h:23: include/linux/page-flags.h:317:23: note: declared here 317 | static unsigned long *folio_flags(struct folio *folio, unsigned n) | ^~~~~~~~~~~ >> arch/sh/mm/cache-sh4.c:250:51: error: too few arguments to function 'folio_flags' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~~~~ include/linux/bitops.h:51:23: note: in definition of macro 'bitop' 51 | (uintptr_t)(addr) != (uintptr_t)NULL && \ | ^~~~ arch/sh/mm/cache-sh4.c:250:25: note: in expansion of macro 'test_bit' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~ include/linux/page-flags.h:317:23: note: declared here 317 | static unsigned long *folio_flags(struct folio *folio, unsigned n) | ^~~~~~~~~~~ >> arch/sh/mm/cache-sh4.c:250:51: error: too few arguments to function 'folio_flags' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~~~~ include/linux/bitops.h:52:57: note: in definition of macro 'bitop' 52 | __builtin_constant_p(*(const unsigned long *)(addr))) ? \ | ^~~~ arch/sh/mm/cache-sh4.c:250:25: note: in expansion of macro 'test_bit' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~ include/linux/page-flags.h:317:23: note: declared here 317 | static unsigned long *folio_flags(struct folio *folio, unsigned n) | ^~~~~~~~~~~ >> arch/sh/mm/cache-sh4.c:250:51: error: too few arguments to function 'folio_flags' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~~~~ include/linux/bitops.h:53:24: note: in definition of macro 'bitop' 53 | const##op(nr, addr) : op(nr, addr)) | ^~~~ arch/sh/mm/cache-sh4.c:250:25: note: in expansion of macro 'test_bit' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~ include/linux/page-flags.h:317:23: note: declared here 317 | static unsigned long *folio_flags(struct folio *folio, unsigned n) | ^~~~~~~~~~~ >> arch/sh/mm/cache-sh4.c:250:51: error: too few arguments to function 'folio_flags' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~~~~ include/linux/bitops.h:53:39: note: in definition of macro 'bitop' 53 | const##op(nr, addr) : op(nr, addr)) | ^~~~ arch/sh/mm/cache-sh4.c:250:25: note: in expansion of macro 'test_bit' 250 | test_bit(PG_dcache_clean, folio_flags(folio)) && | ^~~~~~~~ include/linux/page-flags.h:317:23: note: declared here 317 | static unsigned long *folio_flags(struct folio *folio, unsigned n) | ^~~~~~~~~~~ arch/sh/mm/cache-sh4.c: In function 'sh4_flush_cache_range': arch/sh/mm/cache-sh4.c:287:30: warning: variable 'end' set but not used [-Wunused-but-set-variable] 287 | unsigned long start, end; | ^~~ arch/sh/mm/cache-sh4.c:287:23: warning: variable 'start' set but not used [-Wunused-but-set-variable] 287 | unsigned long start, end; | ^~~~~ arch/sh/mm/cache-sh4.c: At top level: arch/sh/mm/cache-sh4.c:385:13: warning: no previous prototype for 'sh4_cache_init' [-Wmissing-prototypes] 385 | void __init sh4_cache_init(void) | ^~~~~~~~~~~~~~ vim +/folio_flags +250 arch/sh/mm/cache-sh4.c 207 208 /* 209 * Write back and invalidate I/D-caches for the page. 210 * 211 * ADDR: Virtual Address (U0 address) 212 * PFN: Physical page number 213 */ 214 static void sh4_flush_cache_page(void *args) 215 { 216 struct flusher_data *data = args; 217 struct vm_area_struct *vma; 218 struct page *page; 219 unsigned long address, pfn, phys; 220 int map_coherent = 0; 221 pmd_t *pmd; 222 pte_t *pte; 223 void *vaddr; 224 225 vma = data->vma; 226 address = data->addr1 & PAGE_MASK; 227 pfn = data->addr2; 228 phys = pfn << PAGE_SHIFT; 229 page = pfn_to_page(pfn); 230 231 if (cpu_context(smp_processor_id(), vma->vm_mm) == NO_CONTEXT) 232 return; 233 234 pmd = pmd_off(vma->vm_mm, address); 235 pte = pte_offset_kernel(pmd, address); 236 237 /* If the page isn't present, there is nothing to do here. */ 238 if (!(pte_val(*pte) & _PAGE_PRESENT)) 239 return; 240 241 if ((vma->vm_mm == current->active_mm)) 242 vaddr = NULL; 243 else { 244 struct folio *folio = page_folio(page); 245 /* 246 * Use kmap_coherent or kmap_atomic to do flushes for 247 * another ASID than the current one. 248 */ 249 map_coherent = (current_cpu_data.dcache.n_aliases && > 250 test_bit(PG_dcache_clean, folio_flags(folio)) && 251 page_mapped(page)); 252 if (map_coherent) 253 vaddr = kmap_coherent(page, address); 254 else 255 vaddr = kmap_atomic(page); 256 257 address = (unsigned long)vaddr; 258 } 259 260 flush_cache_one(CACHE_OC_ADDRESS_ARRAY | 261 (address & shm_align_mask), phys); 262 263 if (vma->vm_flags & VM_EXEC) 264 flush_icache_all(); 265 266 if (vaddr) { 267 if (map_coherent) 268 kunmap_coherent(vaddr); 269 else 270 kunmap_atomic(vaddr); 271 } 272 } 273 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki