From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA4DCC54E64 for ; Thu, 28 Mar 2024 15:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA286B0088; Thu, 28 Mar 2024 11:34:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 359C76B0089; Thu, 28 Mar 2024 11:34:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FAD36B008A; Thu, 28 Mar 2024 11:34:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0093B6B0088 for ; Thu, 28 Mar 2024 11:34:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B2B971A0591 for ; Thu, 28 Mar 2024 15:34:20 +0000 (UTC) X-FDA: 81946844280.28.58F8D58 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf08.hostedemail.com (Postfix) with ESMTP id 7678216001B for ; Thu, 28 Mar 2024 15:34:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=O9XAStmD; spf=pass (imf08.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711640058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8iLtZ8tS3iPKIbyiv+jWs2opOkQD6eVtvlMNWnKLzws=; b=nkymhzBAFgrY40pnvvM41P5ITzNGTAmQ/UjTYwln4Lk9G7JjDZPBt4lY6UFKq/MaW22U19 ehaJoSLgBdXOnqx6C1/BeIqLKZBb92cI+HrAlO+ZEUZ9JR5emd+oIIaPGzmqNFPyJybZ1Z K+w//7cdL5xGIFDBuU0dX1obPCY0eNU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711640058; a=rsa-sha256; cv=none; b=A8dk2O1H758qPsKMd1z/HhJ07R4rmrY/eNAFekdqpy7IrvruYq083rOGCY34Hrz+heRn9M ol/kkg2RyWDP8VvFflUVIsGMYNimOZBEqPzLzkze/mBFCdALF/GEGvtBXHBToNeYXAYnt6 TGlSruqYQEvSir8TkIFQ0UVGQ8gfCts= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=O9XAStmD; spf=pass (imf08.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711640057; x=1743176057; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pq4rM/jkC3pLBCbfs311M7bBO4YHyOpwr1F4hhSa1Qg=; b=O9XAStmDQFam5Sd/WwdM4m70F1HUJiOBxuU/+ILvN5uSfZH0GixyB39n BT/p23jOaPtHP0wFPKQSoTWIm0/bCyph1CtxEAWTBNb7Rl1QTc8g1dF3e u7Lxe3yO8MG8tT5HLXbwT0lXAPCzx0BgevarR4kOstFI0Lo3K54SNocYH fHFjS/0lFnULi9X7t2WrO9NGRmDKKmklnjZX6rF+a4jnLSDaKjGTdKEJU 9TyWDC9JjRb6F59hi12UqzcM5gk7xmuU1ajgnloZV8bfRvRGXb+H5fEZV aFwo4QYGMRdEQTA23a/9hQf6lFlhvxv8hT5+RHiCZPSz0EBNHBGqEARj3 g==; X-CSE-ConnectionGUID: QaiUFCwbSrCTHKswfpV0vw== X-CSE-MsgGUID: adnRANBBT+6e6CFMevw7hw== X-IronPort-AV: E=McAfee;i="6600,9927,11027"; a="24249782" X-IronPort-AV: E=Sophos;i="6.07,162,1708416000"; d="scan'208";a="24249782" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2024 08:34:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,162,1708416000"; d="scan'208";a="17080090" Received: from lkp-server01.sh.intel.com (HELO be39aa325d23) ([10.239.97.150]) by orviesa007.jf.intel.com with ESMTP; 28 Mar 2024 08:34:12 -0700 Received: from kbuild by be39aa325d23 with local (Exim 4.96) (envelope-from ) id 1rprlZ-0002Gs-2T; Thu, 28 Mar 2024 15:34:09 +0000 Date: Thu, 28 Mar 2024 23:33:54 +0800 From: kernel test robot To: Kefeng Wang , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , willy@infradead.org, Miaohe Lin , Naoya Horiguchi , David Hildenbrand , Oscar Salvador , Zi Yan , Hugh Dickins , Jonathan Corbet , linux-doc@vger.kernel.org, Baolin Wang , Kefeng Wang Subject: Re: [PATCH 3/6] mm: remove isolate_lru_page() Message-ID: <202403282357.bFSsmYuH-lkp@intel.com> References: <20240327141034.3712697-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327141034.3712697-4-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 7678216001B X-Rspam-User: X-Stat-Signature: mcoe83kwwmb4i6zh3sn61gpdwrwiziz3 X-Rspamd-Server: rspam03 X-HE-Tag: 1711640057-486943 X-HE-Meta: U2FsdGVkX186eMVK0V9WqN4GcJJCvxUvxWLOpE3SqQAnGjw7vRb7Qmv0e1VF7d8mKFXqHEuBW/Fl489ywgMPZWdcIYpqqNQj4cJM/+gf0wclXsLBRjOGXB7PzB8o6pGF1GBpjL4LZf97lzvCXus33oc4seQjVoiGDH9zLmRl1OzkIE235RIGT+lFv3LtehhM6Dv54WgEh5O3cClKGIOJz5MniTHxkYhrorXcsMQNs0dzJ938ROASjG2yk9ZAo/akrZADeXhQ90ye1SzxTOz5utzZ9iwujdPa3ZrqVgxhzaMAfNI9BwHrKiNOWaGpkpYApqHYpRs+BMfP6jVzJiXs0j9L53ppuUMNncn/cjcptYoaoQZvhnxsH8e9W89f4NykJbd//Jeh+oalepBKQUNb7OnZBUjpmHDz0xxG+yDuvFc/UAwDAbmgr+n9+ErPsULuTm8PsUyjID6aQm8wRn8qnZTJDPnloz+y6PY2KmX0NXRjww6eO3TzSw1LusszYzqYmzA4QFx0CNaqFDrlvFXcOjVlgdFFVmgqorGdDBctLXyFvgL26qw1j2fWDxuxblilGRYW3+iWqo/YG5Scb10qZC1LQJQtPUpG8B58GmS6K2KYYOM+npfAbOVhu/TiEwxNKEDRvOueI1kcvIq8MoaBm1yad+XV4FKt+mm9xpSGDJ7YEfl6vzlHy0YwKr8B7tVZvs7xZAuVdHKQeSy4Aweha1C41pdOMyXisTK8SNxfFAJmuGHYXTPBPtO5A/z10SH9KL4evpsXyf6o2Dkn/m3rTDXZAu96VKl13PNl1ncQw9ejv20ukmdsfmrUL8ufZdlSyrv5PYyePCuD2otgFBeEbEExzgl4yR7lP5DGQh/Y7ssHhAvhnVCZ2DZbj81zEvmfNgXaj5c6DU0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kefeng, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.9-rc1] [cannot apply to akpm-mm/mm-everything next-20240328] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-migrate-add-isolate_movable_folio/20240327-221513 base: linus/master patch link: https://lore.kernel.org/r/20240327141034.3712697-4-wangkefeng.wang%40huawei.com patch subject: [PATCH 3/6] mm: remove isolate_lru_page() config: x86_64-randconfig-013-20240328 (https://download.01.org/0day-ci/archive/20240328/202403282357.bFSsmYuH-lkp@intel.com/config) compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240328/202403282357.bFSsmYuH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202403282357.bFSsmYuH-lkp@intel.com/ All errors (new ones prefixed by >>): mm/migrate_device.c: In function 'migrate_device_unmap': >> mm/migrate_device.c:388:9: error: implicit declaration of function 'isolate_lru_page' [-Werror=implicit-function-declaration] 388 | if (!isolate_lru_page(page)) { | ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/isolate_lru_page +388 mm/migrate_device.c 76cbbead253ddc Christoph Hellwig 2022-02-16 355 76cbbead253ddc Christoph Hellwig 2022-02-16 356 /* 44af0b45d58d7b Alistair Popple 2022-11-11 357 * Unmaps pages for migration. Returns number of source pfns marked as 44af0b45d58d7b Alistair Popple 2022-11-11 358 * migrating. 76cbbead253ddc Christoph Hellwig 2022-02-16 359 */ 241f6885965683 Alistair Popple 2022-09-28 360 static unsigned long migrate_device_unmap(unsigned long *src_pfns, 241f6885965683 Alistair Popple 2022-09-28 361 unsigned long npages, 241f6885965683 Alistair Popple 2022-09-28 362 struct page *fault_page) 76cbbead253ddc Christoph Hellwig 2022-02-16 363 { 76cbbead253ddc Christoph Hellwig 2022-02-16 364 unsigned long i, restore = 0; 76cbbead253ddc Christoph Hellwig 2022-02-16 365 bool allow_drain = true; 241f6885965683 Alistair Popple 2022-09-28 366 unsigned long unmapped = 0; 76cbbead253ddc Christoph Hellwig 2022-02-16 367 76cbbead253ddc Christoph Hellwig 2022-02-16 368 lru_add_drain(); 76cbbead253ddc Christoph Hellwig 2022-02-16 369 76cbbead253ddc Christoph Hellwig 2022-02-16 370 for (i = 0; i < npages; i++) { 241f6885965683 Alistair Popple 2022-09-28 371 struct page *page = migrate_pfn_to_page(src_pfns[i]); 4b8554c527f3cf Matthew Wilcox (Oracle 2022-01-28 372) struct folio *folio; 76cbbead253ddc Christoph Hellwig 2022-02-16 373 44af0b45d58d7b Alistair Popple 2022-11-11 374 if (!page) { 44af0b45d58d7b Alistair Popple 2022-11-11 375 if (src_pfns[i] & MIGRATE_PFN_MIGRATE) 44af0b45d58d7b Alistair Popple 2022-11-11 376 unmapped++; 76cbbead253ddc Christoph Hellwig 2022-02-16 377 continue; 44af0b45d58d7b Alistair Popple 2022-11-11 378 } 76cbbead253ddc Christoph Hellwig 2022-02-16 379 76cbbead253ddc Christoph Hellwig 2022-02-16 380 /* ZONE_DEVICE pages are not on LRU */ 76cbbead253ddc Christoph Hellwig 2022-02-16 381 if (!is_zone_device_page(page)) { 76cbbead253ddc Christoph Hellwig 2022-02-16 382 if (!PageLRU(page) && allow_drain) { 1fec6890bf2247 Matthew Wilcox (Oracle 2023-06-21 383) /* Drain CPU's lru cache */ 76cbbead253ddc Christoph Hellwig 2022-02-16 384 lru_add_drain_all(); 76cbbead253ddc Christoph Hellwig 2022-02-16 385 allow_drain = false; 76cbbead253ddc Christoph Hellwig 2022-02-16 386 } 76cbbead253ddc Christoph Hellwig 2022-02-16 387 f7f9c00dfafffd Baolin Wang 2023-02-15 @388 if (!isolate_lru_page(page)) { 241f6885965683 Alistair Popple 2022-09-28 389 src_pfns[i] &= ~MIGRATE_PFN_MIGRATE; 76cbbead253ddc Christoph Hellwig 2022-02-16 390 restore++; 76cbbead253ddc Christoph Hellwig 2022-02-16 391 continue; 76cbbead253ddc Christoph Hellwig 2022-02-16 392 } 76cbbead253ddc Christoph Hellwig 2022-02-16 393 76cbbead253ddc Christoph Hellwig 2022-02-16 394 /* Drop the reference we took in collect */ 76cbbead253ddc Christoph Hellwig 2022-02-16 395 put_page(page); 76cbbead253ddc Christoph Hellwig 2022-02-16 396 } 76cbbead253ddc Christoph Hellwig 2022-02-16 397 4b8554c527f3cf Matthew Wilcox (Oracle 2022-01-28 398) folio = page_folio(page); 4b8554c527f3cf Matthew Wilcox (Oracle 2022-01-28 399) if (folio_mapped(folio)) 4b8554c527f3cf Matthew Wilcox (Oracle 2022-01-28 400) try_to_migrate(folio, 0); 76cbbead253ddc Christoph Hellwig 2022-02-16 401 16ce101db85db6 Alistair Popple 2022-09-28 402 if (page_mapped(page) || 241f6885965683 Alistair Popple 2022-09-28 403 !migrate_vma_check_page(page, fault_page)) { 76cbbead253ddc Christoph Hellwig 2022-02-16 404 if (!is_zone_device_page(page)) { 76cbbead253ddc Christoph Hellwig 2022-02-16 405 get_page(page); 76cbbead253ddc Christoph Hellwig 2022-02-16 406 putback_lru_page(page); 76cbbead253ddc Christoph Hellwig 2022-02-16 407 } 76cbbead253ddc Christoph Hellwig 2022-02-16 408 241f6885965683 Alistair Popple 2022-09-28 409 src_pfns[i] &= ~MIGRATE_PFN_MIGRATE; 76cbbead253ddc Christoph Hellwig 2022-02-16 410 restore++; 76cbbead253ddc Christoph Hellwig 2022-02-16 411 continue; 76cbbead253ddc Christoph Hellwig 2022-02-16 412 } 241f6885965683 Alistair Popple 2022-09-28 413 241f6885965683 Alistair Popple 2022-09-28 414 unmapped++; 76cbbead253ddc Christoph Hellwig 2022-02-16 415 } 76cbbead253ddc Christoph Hellwig 2022-02-16 416 76cbbead253ddc Christoph Hellwig 2022-02-16 417 for (i = 0; i < npages && restore; i++) { 241f6885965683 Alistair Popple 2022-09-28 418 struct page *page = migrate_pfn_to_page(src_pfns[i]); 4eecb8b9163df8 Matthew Wilcox (Oracle 2022-01-28 419) struct folio *folio; 76cbbead253ddc Christoph Hellwig 2022-02-16 420 241f6885965683 Alistair Popple 2022-09-28 421 if (!page || (src_pfns[i] & MIGRATE_PFN_MIGRATE)) 76cbbead253ddc Christoph Hellwig 2022-02-16 422 continue; 76cbbead253ddc Christoph Hellwig 2022-02-16 423 4eecb8b9163df8 Matthew Wilcox (Oracle 2022-01-28 424) folio = page_folio(page); 4eecb8b9163df8 Matthew Wilcox (Oracle 2022-01-28 425) remove_migration_ptes(folio, folio, false); 76cbbead253ddc Christoph Hellwig 2022-02-16 426 241f6885965683 Alistair Popple 2022-09-28 427 src_pfns[i] = 0; 4eecb8b9163df8 Matthew Wilcox (Oracle 2022-01-28 428) folio_unlock(folio); 4eecb8b9163df8 Matthew Wilcox (Oracle 2022-01-28 429) folio_put(folio); 76cbbead253ddc Christoph Hellwig 2022-02-16 430 restore--; 76cbbead253ddc Christoph Hellwig 2022-02-16 431 } 241f6885965683 Alistair Popple 2022-09-28 432 241f6885965683 Alistair Popple 2022-09-28 433 return unmapped; 241f6885965683 Alistair Popple 2022-09-28 434 } 241f6885965683 Alistair Popple 2022-09-28 435 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki