From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0759CD1292 for ; Mon, 1 Apr 2024 13:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 104146B0082; Mon, 1 Apr 2024 09:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B4496B0083; Mon, 1 Apr 2024 09:54:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBD856B0085; Mon, 1 Apr 2024 09:54:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CD8CB6B0082 for ; Mon, 1 Apr 2024 09:54:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 886A1C075B for ; Mon, 1 Apr 2024 13:54:06 +0000 (UTC) X-FDA: 81961106892.04.8A53E0C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 1E0DF1C0018 for ; Mon, 1 Apr 2024 13:54:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c29yWJov; spf=pass (imf21.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711979644; a=rsa-sha256; cv=none; b=3dl9ILJJohVtQxUEK/z55Dke9pka28QotI5b2tTBtriQCi9DUD2hLvgQL9CqiMqrXSOFxT Qnyzd+2gAIjUxyRp8yaH56aVMZLyp4XP+OCQzJSnBTVCrUnmDbniqhemaah3k9yDOV67xF MFoYD1A6TbqzimPgTwSTFEjp/ngCOMg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c29yWJov; spf=pass (imf21.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711979644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PQcgfqR9aaDDBoX6f+wEYhOW6i8WnSdrTCGTG536jbM=; b=prrBZNYLiHifZLeqOKUVxDW2X2H9XYcgMKArlNovB03Cw3rOsJa53co8sS66eXXihdNzNr 9gF8AgCxvGnP4SNFMuMv+gT7YU1ASoTMOb7nwNyfkj+a7xRWxQBlGRzkxzV3X6Ftp5+UOo i0DcxtPCNA4NO9v8kzogUZoUHbLmF5Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7EE14CE10C2; Mon, 1 Apr 2024 13:53:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADA0CC433C7; Mon, 1 Apr 2024 13:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711979638; bh=dmYCendNfZLK2ZYRN4P3XHXSgHmLS9K4qfGr3Ifd3v0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c29yWJov1MPD3KNJnAc3J10X31RIJx5rJ8pZ9aMASTtRIDHTlXt3YBkMhR/2MmTeW zKg7sKvzusvvzXvEpqIv8nO9JilxGOlGDD9rpErvCQJiT/+cOIdnykZR54Pb5hp73A n3db2XvRlrrFuw27hXNlQVFklZF/bwBt1Tvksi8eyn/LaeBo2QoMfURHysv0Ra+tcm 5GNCZFCSDd/aMOWF7fV3ver/b2jE5QU8+WhPmhCzIjV1dmrOHawVXzxIdY9jTI6kkp 3RzhX7bCaKGHmMTJC3G9ZTma+EDhOVW6r/AdWBj3gvJJLSd3U3a0S7GGRMCCfrXnpN BcEw/0JlvpOew== Date: Mon, 1 Apr 2024 14:53:51 +0100 From: Simon Horman To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/26] netfs, afs: Use writeback retry to deal with alternate keys Message-ID: <20240401135351.GD26556@kernel.org> References: <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-27-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240328163424.2781320-27-dhowells@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1E0DF1C0018 X-Stat-Signature: z841ach1zpg546n5yttbjozsgqm5uw1a X-Rspam-User: X-HE-Tag: 1711979642-324217 X-HE-Meta: U2FsdGVkX1+GeNvWbW/gBtkBdTkaXILLn0b6cv8u86wMCAAH2Tf1iMz/wEd2FOcxYZPI7ledY+IVGyfPiKpyMGRvkTZRZsvOnFoMb/YDqGe0CIGeGvljtV9v5UTTbWuae3P1EFpsy38cMzV8d3o8RoaQa3Ao5FMzLAwR0KroSc+3tRxK0LRM1G+oluy3xQ+e/veQckEiSWqE3DL5R7kYsa9eWAiO7ZL4CkwX9WVSz2ZCP6+6WNvb1R8v04Uk13zKCcKM6Mz0LKTJ8tkunoG9ZhakKmLEpfB0RSsWtMCjVrEkMM2Bo5Gkd0unysy5wAEc3IdAvSem0ntoXxVd+Cdtzweu3AkW4kx6bgbbyrfd6O0jcjqaouNZByWfb6wc02Hl+9mR1QOW1dDRAjy6BPMI2WWrv0Jq/YwJ8HCTH6PZfa2oDMtelh+izL69TlJU/dtN1oncJVFq8MQTM4XSl+XmvnQ4OMAhyunXmg3csWjwK8G/AuJh504gfhBNO5UvGCP7tQdhERbhHwn2PHfHrHpyypygIbJ97sLSK8zJpaCH/DmtWSKdEOghTeWbr6HF9T3xs1n//PJ+MvQssO9P0SIZ0nng/91yZnDwlorM02LTHbkN2dKc0WCnuPepwZE8GbL8tni71ZOGQ9hDk2ZTy8LzRXp9J1tpagUbzrMQiN4d0fZQMrusKz3ZdgspKyZQ8GuNBC3yb30JNo4XphYFKLdMS3o9KeuLEexD2dSZ6ROJckJDPbDveIczwGE40V4zjNCIgKWScCIxyhfjeKwBRlXKm19ttmnIV8fattbQPVAHYA3f94RxbbxdoCwkx7NirmUPvZ/aXFesLNBO4q/OlJNCUzwt5iZWFC7iJzrnJochSlcSjzfXFXQ7oZxGYaLYuvmlHDj+MpN+y20= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 28, 2024 at 04:34:18PM +0000, David Howells wrote: ... > +void afs_issue_write(struct netfs_io_subrequest *subreq) > { > + struct netfs_io_request *wreq = subreq->rreq; > struct afs_operation *op; > - struct afs_wb_key *wbk = NULL; > - loff_t size = iov_iter_count(iter); > + struct afs_vnode *vnode = AFS_FS_I(wreq->inode); > + unsigned long long pos = subreq->start + subreq->transferred; > + size_t len = subreq->len - subreq->transferred; > int ret = -ENOKEY; > > - _enter("%s{%llx:%llu.%u},%llx,%llx", > + _enter("R=%x[%x],%s{%llx:%llu.%u},%llx,%zx", > + wreq->debug_id, subreq->debug_index, > vnode->volume->name, > vnode->fid.vid, > vnode->fid.vnode, > vnode->fid.unique, > - size, pos); > + pos, len); > > - ret = afs_get_writeback_key(vnode, &wbk); > - if (ret) { > - _leave(" = %d [no keys]", ret); > - return ret; > - } > +#if 0 // Error injection > + if (subreq->debug_index == 3) > + return netfs_write_subrequest_terminated(subreq, -ENOANO, false); > > - op = afs_alloc_operation(wbk->key, vnode->volume); > - if (IS_ERR(op)) { > - afs_put_wb_key(wbk); > - return -ENOMEM; > + if (!test_bit(NETFS_SREQ_RETRYING, &subreq->flags)) { > + set_bit(NETFS_SREQ_NEED_RETRY, &subreq->flags); > + return netfs_write_subrequest_terminated(subreq, -EAGAIN, false); > } > +#endif > + > + op = afs_alloc_operation(wreq->netfs_priv, vnode->volume); > + if (IS_ERR(op)) > + return netfs_write_subrequest_terminated(subreq, -EAGAIN, false); > > afs_op_set_vnode(op, 0, vnode); > - op->file[0].dv_delta = 1; > + op->file[0].dv_delta = 1; > op->file[0].modification = true; > - op->store.pos = pos; > - op->store.size = size; > - op->flags |= AFS_OPERATION_UNINTR; > - op->ops = &afs_store_data_operation; > + op->store.pos = pos; > + op->store.size = len, nit: this is probably more intuitively written using len; > + op->flags |= AFS_OPERATION_UNINTR; > + op->ops = &afs_store_data_operation; > > -try_next_key: > afs_begin_vnode_operation(op); > > - op->store.write_iter = iter; > - op->store.i_size = max(pos + size, vnode->netfs.remote_i_size); > - op->mtime = inode_get_mtime(&vnode->netfs.inode); > + op->store.write_iter = &subreq->io_iter; > + op->store.i_size = umax(pos + len, vnode->netfs.remote_i_size); > + op->mtime = inode_get_mtime(&vnode->netfs.inode); > > afs_wait_for_operation(op); > - > - switch (afs_op_error(op)) { > + ret = afs_put_operation(op); > + switch (ret) { > case -EACCES: > case -EPERM: > case -ENOKEY: > case -EKEYEXPIRED: > case -EKEYREJECTED: > case -EKEYREVOKED: > - _debug("next"); > - > - ret = afs_get_writeback_key(vnode, &wbk); > - if (ret == 0) { > - key_put(op->key); > - op->key = key_get(wbk->key); > - goto try_next_key; > - } > + /* If there are more keys we can try, use the retry algorithm > + * to rotate the keys. > + */ > + if (wreq->netfs_priv2) > + set_bit(NETFS_SREQ_NEED_RETRY, &subreq->flags); > break; > } > > - afs_put_wb_key(wbk); > - _leave(" = %d", afs_op_error(op)); > - return afs_put_operation(op); > + netfs_write_subrequest_terminated(subreq, ret < 0 ? ret : subreq->len, false); > } > > /* ...