From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2966ACD128A for ; Wed, 3 Apr 2024 12:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91B726B0089; Wed, 3 Apr 2024 08:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CB4A6B008C; Wed, 3 Apr 2024 08:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BA326B0093; Wed, 3 Apr 2024 08:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E8AD6B0089 for ; Wed, 3 Apr 2024 08:41:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AC743160673 for ; Wed, 3 Apr 2024 12:41:32 +0000 (UTC) X-FDA: 81968181624.17.DD3B762 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id B81CE40013 for ; Wed, 3 Apr 2024 12:41:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712148091; a=rsa-sha256; cv=none; b=bCJum0Oha2fP5y8EXZQmzlMG3YbML1I3xi0FBl1/jxQsdZYZLFLMvK9PCrQFFOmIgUpP1N IwVu5WPc0lhwWN2RzTubhmezJP4O7F32rbhAPdNXbHRHThY8DfYiTcnfC3zKoN7NEgRCSW ZUIiXsu9goOVSw8M20hho8wh7hj8fZ0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712148091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TOVFdyxA+CDmimcse2hV9Dl22NTQnHkKmgUFvRj6l+U=; b=69d3WmOs4Rn6O7MWoFtoCvC73GxIx519V/I0O+qDAcM0vq3DQQ8CJAySXBKk+xkPcGNIXv raRSkcDtmSIAcZI0SbfXxpVqi8WzbVOkf9P0lkONBWCCZh9j0iFPFKp8cFKLBBagekkzA/ Bn0sSkvCkobsQ5WLHg47r/5iflBNWPY= Received: by verein.lst.de (Postfix, from userid 2407) id 2B14568BFE; Wed, 3 Apr 2024 14:41:25 +0200 (CEST) Date: Wed, 3 Apr 2024 14:41:24 +0200 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Message-ID: <20240403124124.GA19085@lst.de> References: <20240403101422.GA7285@lst.de> <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> <3300438.1712141700@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3300438.1712141700@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B81CE40013 X-Stat-Signature: 5mdzkwh4k6zga697jom7orc965whfxtq X-Rspam-User: X-HE-Tag: 1712148090-596293 X-HE-Meta: U2FsdGVkX18RanERrP5ng0liy1jKOQfnNC9X9iWQFRSnGVyl8gID9Q0UgjcdEG7R3M9alRby8wUKVqdNwq7h8oUBdbMABgT+Rz6hRAAXF4kPad2uhr0weW7JyKHRriR8O7e77C8cis0zdfEOZjLaJI8guzBnhkJ/AbgTWcgrqxCKGBRqheVmKcjymHKdWNURwKltObstfVfm7X2NCqrtOsMhf03dB8KAL7j1waqkO90zFccYbAYmrZAHf5Cmq4FaZvotqNjS849iKCIJT6p6zfW08puT1cZeZ7UyaEUM/X4YvsIyi2eR1q93OwzDBUv5mer1BDy6FTY3zRhn+HAdoK1PqmmzmsH6sp6fCzGlbscRa/yU8+wK2yB0RlpBScprYu2yGAjs3sbiXotMbxmKhW8XGMsU5BHBKUfITjThfhMzZmwiarwyTaNSAnB54Jrt+qK/iTSuGmS0kiyxyVBNU3pd21Y9ztKlJEx25uoY6mP7pb4NlsuDGGNozzESQR+tYILJhzSKIndjaMqaKw69ayTkSyRNv3LQnWQASglvckpZ69URwBEN3JQmncDCc9eK2iVEaKO/LSFz4b8VOtJVeVWnZBT52xu94oqh7dSs4SixUIbEJ8HwgZt/PtAUKkAXKsXSD5y0VzDRXBq7DgWM5Vq4xdKSJwkUvvLjCmyoP4uRhpyc22UPqpHMyRsSE95Sr0H9mfQ/Y1rF0CO6kq5zaY/aSud6CoJuY/kcY2ZLum/uXRmh0/j3rNIf2kIR1Ixp6XJV4H3KQhxj25g7YulR/63VfZMiHvrWrMH+JTRP+LCJPICKNwU9LcBsjA3q5MTL1aXq4CG/NUoAIhz2Fa8JQqTx/MMpUzjfW/9thz3rz/dDWLjJoCxdUiOwu7OuUJLEnWbwSLr3XvPnN7b5Z2zCcjXHWs1+TTWvmKsrTv1b69tly63cdF1SpkgjQ/licGB8TOZJDr6MCjiQT4gbKWq xIAfPHaj dwErzdIAvGudo/8YVEussQr8wM/CsSRHP3y/mrxhA0iN/IIPO8teTNgnvihf0hJfVc4b3FIpa+oOnOSQeb04PszDqIPFVelTPMDx7OyDQkjV0bD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 11:55:00AM +0100, David Howells wrote: > So why are we bothering with EXPORT_SYMBOL at all? Why don't you just send a > patch replace all of them with EXPORT_SYMBOL_GPL()? No my business. But if you want to side track this let me just put this in here: NAK to the non-GPL EXPORT of writeback_iter().