From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B2B4CD11C2 for ; Wed, 10 Apr 2024 17:38:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A84F26B0082; Wed, 10 Apr 2024 13:38:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A35126B0083; Wed, 10 Apr 2024 13:38:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D60F6B0085; Wed, 10 Apr 2024 13:38:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C3B36B0082 for ; Wed, 10 Apr 2024 13:38:30 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFD9612087A for ; Wed, 10 Apr 2024 17:38:29 +0000 (UTC) X-FDA: 81994331538.23.C80158B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id D015240010 for ; Wed, 10 Apr 2024 17:38:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gQ6nQCFO; spf=pass (imf17.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712770708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PR4pJ7/A2t4CGgUS/RB65zpaQBGkBlxGC8RAdRPHz1w=; b=UIsve/ng9pWyURxO6nkRw0BWSToQB/gtZeT+GuymFlF7tx/vhsnwG0KigQ7wwiXMjwkS5J DGx4Qy/HxehgdaaN2QaeDDJJaRa3RZZv+a7K+Nuhsaa17roOKN8jeZHT6DVtqpRT/+wNaj 8hbIc3Ew9CWp52iHULprlc1yZusFfwU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712770708; a=rsa-sha256; cv=none; b=R9uVuwXd5wSObf0CFnVhod9CpCeu5KM8gcoo5I8SY7GwNKxnyEuoIFT6K9NMenEntSrbuc EHMfTkvgubQtsN2HwvjzdsYAoW/QkqMYs9zzwELRDbhPS40XVS+N9uxAjs8RrHUCLiUyhI zwqOgMw0xaBO/k1xran60rMPZKT5h3Q= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gQ6nQCFO; spf=pass (imf17.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DB927CE2B00; Wed, 10 Apr 2024 17:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 935F7C433C7; Wed, 10 Apr 2024 17:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712770702; bh=8bk8QbWwBjxogV8sulrsLmw3J8c/0qzWYceZvwMmUOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gQ6nQCFOxjCTOgr5FktkEvhBwT+60FB9SznvO+NovCDxX/VDbZy9GldL1pityvO9m RzvIh1Yb9KHL+608nk7G0c8nyN1iHLVZTbiHooVXwZyBBl+UVILDZfCaTMA7y7WuGJ hYRVDbFDPZSh+h3NBoz5DqRO5zF6wap442xwxF/OeoX9BRgHi+LEnorn28rcGC3xL5 SEd2FWO0t3xP65ddc+HvYOG+4apVIy0CsGeoyHyd7KXMBPFy9e3zoe7Gue7qZxTwOn oFxukrXWAYyHVkIdv86hSbPooOQQs+Swdk8bG+PThkIevqoOd7KST9sX9vZAS3Df02 Dm3soaO/TIdaw== Date: Wed, 10 Apr 2024 18:38:15 +0100 From: Simon Horman To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/26] netfs, afs: Use writeback retry to deal with alternate keys Message-ID: <20240410173815.GA514426@kernel.org> References: <20240401135351.GD26556@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-27-dhowells@redhat.com> <3002686.1712046757@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3002686.1712046757@warthog.procyon.org.uk> X-Rspamd-Queue-Id: D015240010 X-Rspam-User: X-Stat-Signature: ddpp3qjks3xgj4747fp1yojcim99dk84 X-Rspamd-Server: rspam03 X-HE-Tag: 1712770707-770723 X-HE-Meta: U2FsdGVkX181nI4U3z7fbcelzcOWSRvhfObWsSe7uE6dGmaCs28dvS76pHh5oss6fWaZAvhZisHvYAsV9RACowM+P1jv1owCDh5+E4s8vf12L8ccEg51yokrvXUlDomHYHzKiwIYRVKJR9oM3zeTK1u8PQSy5RJfPbDHQJiCEY5s2EtSX9vhaFIC2PkwycqLfg/35Q9LzD4cPSjJC12o0Q41Btpfll5RWsdB6c531iguZYT5aW0lP2T/7KYkU66q6FKz5VdRxdsBKdoyv/LloR08oHxzsiex6ro761F3WFBj+0T13icf8zDIfLn81wdYpaMlyCr7qzv7wwAw2LgAIuillZmNOEc2556qpfYTKvebwQwauEefOFFiCP0WqPzBXWcM8Wva+gFV1xAedLSJHPjo++qObmFiT3+1Dji2a7bfC+YzIRIJjHW/+uZ5nZQbJTNV3V/UEjwikb0FmCVtPd51F/djitRqgPU3IlJfnbm6HMxZinfITD0tb8QDUxCCjsEEw7s172jF+w0rWXjOhARtk75EshaIH7cGDf++xCrLVBe7TJOFqEwxCRSiHoQrRP0iAZvlunKQUmEM2K/hVi+ssbhaKUer+hM3b1+WzvmG1g495o9xCCs6CBb9Issaa69c5mJFr7IkhbN4ZCl76k1hRipzZ9owDZzfK1D1Xa4r33JrECVd/gs1phf3bUDk1ExYOkE5yMmp0jHNv5ID4zDSxRBl93nqkUvY89pNNjORViGtDITLFE7+LuTAZcbRSr/Mfvi5+7pRb71FUSyn/Z1sr04iyeD7Rbnsax0P4AcbLYWM2i5vyJXPhvSWWv6wRyIL81azFx9CxeOQ9lUpO/QedrUVUYP/1rmv8sdpiP6byCOW56ew6M6/utKxZ6u2jdaAyOI2Lh/Q9+4UyBrjR96+NouaW/RkFPRLJdtlFVnRjgIWodvDPmqk1GOJRiQC4c/mr09c7kcbrYj0PRD QrnCkAud GlsCn9gxp+lbRGuyPJaa7SHu/WatYd8Yszd4fVf0xkK8aopMQzxY5JIkPFFr6ux9Mg9mdsyIdV+SQgkF9m8nQ3akRogUObbviYWiHNrH4NtK0Cyq0vFg10M+coFP6LDIlc7VRvFy7mCAIt8KmikKw7/wuNS2UVeADGx3JhQi5lPlhWRzBNrtRvLmL6sYR/JNHEio5VQpnsChpYJS0gKQ9Yu9y4LT9x8GNkKmcC9Iqx15gg5LIAiWl1JXSW/q0jst+N8K08hDMeksBBY/5vZvzPJTisA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 02, 2024 at 09:32:37AM +0100, David Howells wrote: > Simon Horman wrote: > > > > + op->store.size = len, > > > > nit: this is probably more intuitively written using len; > > I'm not sure it makes a difference, but switching 'size' to 'len' in kafs is a > separate thing that doesn't need to be part of this patchset. Sorry, I meant, using ';' rather than ',' at the end of the line.