From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F21DCD11C2 for ; Thu, 11 Apr 2024 00:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CECDA6B0087; Wed, 10 Apr 2024 20:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9D1F6B0088; Wed, 10 Apr 2024 20:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B646F6B0089; Wed, 10 Apr 2024 20:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 994D06B0087 for ; Wed, 10 Apr 2024 20:41:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2D4631409C0 for ; Thu, 11 Apr 2024 00:41:08 +0000 (UTC) X-FDA: 81995396616.29.97D3299 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 548DB180003 for ; Thu, 11 Apr 2024 00:41:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Uv4nmm70; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.166.175 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712796066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wKgaWymCA7byQ3pP1Edxiucbtgpjbgswg4BKCEuveSs=; b=PIfLPvPzlyd/7mZgYtFxkXorj+FnuCQ4mcS+FeBO1YyfAXkq3HG6mfru5v3wHSa9xMr1bW rSUd88g2Ku3fXH1UucSpzm5GcGcfeVIQZ0u1GdqqINGx9cU8z8u6nMO2nHADn7A1uxIBhI 3Gytw8Fu98dGFvzOBGDcywzSLsSYfAk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Uv4nmm70; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.166.175 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712796066; a=rsa-sha256; cv=none; b=ZmHyi18vobFC6ksQvH6ZsQRPi6Gw7qVMtXj9qgQBvuQUf42epUh2qgCTS+FW7axCVITuDL ThecGVrJp+JFE7H+tHKnqIQJxUHX4Uvhy6I/vSfBrWh9p20QWIGKO2t2eXBAzq+aLHiyHH fJTYR4dN2jxjDvRYO4ob8qNhTvrHFvg= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-36afd880d68so271805ab.0 for ; Wed, 10 Apr 2024 17:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712796065; x=1713400865; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wKgaWymCA7byQ3pP1Edxiucbtgpjbgswg4BKCEuveSs=; b=Uv4nmm70vUCRGG4wLc1AmBoyDq2gDV/zmikOPLPD30diMlEfbX6Y1RrAs9JlMbcchB p9X8CJzOi9mAyPJNirLd2w7D3S22O6QqVRGrk9DE/jStOd7p/gUoH07svjpjOjTw82l3 VpAYrlWfej+WA12hr4MC4GTUObA3pTVCfxCFs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712796065; x=1713400865; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wKgaWymCA7byQ3pP1Edxiucbtgpjbgswg4BKCEuveSs=; b=ed3sdXwOgaoV7Ry3dUHQje7IxLQRDow8gGkWKNNP6Rui+Ggj3V/GS7COMgg/FAo4jm eh7kFcQAcUw42/3Atr5zblTQF0yXQ2HqIimX1FuRx1fpFAdECjyaaSooR/vWOzGWIdex IIecyzArEM7S0/yru1pLEbbU+V6irUx+ZO/EZGp82wHV4EbON4+vGrgm9JSxvR5ch5nc bxQxzgX6cTmbvaft+OtByoW7UYWto/E6rd+q3TlbWfOF2C+rOXrYWCaZGoEiKq0Rzgaf o0W8KV9csp6tD3lKnaq4BemosfBV5xaL16z/1t4aWwnskeUB8N7YIixAIh4Ucqtum5u3 5ZMg== X-Forwarded-Encrypted: i=1; AJvYcCW4/OxUhi9Aa3wBqOPeUCK6MQQaajUZJeJADUOzvK3Cd0Bm6XVbeOEuhlNqAx+9zzx6Wb7lecwnDJAshfgJ0pOEmj4= X-Gm-Message-State: AOJu0YyZU+oOmGsB+Yil9ghUXiUYQ/1wKZGSoY/T3Pn0jhuDWA2xnsWO PNo+e5NdL7YFdTeVtasoqPY1updt5t0LPFuyyhguy+qE/PEQFyITgla9bb7Q9g== X-Google-Smtp-Source: AGHT+IGDAD7dL3LOOrzNCVQ59wj2g9+ChqDyJdjnBAxIhixl0Jwg4vsZhQeHbrM4t+hXEKkQFpikHw== X-Received: by 2002:a05:6e02:1cac:b0:36a:1f88:d73a with SMTP id x12-20020a056e021cac00b0036a1f88d73amr5390406ill.15.1712796065348; Wed, 10 Apr 2024 17:41:05 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:f30d:f29e:acb:4140]) by smtp.gmail.com with ESMTPSA id o21-20020a639215000000b005e838955bc4sm149920pgd.58.2024.04.10.17.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 17:41:04 -0700 (PDT) Date: Thu, 11 Apr 2024 09:40:57 +0900 From: Sergey Senozhatsky To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, minchan@kernel.org, senozhatsky@chromium.org, linux-block@vger.kernel.org, axboe@kernel.dk, linux-mm@kvack.org, terrelln@fb.com, chrisl@kernel.org, david@redhat.com, kasong@tencent.com, yuzhao@google.com, yosryahmed@google.com, nphamcs@gmail.com, willy@infradead.org, hannes@cmpxchg.org, ying.huang@intel.com, surenb@google.com, wajdi.k.feghali@intel.com, kanchana.p.sridhar@intel.com, corbet@lwn.net, zhouchengming@bytedance.com, Tangquan Zheng , Barry Song Subject: Re: [PATCH RFC 2/2] zram: support compression at the granularity of multi-pages Message-ID: <20240411004057.GA8743@google.com> References: <20240327214816.31191-1-21cnbao@gmail.com> <20240327214816.31191-3-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327214816.31191-3-21cnbao@gmail.com> X-Rspam-User: X-Stat-Signature: di1igipiorfmfkqzueuqan7cp31d8ai5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 548DB180003 X-HE-Tag: 1712796066-75898 X-HE-Meta: U2FsdGVkX19ErObICDKGamrIs509veQw7qZm4N516MY53ZaqyDdegNN/H/7O2a09a1DOnsAXt1Cuk6aLmcYdjzvT9blXI/5CxJXeMaT7As5rh4+AdSrxeq/eThPGjZQ/a7tGbWZJ4nd0fHhPDAEu3jdCbDyAIt2100IzeOwfj8q/4lzoOAxpis+9erLsTxMannn3CmIZWKsO4lYLttdDE/kVBQDAdxIhkbRB3equeIi6rt8YbfC+1CSv0y3kQ1mZ8rXbLYY29QxPzH8B8fjTM8U8EkPDk9TU5rYJ4z4eMBOON0avLllV25rns0Kd6OIaRDwaH/UMtC590I6N1egSKCS1/xMSkdYWQvzC1pTlTg6OlOX7LjBLW1iups85RXEdcdkX4m2USIYhf2iOqeGcl8UJJNx/g5G+j/LvHEaylZUC/NOjQ9L5hkzF0J0hcQ3WCml6MCPdd/ANdK9j3JRFSpVWlJVuOVfYcNx13GmmAt62s4v0w7O41XZQOZgtlayXBqqcjM4WSLbe/bkb3IQkPfT8qMjPmkXoXM1H0Uz+SQUHz/KuB++fAvIQ0izGm2xJzqy17rbdIj7SfCecwnBE0S8l7Vk+N25cMP6YfSs7mqHY7irx3jvKFCv2ebRuzicUxrRJOLmzqF+thTx2aATjNAsHAhCIU/1DDutAOmVEqcEO4VgE/rYjT+m5WSEHTI3x0Bs0828riyyqsdqnlS9T75KwESqrovP2wLDV9XQ8gGza4ARNZkt02Eevd1ZC5iPmpmhg9GFn+VC2Nn/bh/INmluiIOUUAoS/ZuihI2mRWiqw7Tp7V+U/dGh+0JxTJED/+NC2AjpHGJKhhb2Ulxnc3wA0z4ncrnbXz2zJD8625eSDMgs49Qnkz+zt5864QYIVGF5PRZ/LDyLpuvjZEyzZJcMGjLuf04MW0f/2U5gGHCFxSh04k6TpG4Ad3HZU6l8OQl9sCW8xW4yjWdrQyoP FGLsx04/ 2S6ZGOvxhknTvwleInkUzPTJG8+zyJsLwHQC4fGuqK5Q9wowky5m4n5x1Hp8hFc44UZHSG/w933dY4pnCNEmhEOucgwB4zp0niYCI8nmXOKrqIsBsFB7PlKIYBdhiBocyMhhZLMhp/YaRJH1bvZBRK+RE0E4PMC2RA7y90L2E5UmI9rKcZHdWaYz2GuPzAFMzH/U5LDdMeIOJ1XcOnrO/J5ZVLyl0xhOSf6sVXoLsLQWMH/Ae3JjYus3LDgS7ngQRF5lWzIbmyjchc7XyRlrdHHJyhNuu79T5xvOwa4+Gqlfxi7jokOxj7TuBlaH1rJ54EqYU4Xybzseqq6Sk5JY1t9KlwWlZhHTLln6iASEhdEwlpMGC9XtQ9ap2rDZoLZsv+mEpMtIoGpiVH5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/03/28 10:48), Barry Song wrote: [..] > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h > index 37bf29f34d26..8481271b3ceb 100644 > --- a/drivers/block/zram/zram_drv.h > +++ b/drivers/block/zram/zram_drv.h > @@ -38,7 +38,14 @@ > * > * We use BUILD_BUG_ON() to make sure that zram pageflags don't overflow. > */ > + > +#ifdef CONFIG_ZRAM_MULTI_PAGES > +#define ZRAM_FLAG_SHIFT (CONT_PTE_SHIFT + 1) So this is ARM-only?