Re: [PATCH v5 0/10] transfer page to folio in KSM

David Hildenbrand
2024-04-11T07:55:37Z

On 11.04.24 08:17, alexs@kernel.org wrote:
> From: "Alex Shi (tencent)" <alexs@kernel.org>
>
> This is the first part of page to folio transfer on KSM. Since only
> single page could be stored in KSM, we could safely transfer stable tree
> pages to folios.
> This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest
> akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing
> in LTP and kernel selftest.

Just a nit (no need to address for this patch set): "transfer page to
folio" sounds very misleading to me. I'm not a native speaker, but I'd
have called this patch set

"mm/ksm: convert some KSM code to use folios"

It's rather code conversion/transformation, not a transfer.

But again, I'm not a native speaker ...

--
Cheers,

David / dhildenb