Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags

Andrew Morton
2024-04-11T20:42:40Z

On Thu, 11 Apr 2024 13:46:23 +0200 David Hildenbrand <david@redhat.com> wrote:

> On 11.04.24 13:42, Alex Shi wrote:
> >
> >
> > On 4/11/24 3:51 PM, David Hildenbrand wrote:
> >> On 11.04.24 08:17, alexs@kernel.org wrote:
> >>> From: David Hildenbrand <david@redhat.com>
> >>>
> >>> As we are removing get_ksm_page_flags(), make the flags match the new
> >>> function name.
> >>>
> >>> Signed-off-by: David Hildenbrand <david@redhat.com>
> >>> Reviewed-by: Alex Shi <alexs@kernel.org>
> >>> ---
> >>
> >> s/get_ksm_page_flags()/get_ksm_page_flags/ in title, otherwise LGTM.
> >>
> >
> > Uh, for this trivial issue, do I need to sent a new version? or left to maintainer for a quick fix?
>
> I'm sure Andrew can fix that up :)

He indeed can. Although he prefers foo() to foo. Those two characters
have a good information-per-byte ratio.

Also I added Alex's Signed-off-by to this.

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.