* [PATCH] mm/sparse: guard the size of mem_section is power of 2
@ 2024-04-16 1:25 Wei Yang
2024-04-16 4:55 ` Oscar Salvador
2024-04-16 15:20 ` Pasha Tatashin
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yang @ 2024-04-16 1:25 UTC (permalink / raw)
To: rppt, akpm; +Cc: linux-mm, Wei Yang, Pavel Tatashin
We usually have this check, while commit 2a3cb8baef71 ("mm/sparse:
delete old sparse_init and enable new one") missed to take it.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Pavel Tatashin <pasha.tatashin@oracle.com>
---
mm/sparse.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/sparse.c b/mm/sparse.c
index aed0951b87fa..a7d92fe7be19 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -560,6 +560,8 @@ void __init sparse_init(void)
unsigned long pnum_end, pnum_begin, map_count = 1;
int nid_begin;
+ /* see include/linux/mmzone.h 'struct mem_section' definition */
+ BUILD_BUG_ON(!is_power_of_2(sizeof(struct mem_section)));
memblocks_present();
pnum_begin = first_present_section_nr();
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/sparse: guard the size of mem_section is power of 2
2024-04-16 1:25 [PATCH] mm/sparse: guard the size of mem_section is power of 2 Wei Yang
@ 2024-04-16 4:55 ` Oscar Salvador
2024-04-16 15:20 ` Pasha Tatashin
1 sibling, 0 replies; 3+ messages in thread
From: Oscar Salvador @ 2024-04-16 4:55 UTC (permalink / raw)
To: Wei Yang; +Cc: rppt, akpm, linux-mm, Pavel Tatashin
On Tue, Apr 16, 2024 at 01:25:59AM +0000, Wei Yang wrote:
> We usually have this check, while commit 2a3cb8baef71 ("mm/sparse:
> delete old sparse_init and enable new one") missed to take it.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Pavel Tatashin <pasha.tatashin@oracle.com>
Acked-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/sparse: guard the size of mem_section is power of 2
2024-04-16 1:25 [PATCH] mm/sparse: guard the size of mem_section is power of 2 Wei Yang
2024-04-16 4:55 ` Oscar Salvador
@ 2024-04-16 15:20 ` Pasha Tatashin
1 sibling, 0 replies; 3+ messages in thread
From: Pasha Tatashin @ 2024-04-16 15:20 UTC (permalink / raw)
To: Wei Yang; +Cc: rppt, akpm, linux-mm, Pavel Tatashin
On Mon, Apr 15, 2024 at 9:26 PM Wei Yang <richard.weiyang@gmail.com> wrote:
>
> We usually have this check, while commit 2a3cb8baef71 ("mm/sparse:
> delete old sparse_init and enable new one") missed to take it.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Pavel Tatashin <pasha.tatashin@oracle.com>
> ---
> mm/sparse.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/sparse.c b/mm/sparse.c
> index aed0951b87fa..a7d92fe7be19 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -560,6 +560,8 @@ void __init sparse_init(void)
> unsigned long pnum_end, pnum_begin, map_count = 1;
> int nid_begin;
>
> + /* see include/linux/mmzone.h 'struct mem_section' definition */
> + BUILD_BUG_ON(!is_power_of_2(sizeof(struct mem_section)));
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thanks,
Pasha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-16 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-16 1:25 [PATCH] mm/sparse: guard the size of mem_section is power of 2 Wei Yang
2024-04-16 4:55 ` Oscar Salvador
2024-04-16 15:20 ` Pasha Tatashin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).