From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E92BC4345F for ; Sat, 20 Apr 2024 09:15:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B65D26B0085; Sat, 20 Apr 2024 05:15:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AED096B0087; Sat, 20 Apr 2024 05:15:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98BE06B0088; Sat, 20 Apr 2024 05:15:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B1F86B0085 for ; Sat, 20 Apr 2024 05:15:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E670C1203F7 for ; Sat, 20 Apr 2024 09:15:18 +0000 (UTC) X-FDA: 82029351516.04.1DC1101 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 854BC20013 for ; Sat, 20 Apr 2024 09:15:16 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="aBds/mgW"; spf=pass (imf03.hostedemail.com: domain of mhiramat@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=mhiramat@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713604517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AmoEP5EqNLaoMSApXxXfEao3NQocddZzEqTUNkpwMsc=; b=kvM/cqppmCfRI6e7KeaHUGA0+iw20Oq+5FVhrsuwQh0K5k8mYsLFSaChWVeZ+ClzKqeBRW wzcfBYRBPQnvkBCFOyKQvwdOr7+8tAbGufRCphQOg8Kl53Yje8X5GRH2MuDO37otlII5Zi VZ+Dl/txisxQ/wGxZXJx+/ifGV/Z4Rg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="aBds/mgW"; spf=pass (imf03.hostedemail.com: domain of mhiramat@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=mhiramat@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713604517; a=rsa-sha256; cv=none; b=UIR1DoVRkIQV24xxbuwVQH34XVX0ppJth8qfTPGswzzUnRLsWq3YIuCWCjfpw5e2L7CQFd MT2gAjfyXQ4H7afy6VaXUzcV6ZsBv8M2Xewaxd4vu+1+6ZQmgGQ2Xf5ao6adiYSqSbim9a HDpSHuCXChFMOwtDZ9Cc2oWIUWiAcf4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 58511CE0B43; Sat, 20 Apr 2024 09:15:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25CFFC072AA; Sat, 20 Apr 2024 09:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713604511; bh=gV7rq1jKylsNR0A2TW7KiHW+6f/l5HNOVcKuwfOfcOQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aBds/mgWklBGTNfKNq4+Z+94Zp0L3MS4pRFwWjdivOkW3wt77ZSOQfMjY+YYfJZ22 EbOsSdkOWssNdBi3AWqliDK9OwzxsFKXe7srGGHbb4foIL1rR+4xeE7wz/4thWRvf3 BmKK1D9Se8H0/h0Uw/vLAld6i8akxChgiSs8Oa4Avx+zJ1C5hFs5npdPznTRfCWZrf th5mEJA/mw5c94mvYsJOBeAvvZwpVWPpCkBwxsqSy7LgrPU1ayqlu8b38rvXCOVsAE WTdAfWWtTcOpMJCjvDynmh95BCxhT0vOjYzaGiV5GDS7KPjZZmh5efTkoPiO6btvOI JgxLZzkBg4/CA== Date: Sat, 20 Apr 2024 18:15:00 +0900 From: Masami Hiramatsu (Google) To: Mike Rapoport Cc: Christophe Leroy , "linux-kernel@vger.kernel.org" , Alexandre Ghiti , Andrew Morton , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , "bpf@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "loongarch@lists.linux.dev" , "netdev@vger.kernel.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES Message-Id: <20240420181500.07b39c77f1ca086e8a5161b4@kernel.org> In-Reply-To: References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-15-rppt@kernel.org> <20240418061615.5fad23b954bf317c029acc4d@gmail.com> <321def3e-8bf1-4920-92dd-037b20f1272d@csgroup.eu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 854BC20013 X-Stat-Signature: 474ujforfibed4kfisdsw3uekxxz8ur3 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713604516-655164 X-HE-Meta: U2FsdGVkX1+u6ivIR86wx49Tq2gRiNH240ZiSGNP2pTfmfiSNxzBkZGEnyR1qsP886iv4Zry+NyCxn9LLeNBT5zNDsCMZfmFV2W8Z5ZbCeYM9MPwz65KNyqmjFbUv+StDs/frCuBcRkHLOBa0y741sBp0htCN6clqLncT5N3n68629X9Xya/yAVIQaySx27jSLHXqUXKq6aIlmq0di88q1ULDlXDhzJN9r/9p02BgghnVodTgMzq2htvJ2LCkcm1QGeMSrpuAynAg4P17RejCM85XCLw2G7AsYRrraRdh3bXcTRIANTINT1IFyXTVGj6bt9KXgePaZMKPszh6lBk6RA0F9ZT0FfsomvwsWhtsq+7ZBmcIfETXe0JT8uFt0Q8nISEoFNN+srdVI8wRhI3cXCxd/oXLNz5uMdzpU1C6zHT+t/O0u4Ay3KaPBksBVSBoj/YhE/zxhw3UFaljT/5u/KhYORzcOqdAOwDeDknPVAL/AMr9yvT6G8KlSUG+aMUIrdoIKc/GpGKD1GoR5g8AsAwxB4VJjPjf0hAhnZN3M2Uhq7VjstMfXyD4Qi5padAsXD9OzDZFzy++8Xoao2hbSbv+1YDLrN+8+J+UIEsZeVozI7vuClPEVkMymgmHk8rMgasV2h5dNHvs9MGIVFpP6i62zG3NNItyVrmAABrN9dovzIoNX6WL7gHZhjWWg/kjZlUo4vna7b11x6ogVJS4Pb5GwIvHcXwoEDxG7vaZBZZI2ys+GYXMryXWe1Qpb3q7HXvmnqyE2FSZksidiq9B+NB+AIUe+NiHLrSfW0sHciuURPyQp3TFbCQ28imeMnTWxpF6Rp5Q53cy65grJfgi5daRcva9tEomiRE20wnQaPrIOihyghPefDPbRNhTapx3f+ZD4n4nbZ2t/o0+/KQp8wPKJyokX8g9oMerE57vt26mLQHudgBvMppN4KiRR3ZRQ+AjTlEFjfn1SPR+F+ DkHHHQps JhIhGzOt0Qlf3KcTAI5Q+AacjapBRnJmwZQydQeJDHfP9pfQx8IQEMR2BNyk5I8HypfBZzl/oClunN4JV+aSchPSfSNojETSllbImin2hrlYUUW4riBEzISu6NEkQt/jHUtx7gFvk8X7pjtCdiIi/z90yVy4SdJ8TmWEor+HG5ZCPDeymmgLOyZeKvbKV25iM6/fnpfK8Nqz/jG49qzSskObP5wf0OYUOC7cBwu5nhGB+xC6HikAX4sb6r8AqHOfPzJ0yeN3vyfNx818jPSS3kB5bGJzeY1TbtcsSzK2Kc/cxLCODokNyJqWj2NHrXupMSRFV7hZ0SU1oGYEAkmlwlbzEe7xYAOv6YJTk4pBcjquCfVfcyowhFehHdCirjFvsddTp9X0Yh7KCesut1oB1dyChkqVhsOmXphsdXzTy3oLlv9wc7Ez7xiJpevoYlnXTWipJaUqFjlET180= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 20 Apr 2024 10:33:38 +0300 Mike Rapoport wrote: > On Fri, Apr 19, 2024 at 03:59:40PM +0000, Christophe Leroy wrote: > > > > > > Le 19/04/2024 à 17:49, Mike Rapoport a écrit : > > > Hi Masami, > > > > > > On Thu, Apr 18, 2024 at 06:16:15AM +0900, Masami Hiramatsu wrote: > > >> Hi Mike, > > >> > > >> On Thu, 11 Apr 2024 19:00:50 +0300 > > >> Mike Rapoport wrote: > > >> > > >>> From: "Mike Rapoport (IBM)" > > >>> > > >>> kprobes depended on CONFIG_MODULES because it has to allocate memory for > > >>> code. > > >>> > > >>> Since code allocations are now implemented with execmem, kprobes can be > > >>> enabled in non-modular kernels. > > >>> > > >>> Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside > > >>> modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the > > >>> dependency of CONFIG_KPROBES on CONFIG_MODULES. > > >> > > >> Thanks for this work, but this conflicts with the latest fix in v6.9-rc4. > > >> Also, can you use IS_ENABLED(CONFIG_MODULES) instead of #ifdefs in > > >> function body? We have enough dummy functions for that, so it should > > >> not make a problem. > > > > > > The code in check_kprobe_address_safe() that gets the module and checks for > > > __init functions does not compile with IS_ENABLED(CONFIG_MODULES). > > > I can pull it out to a helper or leave #ifdef in the function body, > > > whichever you prefer. > > > > As far as I can see, the only problem is MODULE_STATE_COMING. > > Can we move 'enum module_state' out of #ifdef CONFIG_MODULES in module.h ? > > There's dereference of 'struct module' there: > > (*probed_mod)->state != MODULE_STATE_COMING) { > ... > } > > so moving out 'enum module_state' won't be enough. Hmm, this part should be inline functions like; #ifdef CONFIG_MODULES static inline bool module_is_coming(struct module *mod) { return mod->state == MODULE_STATE_COMING; } #else #define module_is_coming(mod) (false) #endif Then we don't need the enum. Thank you, > > > > > > >> -- > > >> Masami Hiramatsu > > > > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google)