From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6050C4345F for ; Tue, 23 Apr 2024 09:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23AA26B00E8; Tue, 23 Apr 2024 05:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA856B00E9; Tue, 23 Apr 2024 05:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08BAA6B00EA; Tue, 23 Apr 2024 05:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DDD896B00E8 for ; Tue, 23 Apr 2024 05:14:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6FD1380D7D for ; Tue, 23 Apr 2024 09:14:01 +0000 (UTC) X-FDA: 82040234682.28.AF2BB3D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 244161A000A for ; Tue, 23 Apr 2024 09:13:58 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="CWiYY/s3"; spf=pass (imf19.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713863639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1xckAbIaUxfV2U1fI0YjievZgsT18mecVG8rOgbjUb8=; b=38uRQTxGeI6cDru5ujmssWR66PM7Y10JrbVVUl43l+VSKcp6XHNVh8m5y+hPXQcvccxXb+ L3eNiZLUSJ1m9qdNWmmhEGi6R+H77z+wvSa9GX+FMXxHDHwzULju83ZCg9COLtN19dXvtc /4tbkv9yC2Nm86dmqMw0V0D12b1oqik= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="CWiYY/s3"; spf=pass (imf19.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713863639; a=rsa-sha256; cv=none; b=ynj3myfRDzHesuBrW8G5IlB/OySCJW8gGdD0FjDSiI8+A1jJIWbKs+O9O2hJXpHBUvAnii ptZ+LJ9yOIxqzxTY5kBFmvbsH2Mrqr9mSNUoVw0nInSON6VvpIthwEadrc3iHvrD4qX4Qw wmpN08Q6A5rzpEjmqlWjNh7zP7zckFI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713863638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1xckAbIaUxfV2U1fI0YjievZgsT18mecVG8rOgbjUb8=; b=CWiYY/s36hHtEL67Bm+5EWyU+LCfEG1UpfLWnEVIbXz0KuWAko7PgPVD3dk4UJWqNe6Cy8 pipte2Mok/ZysRZpH8n9oy09LCjzYr+mUm9XpGEmOY9faaMhPiWTv3NELmf1vqiUg0UCrj XVldl4laWxKDdJksranNVMNeFhmUpjQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-ATs_FqcQNba0FB33IukD1w-1; Tue, 23 Apr 2024 05:13:56 -0400 X-MC-Unique: ATs_FqcQNba0FB33IukD1w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-34a4ded7d49so4635686f8f.1 for ; Tue, 23 Apr 2024 02:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713863635; x=1714468435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1xckAbIaUxfV2U1fI0YjievZgsT18mecVG8rOgbjUb8=; b=HKxf8CMGNorASqcpdMJL374R+A1QDmS2aT5TcHLAhW2bHgcXvyxfwNPpjBEQkMolVy SLQUx8Tx1+DA2bnbpu5gTeCTx5JIfQj3+8aE0VYsDcMHTZrgdDXn9fM9DExqunR/bbCZ sV6932GG8UwUkDB3doB0iS0h6nVlWt9hLlmwSotXrl4WfxGMpaDHoySIKUeeFTflnp0H UWW9DeV6hHl0mPeynDoaTy+7MRbZF9iF48MUoJ9ntuJ4xi36Z/A6E+9Spa1W1/zXtKRw sQpB1/YNoCtMfN2wU/LKxf9749xxbR2g6HgUdmzN/XyRKFSGpuTVmt3HvXHn/trplPSJ nJUQ== X-Forwarded-Encrypted: i=1; AJvYcCVgvS90NkanPCKvW9FM3gZMPHUNoffqi5NBEofOkq+n+zlYvyK7zMI35ZioCeyhP/6EoVWGrfmTtcQdQS12mz2eibA= X-Gm-Message-State: AOJu0YxVrgpB5T5dRuNxgYNhtKmT9y/AbNva4MLUiLhin+9elG6nyx9e tHdV3g9WbbdkcdoX5AXFM2Ju5sHlUoyrPz/5RK5gjxDdkXvmjKwvpTBqGnFxZ5CBpzrc9BEbLdM mHFZKHcM2mX/Mg33s7KmFSm0hjUA/o75rH5rH/3R+9YJYFfcX X-Received: by 2002:a5d:6d8d:0:b0:343:f335:2489 with SMTP id l13-20020a5d6d8d000000b00343f3352489mr9334360wrs.59.1713863635399; Tue, 23 Apr 2024 02:13:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrpMdpbG8FFAw85brCrIe+xZ/QGNjBiBptgCa0RJlLmPxE7ErKfP7eMNOPOzyyRh2eNOA1Bg== X-Received: by 2002:a5d:6d8d:0:b0:343:f335:2489 with SMTP id l13-20020a5d6d8d000000b00343f3352489mr9334339wrs.59.1713863634871; Tue, 23 Apr 2024 02:13:54 -0700 (PDT) Received: from redhat.com ([2a06:c701:7429:3c00:dc4a:cd5:7b1c:f7c2]) by smtp.gmail.com with ESMTPSA id z2-20020adff742000000b00343ca138924sm14071319wrp.39.2024.04.23.02.13.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 02:13:53 -0700 (PDT) Date: Tue, 23 Apr 2024 05:13:50 -0400 From: "Michael S. Tsirkin" To: zhenwei pi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 2/4] virtio_balloon: introduce oom-kill invocations Message-ID: <20240423051151-mutt-send-email-mst@kernel.org> References: <20240423034109.1552866-1-pizhenwei@bytedance.com> <20240423034109.1552866-3-pizhenwei@bytedance.com> MIME-Version: 1.0 In-Reply-To: <20240423034109.1552866-3-pizhenwei@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: fxb7cw6x7bucams7fn8nkbg9e9jsbmxc X-Rspamd-Queue-Id: 244161A000A X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713863638-873548 X-HE-Meta: U2FsdGVkX19RX0UrqxmBzKk0rsAvrNcXAgi/ara9U1kjyr4gh5Z29cZTxQnjEDGp+Uz/yXNVMpl3wTuiKJs+fvnIVRVrfBkLMXY9YY4hb1QysjLb7wBOmcBt9XkV9x72qPT8JPyGPHGW8DEJbEXbpdGWQce0kLPv0nUEuiBIUheyQwkelW8VQEBgr5IKwtXVBOBW0WJ7XKasl51oDThZEHvOZi1cie1IW4al4PzXoEi4dgBVfZtg7om/CngDXf55nwSZ0f/UidLUo7EUSsgFEJ7WdSpmr0NYtDdVsYKJxGw8J2NL0mIpDxG41WiSKAcZzwUnjW2vgm/3x70EwEPXuu2sFQVX/YlrP8fcLYYiLnaWNN5HZuETH+0sAGwt/I2SxgxTkN+UlDcCDPlpYYNbihurgdlZDfdroSIRH+lQ2yAXlh4+6WrE7UGKUnQeqkpgcZtnjYAWxk3bUkUAEOESNppzbQrLx6kJI36BA1Cyburg3ePdrtyQT9s5uD32sFRUSM9dM4hdJkddu8aiVaXfOEQrnWlTbPitRJ2NDRAKNMDmD9tgztFGw0XUgC65HMMSctT2qQ82QDNG3uNy2g8cxGwsHMW2M5KxXbdFOdiVecnrmc3UaOtbFxhQKqM+Ft2HqNg4fMfkoKANTOpyd5n/hUGmb3XPF3vYk2wnBUxTBpNbRaoV88Em1zNMPsjRLdTWR4WeNzyx+LotXOExG5wn4yHCrIScfen8944x+NzftoTKo4FDQSV/g74167R2+n0KSP8mm5h3Pz2LRsrMXI4he2D/qmShqyut1PTVgGhjJe/YUOOmTQQh3nJlXK71eZDw7JkK661MaNQ77PZ4vlCWfCUqOblvNS3UyOxhMxOA1/aA3tqJ+qrzmvszuPaJVnX0WVryfViYx0p9H8NKejIHF7M/31Jps3BCkgp88tg8v3rwTSviVnq3PCoODB/AJIbhiOE5FJdpx8A87JfFJf1 oaIf54pW cDP9gZpcE1R64UvqLzChifsrNjD5Y2Jn1Lus16FlhAQZNhYM1io4j4SJ4Go508Mt5q52pOXk0O6B6S0NGWbvoyI/Vp8KBpTT6pd4XdIZEqAOrv2n9nVtPJnoHNB0+zUlEI//oC+heAhHAnbj9N/JVgnhsJLaQW66ZjRdDzF+lxUUIbv33zrFibEe5pJWFBdx3Jtqe22R2sjLVmzNDXp9EtneF2VNGZc7sql/VUaS+8sHea4C9fk00T+UaA/uqqsS9PXnKPK6z+dnIOW7ZX2poYkmuU4Ab76R+0pfya4CI3Gg5eGKAI8HSja8qdSer3uzcRyWghiaZRKpaaK0FEnLBQ0dZbSoOUD9i0LoOQ24avbpRzMNfNyWW5I0IpDNB1vVOx+gAD/QRZTRcJ3+0KExVMJ0yI+de1OO0glNU2CrsTRLLJ+TeISa9aIzyLv1s3jX1RHwTyPXmSCyQHQcY20GKm/7djjCRq6XEN2M3OBKvMkGmDI4GGGQ5DmR9ZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 11:41:07AM +0800, zhenwei pi wrote: > When the guest OS runs under critical memory pressure, the guest > starts to kill processes. A guest monitor agent may scan 'oom_kill' > from /proc/vmstat, and reports the OOM KILL event. However, the agent > may be killed and we will loss this critical event(and the later > events). > > For now we can also grep for magic words in guest kernel log from host > side. Rather than this unstable way, virtio balloon reports OOM-KILL > invocations instead. > > Acked-by: David Hildenbrand > Signed-off-by: zhenwei pi > --- > drivers/virtio/virtio_balloon.c | 1 + > include/uapi/linux/virtio_balloon.h | 6 ++++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 1710e3098ecd..f7a47eaa0936 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -330,6 +330,7 @@ static inline unsigned int update_balloon_vm_stats(struct virtio_balloon *vb) > pages_to_bytes(events[PSWPOUT])); > update_stat(vb, idx++, VIRTIO_BALLOON_S_MAJFLT, events[PGMAJFAULT]); > update_stat(vb, idx++, VIRTIO_BALLOON_S_MINFLT, events[PGFAULT]); > + update_stat(vb, idx++, VIRTIO_BALLOON_S_OOM_KILL, events[OOM_KILL]); > > #ifdef CONFIG_HUGETLB_PAGE > update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index ddaa45e723c4..b17bbe033697 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -71,7 +71,8 @@ struct virtio_balloon_config { > #define VIRTIO_BALLOON_S_CACHES 7 /* Disk caches */ > #define VIRTIO_BALLOON_S_HTLB_PGALLOC 8 /* Hugetlb page allocations */ > #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ > -#define VIRTIO_BALLOON_S_NR 10 > +#define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ > +#define VIRTIO_BALLOON_S_NR 11 > > #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ > VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ Looks like a useful extension. But any UAPI extension has to go to virtio spec first. > @@ -83,7 +84,8 @@ struct virtio_balloon_config { > VIRTIO_BALLOON_S_NAMES_prefix "available-memory", \ > VIRTIO_BALLOON_S_NAMES_prefix "disk-caches", \ > VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ > - VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures" \ > + VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ > + VIRTIO_BALLOON_S_NAMES_prefix "oom-kills" \ > } > > #define VIRTIO_BALLOON_S_NAMES VIRTIO_BALLOON_S_NAMES_WITH_PREFIX("") > -- > 2.34.1