Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

Andy Shevchenko
2024-04-23T18:27:17Z

On Tue, Apr 23, 2024 at 11:10:00AM -0700, Andrew Morton wrote:
> On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > In some configurations I got
> > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > Becuase the only user is guarged with a certain ifdeffery,
> > do the same for add_to_free_list().

...

> Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate
> free page accounting".

Thank you!

> Please do tell us the config when fixing these things. That way I can
> do a little bisect to ensure that I correctly identified the offending
> patch.

Hmm... You mean defconfig? I can share it.

I built this with `make W=1`, probably that one helps, but the MM parts of
the defconfig have not been altered by me from the x86_64_defconfig.

--
With Best Regards,
Andy Shevchenko