From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E1FC4345F for ; Tue, 23 Apr 2024 16:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 036666B013E; Tue, 23 Apr 2024 12:55:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F28916B013F; Tue, 23 Apr 2024 12:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E184B6B0140; Tue, 23 Apr 2024 12:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C48246B013E for ; Tue, 23 Apr 2024 12:55:29 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6F9E1A19C0 for ; Tue, 23 Apr 2024 16:55:29 +0000 (UTC) X-FDA: 82041397578.23.589B69F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id CA124100008 for ; Tue, 23 Apr 2024 16:55:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ezxoz0JN; spf=pass (imf14.hostedemail.com: domain of horms@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713891327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ke21vGLxTbiYdn66o6jQAkiY0YatVuS+BmIeM6oA+SQ=; b=HkL9C2K3kcpiaYn0VTRourl7cjtUDaeJ8EDZ1VvKlMo6IwQHeiyUyBL3iAn4EugzRRbVwC 7ZD0Wvsdn5MCprWm3iWcr966JQhUiNkB0xAhmzv9aE4vuabVh5R3NoPvNCqGUinlDijhXa lovOawCrqDn284Psq8H+VjgpsX2yuEY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713891327; a=rsa-sha256; cv=none; b=AjPbKklLl8+wBDY2TspjdrWpnKYp4rwxGw7SltkVzTHdVugjiIcfq4KZWkUH4lhXMhiOrV C2GhRORWc/NwdQUhE7XTWUDQrrqKnZoe8h7TpO4dOzeoaCsKQ4TcJlR92KAfisOW4FeWzX 0U1te4SzDTGtNUkmrZra0Hve8NNPZy8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ezxoz0JN; spf=pass (imf14.hostedemail.com: domain of horms@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD5C1615F8; Tue, 23 Apr 2024 16:55:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BE96C116B1; Tue, 23 Apr 2024 16:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713891326; bh=WqT3utdI5b+8PdLzOvnk+8UFlfoDWKCG6SiuaqMuXF8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ezxoz0JNznH9GtJky0APUGmvH44iFk14b5gOc+DVzHoY1xMrKl9A0trliOrFeNpFq 6tcPCid7kcCUghefRnMDOphFnmYbjh2RbBsVJxr31hb76uVVKv3kOgdX86YU7HcESF HP3G97AVXmfAyRe/LzYoxxa1tH7TtpdxUAInja1sb55AIxSzlibrCquZMRfdxb77qh eLABCmNkjhrLmbscr5CvbdX5OqP0nyzIR6d/TE6+/q1jd6NpJq1eLUoPEZs8g3ReL2 PGk+5XUO0Ix5GLLUXDn2NsGltlKTzx8byGgJcrDw48nxpYsvohSClO8D7xaLPFt3OR rXOaz5Pk5cxNQ== Date: Tue, 23 Apr 2024 17:53:50 +0100 From: Simon Horman To: Jesper Dangaard Brouer Cc: tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, yosryahmed@google.com, longman@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, shakeel.butt@linux.dev, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior , mhocko@kernel.org Subject: Re: [PATCH v1 1/3] cgroup/rstat: add cgroup_rstat_lock helpers and tracepoints Message-ID: <20240423165350.GY42092@kernel.org> References: <171328983017.3930751.9484082608778623495.stgit@firesoul> <171328988660.3930751.17537768209042139758.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171328988660.3930751.17537768209042139758.stgit@firesoul> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CA124100008 X-Stat-Signature: dqb7rceeed9fsfwr9noedc84aaypund8 X-Rspam-User: X-HE-Tag: 1713891327-285607 X-HE-Meta: U2FsdGVkX1/HLXdJZN2/fGKrVpRaAljuRlpCxRJ3M2Oo7VxKvjctcT+E6h8BnyKGKKouDydq1KiXR70m7O3CHow6WgXPe6XxmU9l1no2yaNFUlBGrFb2HNJV6Xf/cLjf3LcyBU++Ob4shB92laqZtaSyztFPPqA1yMsfgw5JnOcSCfKYU98pMGS46ZYHD3AiR8M3QTSP9qAYxywyBUdy79CpEM4dXn+PCYRgSbVIzOkaqVfaF/JQeJZ++D5b0t4xPP/d4Qq9iXlAbibEnpdX2xSBWrkWu52jJy/dPvOyueedZxHPwND2RIk2KKZr+gv+TVM8Pvr1V+VVCOinvVhH8gNp5UHJtpOEseMKjuGItPxcJOepyb7jgNpkJOFIPDdtxPuLS5tKzKGzMaB4TEbo9a+1jiW17PBZ+7ZI0Hr1eTF32yE3WoXkMYqaKRdinwIIob8Btu02hItt2XbbEId6ufvl2seKtILCzc1NhIx7zexKdd99VHS9PtkNUhT1Dq2WCezvHuDLBh7scqIQKhjrC6YftbEi58/5p2rojRtAjKMaTNmXe0/nJYr5roFGzJy84efIt0/OxrgVHpfZejNTrCnYGFBiQ8ED2XHYOEMOGpCy5qhxx1eJ+eY9As+xuJkyCOY+skMZoVeEfRm5mnRGyUUfvn6H6vgeMKpImEcCVO0XGYSk3Xe81IyJvc+mKq4NqC1IsVgKgjTNPyk2wYLWR6P+sDzwrxjIMysZK68gr1N+3cBVNCgQUm7h/it3r0X6Ng5+/O/nrM4G9VXscxFu1RObCjjxJJ7qfJILXGl08KrD1M4XOOY4h2d6AQdaMrN440CwNqplYKrNyZqo/AKH/ys9nzthq3i3gJxBbg+k+nscpazF4t+Z9/1UV74fOE8DwuYhOmYZTpvRhh6gc29eZJb7Cyh/kTZLlC+21kPL0zLW19s7F8H19evUmv0657yPIaWooXD+oiDDypm7p3U bRGipTff jK52ciJGE6hDArK3UpgKBpCAQM7DTDWnzvFSGH6moGE0HIJC90mbvjTmG8ac54fVE6ET2yKgJzb/6RqR/FyiIB9BqYUsx23vxkG0yIdXKvyABlFSWVcRbI+X92BsElSSwN2d1Sro/6VUsOHeuxq1i5YVDWFrzcj6SvfuWAV2pzZIR1Leyy0d0EgBvlPvIGbtpZVg6IYFnSkMTYuxLNW+BnE4xIV1dylb4SUkDHX14rF4RupNNrcXhuuSMVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000273, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 07:51:26PM +0200, Jesper Dangaard Brouer wrote: ... > /** > * cgroup_rstat_flush_release - release cgroup_rstat_flush_hold() > */ Hi Jesper, as a follow-up could you add an entry for cgrp to the kernel doc above? > -void cgroup_rstat_flush_release(void) > +void cgroup_rstat_flush_release(struct cgroup *cgrp) > __releases(&cgroup_rstat_lock) > { > - spin_unlock_irq(&cgroup_rstat_lock); > + __cgroup_rstat_unlock(cgrp, -1); > } ...