[PATCH v3 0/2] clean-up for create_kmalloc_caches()

[PATCH v3 0/2] clean-up for create_kmalloc_caches()

[Hyunmin Lee]

Hi pals,

I am cleanning up unnecessary code in create_kmalloc_caches(). I added
one more commit to remove the check for NULL kmalloc_cachee according to
the review comments like below.

- David Rientjes suggested moving the check for NULL kmalloc_caches to
new_kmalloc_cache().
- Christoph Lameter suggested skipping the check for the kmalloc caches
already being present.

Thanks,
Hyunmin


Hyunmin Lee (2):
  mm/slub: create kmalloc 96 and 192 caches regardless cache size order
  mm/slub: remove the check for NULL kmalloc_caches

 mm/slab_common.c | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

-- 
2.34.1

[PATCH v3 1/2] mm/slub: create kmalloc 96 and 192 caches regardless cache size order

[Hyunmin Lee]

For SLAB the kmalloc caches needed to be created in ascending sizes in
order. However, the constraint is not necessary anymore because SLAB has
been removed and SLUB doesn't need to comply with the constraint. Thus,
kmalloc 96 and 192 caches can be created after the other size kmalloc
caches are created instead of checking every time to find their order to
be created. Also, this change could prevent engineers from being confused
by the removed constraint.

Signed-off-by: Hyunmin Lee <hyunminlr@gmail.com>
Co-developed-by: Jeungwoo Yoo <casionwoo@gmail.com>
Signed-off-by: Jeungwoo Yoo <casionwoo@gmail.com>
Co-developed-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
 mm/slab_common.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 3179a6aeffc5..ed7b8592b62c 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -916,21 +916,16 @@ void __init create_kmalloc_caches(void)
 	 * Including KMALLOC_CGROUP if CONFIG_MEMCG_KMEM defined
 	 */
 	for (type = KMALLOC_NORMAL; type < NR_KMALLOC_TYPES; type++) {
+		/* Caches that are NOT of the two-to-the-power-of size. */
+		if (KMALLOC_MIN_SIZE <= 32 && !kmalloc_caches[type][1])
+			new_kmalloc_cache(1, type);
+		if (KMALLOC_MIN_SIZE <= 64 && !kmalloc_caches[type][2])
+			new_kmalloc_cache(2, type);
+
+		/* Caches that are of the two-to-the-power-of size. */
 		for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) {
 			if (!kmalloc_caches[type][i])
 				new_kmalloc_cache(i, type);
-
-			/*
-			 * Caches that are not of the two-to-the-power-of size.
-			 * These have to be created immediately after the
-			 * earlier power of two caches
-			 */
-			if (KMALLOC_MIN_SIZE <= 32 && i == 6 &&
-					!kmalloc_caches[type][1])
-				new_kmalloc_cache(1, type);
-			if (KMALLOC_MIN_SIZE <= 64 && i == 7 &&
-					!kmalloc_caches[type][2])
-				new_kmalloc_cache(2, type);
 		}
 	}
 #ifdef CONFIG_RANDOM_KMALLOC_CACHES
-- 
2.34.1

Re: [PATCH v3 1/2] mm/slub: create kmalloc 96 and 192 caches regardless cache size order

[Christoph Lameter (Ampere)]

On Wed, 24 Apr 2024, Hyunmin Lee wrote:

> For SLAB the kmalloc caches needed to be created in ascending sizes in
> order. However, the constraint is not necessary anymore because SLAB has
> been removed and SLUB doesn't need to comply with the constraint. Thus,
> kmalloc 96 and 192 caches can be created after the other size kmalloc
> caches are created instead of checking every time to find their order to
> be created. Also, this change could prevent engineers from being confused
> by the removed constraint.

Reviewed-by: Christoph Lameter <cl@linux.com>

Re: [PATCH v3 1/2] mm/slub: create kmalloc 96 and 192 caches regardless cache size order

[David Rientjes]

On Wed, 24 Apr 2024, Hyunmin Lee wrote:

> For SLAB the kmalloc caches needed to be created in ascending sizes in
> order. However, the constraint is not necessary anymore because SLAB has
> been removed and SLUB doesn't need to comply with the constraint. Thus,
> kmalloc 96 and 192 caches can be created after the other size kmalloc
> caches are created instead of checking every time to find their order to
> be created. Also, this change could prevent engineers from being confused
> by the removed constraint.
> 
> Signed-off-by: Hyunmin Lee <hyunminlr@gmail.com>
> Co-developed-by: Jeungwoo Yoo <casionwoo@gmail.com>
> Signed-off-by: Jeungwoo Yoo <casionwoo@gmail.com>
> Co-developed-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
> Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

Acked-by: David Rientjes <rientjes@google.com>

Re: [PATCH v3 2/2] mm/slub: remove the check for NULL kmalloc_caches

[Christoph Lameter (Ampere)]

On Wed, 24 Apr 2024, Hyunmin Lee wrote:

> If the same size kmalloc cache already exists, it should not be created
> again. So there is the check for NULL kmalloc_caches before calling the
> kmalloc creation function. However, new_kmalloc_cache() itself checks NULL
> kmalloc_cahces before cache creation. Therefore, the NULL check is not
> necessary in this function.

Reviewed-by: Christoph Lameter <cl@linux.com>

Re: [PATCH v3 2/2] mm/slub: remove the check for NULL kmalloc_caches

[David Rientjes]

On Wed, 24 Apr 2024, Hyunmin Lee wrote:

> If the same size kmalloc cache already exists, it should not be created
> again. So there is the check for NULL kmalloc_caches before calling the
> kmalloc creation function. However, new_kmalloc_cache() itself checks NULL
> kmalloc_cahces before cache creation. Therefore, the NULL check is not
> necessary in this function.
> 
> Signed-off-by: Hyunmin Lee <hyunminlr@gmail.com>
> Co-developed-by: Jeungwoo Yoo <casionwoo@gmail.com>
> Signed-off-by: Jeungwoo Yoo <casionwoo@gmail.com>
> Co-developed-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
> Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

Acked-by: David Rientjes <rientjes@google.com>

Re: [PATCH v3 0/2] clean-up for create_kmalloc_caches()

[Vlastimil Babka]

On 4/24/24 16:04, Hyunmin Lee wrote:
> Hi pals,
> 
> I am cleanning up unnecessary code in create_kmalloc_caches(). I added
> one more commit to remove the check for NULL kmalloc_cachee according to
> the review comments like below.
> 
> - David Rientjes suggested moving the check for NULL kmalloc_caches to
> new_kmalloc_cache().
> - Christoph Lameter suggested skipping the check for the kmalloc caches
> already being present.
> 
> Thanks,
> Hyunmin

Thanks, applied to slab/for-6.10

> Hyunmin Lee (2):
>   mm/slub: create kmalloc 96 and 192 caches regardless cache size order
>   mm/slub: remove the check for NULL kmalloc_caches
> 
>  mm/slab_common.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)
>