From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1877EC4345F for ; Thu, 25 Apr 2024 20:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02D926B007B; Thu, 25 Apr 2024 16:01:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF83E6B0082; Thu, 25 Apr 2024 16:00:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4B676B0083; Thu, 25 Apr 2024 16:00:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B412F6B007B for ; Thu, 25 Apr 2024 16:00:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 11751120533 for ; Thu, 25 Apr 2024 20:00:59 +0000 (UTC) X-FDA: 82049122638.17.F6A7DA4 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf20.hostedemail.com (Postfix) with ESMTP id 0559A1C0020 for ; Thu, 25 Apr 2024 20:00:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Dj1T60P9; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714075257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MPiDO/NuWlBDCPQueU9revoy2ZKV+QsKTFlIIgwR/BM=; b=3B3GEWT6fmSsPai2+vajWYB7KG9hp74NAxEw5hgaBwtjWNs67DViSy/vq5yZ2XxupwZ5tF nW4ryI6ECcWCebcgR16zaVdxEGgwvz4SVtn2jm5qtCzbcHu4guqUwPdyjxLgeVBZXBHzFQ XKIZ6kAe96LP69zXaiNa2/BIJn9MUiY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Dj1T60P9; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714075257; a=rsa-sha256; cv=none; b=JQLeSG0nQgcL4gBaYl8SlzCOfLL8SU1z/06oEJH85OnpxL7KqmPk1wd7quNYw21vw8GRft A3XRoqI0M+01K8oyWPQRBWhaE/Zp6V2GIhffcuVWbGif9V2PUPiSABJUW/xAQH67XSXlXl 7nayFh83a91KND0m50Y2WA9ZZ9hHLBI= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1eac92f7c74so7887195ad.3 for ; Thu, 25 Apr 2024 13:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714075256; x=1714680056; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=MPiDO/NuWlBDCPQueU9revoy2ZKV+QsKTFlIIgwR/BM=; b=Dj1T60P9/zjClOBxqNzbndFSTYjpNMW592RvdAbs0A3A2mB5sRYuXzFYoz/SbqHNlq oLC7W05bx8pVWYhAG1++9HdoYVvJAv9g8nofofPd0fMxJwIUZpYBmyVsLwg8uHi97JUb 23GPKBjuwhGB92SiL0S8ZbBkjsXGHM7i4mkXY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714075256; x=1714680056; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MPiDO/NuWlBDCPQueU9revoy2ZKV+QsKTFlIIgwR/BM=; b=ND7Fv9mkBNZEN72tEB/7hHMxBjQHsrUAnSWlTk3+J+pHFMk3tXzERdlaJJdGJ6g2wX kvmHU7YOdzFRERuC8j3HY/DCd7UniAwBOuHypNkUP7DWa/0lYTNsMeRcs+S5xC6USnlH 9UgMEMGVmGg0znBBp+vx0mfnVzjO5J8eW7wp+bEzsBmhnKIfTgQzrpinvKCSBAL69a0e ewWtI/eMlrEIs7niXKf3HZeplIEoJ+Iqwx49E28BNv4/XmPVI+n0DOcd0eKp/sy+ZYWF 9tjtwH39onNvAzhBVMz2Yy4nCMENo6WiebzC6vf8TSIDbSKc5xxzeO8/3ZobDhfSB4it 3AnQ== X-Forwarded-Encrypted: i=1; AJvYcCUZJbMhseB3mF+UHYqDP7EGi2bz6LfnCA1VLoRxIrMcp/StQw0nTAEhJ07prwgc+O8uRJosZoSnUYAl5qOoJ/Vb+k8= X-Gm-Message-State: AOJu0Yxig3FuZg10Yb0AW47TeArw8AiZxhZpKL49svgljj2k+4trA9re m4Keq2VsBre3QzQJFFo9FVqxsmP7kUAccvGk5zYNGvXAlgFEnUzAOljDyOUyiQ== X-Google-Smtp-Source: AGHT+IEo0tR5TUzDFHu6Hua7ES8NMeZzOO6dI3yrKVh3oLcNyfNfOUSp0zPv/yd1E7yoaunXCQMMBg== X-Received: by 2002:a17:902:b097:b0:1e4:6232:367a with SMTP id p23-20020a170902b09700b001e46232367amr573515plr.22.1714075255642; Thu, 25 Apr 2024 13:00:55 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id q4-20020a17090311c400b001eab3ba79f2sm1827250plh.35.2024.04.25.13.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 13:00:55 -0700 (PDT) Date: Thu, 25 Apr 2024 13:00:54 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: Kent Overstreet , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 00/37] Memory allocation profiling Message-ID: <202404251254.FE91E2FD8@keescook> References: <20240321163705.3067592-1-surenb@google.com> <202404241852.DC4067B7@keescook> <3eyvxqihylh4st6baagn6o6scw3qhcb6lapgli4wsic2fvbyzu@h66mqxcikmcp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0559A1C0020 X-Stat-Signature: jjhxix94y7e8ram34iypyjcxdpqmz6ze X-HE-Tag: 1714075256-15818 X-HE-Meta: U2FsdGVkX1+k0KaBN7oTRjsE3nBiW8OxPnQ3VNZ9UWiinkx9yI+JpEd8Znzv2w5kDs+TQ/Jlz8/S5vMTGXLnPEUxdHxqZP1B8yIEjCUeTjzVscO31weXAZQ5kr6ScL/sfnSbeI8qDol/+AvSnQi18ifXUmxCla/NXPtpGMbyNb2/5BO8szoInssW80OyCF0rFvxJns3aQKRXAVf3y/AkL+nNHidQ5nyKgcwk6k8I8qE7c2sV7JDxvue2XpSor2aECeTPu5oniCu1YkkJaLCcvZBKnDqFPhxqM0VzLrthoHdOuzvz3fhFgqIQ2BVAo3H2npxlk4mKJLpmfT/GwlrqhXle+wxhxd5b9atwTnzrE1c7V1FgaPlJpE7SgCl8HYr5GwOMGPEXbBsueUnbdL8tgFE+xejv0aW2Rh1W6CPPlSU5486xZ7z0feK02DFTAUtvYn4mJs980j2hWGU1w4YxCO5E8o9m6ybyuk8RE2M/2ZbI7HGGKLUMoaCHvGWL9ZY3bRYNp+lRbLR76aE7bJFUi9UOQ9ueob9Ni4cvcNTzBTf8fQcecyn+JMCtKp/U5GzKHcIbijUMAIX4vc6X9ERwGWglzpJhU/lXMGewup4tdtf2/7tHhQ8uT7WTzV2rsJupMfcIzM7NB3+aoZiEY31febAjbAOZXbqFwlyczpKhGveA/dBXtgEfjx0r7+WpKEevrLyhH8DXPFrLAi/5Bu7JCthV4p28HRbiJa69vgaah7jSoAaapZp/xDUMsZJs20lU0dfYK86tX7Q0+eRPRw4+i2Uxgkg9JpyyZ+22FDI+j38OH1VGGRWQSihQveT0WSLAFmCc9Od44v4OPE/rvNkcC+rGShVCMUfPoTxBAJ8CZU4XLtCPMmuq+b2TRKE9ofiaedhTcpuD5lzs4DEwcDxeHANp1UrYtCfltlR87u38r6MbP9hwsPtTxQ3piTDDzfNSrCPeZP4KJILkL18orj/ IPgmjaW5 HQUTjdM5ZgECRqBaTm+Yomd+6t5gm61qih/P2vBAoip6T5kOCPx5lnOQqrN4BxjM9kHgDo+5JTN7DY6P0Gz3Ca9+FManI5GiSwc1kJlJecv6e6bZsJDCg8UQWxikzfx1VKoCSuzNLGMbCyO8gmfiDi5iBNbVBYrNBz6C6jaOO5oRhuoGUe14hEEQiy19N4TbSnJQtIQGI+0DAfWaTGERSuC6zM/hqCPuEulGWwRQ0RSNABp2ynki3eWgAZT0oLwquxBL+nbCQgn1pkpDtYdxw/jHfCTx05Z7BY1ZpUwKpWRa4mzRh1wQ4WCR0QzUWCCaB+F8we3mseNWbHd5cyzkjxCjMhsU3CUzueqbNAEgwxkxdOSBzFwE2JVz/v13aRR9UaV8xcnUDf+M9NEHzC7nfdBlEfyfSLML4CoDuH1Wwpip9Nzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 08:39:37AM -0700, Suren Baghdasaryan wrote: > On Wed, Apr 24, 2024 at 8:26 PM Kent Overstreet > wrote: > > > > On Wed, Apr 24, 2024 at 06:59:01PM -0700, Kees Cook wrote: > > > On Thu, Mar 21, 2024 at 09:36:22AM -0700, Suren Baghdasaryan wrote: > > > > Low overhead [1] per-callsite memory allocation profiling. Not just for > > > > debug kernels, overhead low enough to be deployed in production. > > > > > > Okay, I think I'm holding it wrong. With next-20240424 if I set: > > > > > > CONFIG_CODE_TAGGING=y > > > CONFIG_MEM_ALLOC_PROFILING=y > > > CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=y > > > > > > My test system totally freaks out: > > > > > > ... > > > SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1 > > > Oops: general protection fault, probably for non-canonical address 0xc388d881e4808550: 0000 [#1] PREEMPT SMP NOPTI > > > CPU: 0 PID: 0 Comm: swapper Not tainted 6.9.0-rc5-next-20240424 #1 > > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 > > > RIP: 0010:__kmalloc_node_noprof+0xcd/0x560 > > > > > > Which is: > > > > > > __kmalloc_node_noprof+0xcd/0x560: > > > __slab_alloc_node at mm/slub.c:3780 (discriminator 2) > > > (inlined by) slab_alloc_node at mm/slub.c:3982 (discriminator 2) > > > (inlined by) __do_kmalloc_node at mm/slub.c:4114 (discriminator 2) > > > (inlined by) __kmalloc_node_noprof at mm/slub.c:4122 (discriminator 2) > > > > > > Which is: > > > > > > tid = READ_ONCE(c->tid); > > > > > > I haven't gotten any further than that; I'm EOD. Anyone seen anything > > > like this with this series? > > > > I certainly haven't. That looks like some real corruption, we're in slub > > internal data structures and derefing a garbage address. Check kasan and > > all that? > > Hi Kees, > I tested next-20240424 yesterday with defconfig and > CONFIG_MEM_ALLOC_PROFILING enabled but didn't see any issue like that. > Could you share your config file please? Well *that* took a while to .config bisect. I probably should have found it sooner, but CONFIG_DEBUG_KMEMLEAK=y is what broke me. Without that, everything is lovely! :) I can reproduce it now with: $ make defconfig kvm_guest.config $ ./scripts/config -e CONFIG_MEM_ALLOC_PROFILING -e CONFIG_DEBUG_KMEMLEAK -Kees -- Kees Cook