From: Christoph Hellwig <hch@lst.de>
To: akpm@linux-foundation.org, osalvador@suse.de
Cc: elver@google.com, vbabka@suse.cz, andreyknvl@gmail.com,
linux-mm@kvack.org, djwong@kernel.org, david@fromorbit.com,
linux-xfs@vger.kernel.org
Subject: [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list
Date: Mon, 29 Apr 2024 10:28:28 +0200 [thread overview]
Message-ID: <20240429082828.1615986-1-hch@lst.de> (raw)
Otherwise we'll generate false lockdep positives.
Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Changes since v1:
- only pass on __GFP_NOLOCKDEP and leave the other masking in place
mm/page_owner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_owner.c b/mm/page_owner.c
index d17d1351ec84af..428c1ea8b4579e 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -170,7 +170,7 @@ static void add_stack_record_to_list(struct stack_record *stack_record,
/* Filter gfp_mask the same way stackdepot does, for consistency */
gfp_mask &= ~GFP_ZONEMASK;
- gfp_mask &= (GFP_ATOMIC | GFP_KERNEL);
+ gfp_mask &= (GFP_ATOMIC | GFP_KERNEL | __GFP_NOLOCKDEP);
gfp_mask |= __GFP_NOWARN;
set_current_in_page_owner();
--
2.39.2
next reply other threads:[~2024-04-29 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 8:28 Christoph Hellwig [this message]
2024-04-29 8:32 ` [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list Vlastimil Babka
2024-04-29 9:33 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429082828.1615986-1-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=elver@google.com \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).