From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C420AC4345F for ; Mon, 29 Apr 2024 17:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C7F56B0085; Mon, 29 Apr 2024 13:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2511B6B0087; Mon, 29 Apr 2024 13:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F2756B0088; Mon, 29 Apr 2024 13:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E53456B0085 for ; Mon, 29 Apr 2024 13:50:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 60128402FA for ; Mon, 29 Apr 2024 17:50:25 +0000 (UTC) X-FDA: 82063308810.13.887A83F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 46C38140002 for ; Mon, 29 Apr 2024 17:50:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BWOvB6Tk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714413022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=483r4WzbrapV4XCoMfk69TwtljEl6ez9+VPWc5SjPqg=; b=cOnDvanfaHHK/WDeeKDLC+hw5wcpLMRLdBbX7IRy67bLgISZgFvf2OKF6TUDLsvdoGb6iY Yacdu20n5x/Y/wWAs5NTu9Fy2t2VQe7dQffntzsYF98ifhPSJK2uy1tYhBt9ZjBnGwBqqm FUnhhtWHIJoigCmJOmP/R+1y0NVqRLI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BWOvB6Tk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714413022; a=rsa-sha256; cv=none; b=25F68yETfwFg6fqhWDFD/zRVw1xmsxVrubhuWHRNc6QN7CDm7bEdsraRrjt69/bowRCJ/k sGJMK3RvHhouITocOQlBK4QPpP1KynDC5O8D/F8ml3Df8dzRVeSngn3Qq7/d11PxBVCQ2V SjOAzhrF1EY6qPyQXdijaenLwND1lcg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1608DCE0284; Mon, 29 Apr 2024 17:50:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45D26C113CD; Mon, 29 Apr 2024 17:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714413017; bh=lUgtS8c+FCW6wGfLKkpejhCuu9OnmDAw7IJtwTpXqDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWOvB6TkhRcCMweJ1Ks8b8uPzwsNbM4diq5jX9SZu/0bRm+MFitwLaCLMey0zT6aA fq+IWTvb9Q3NiRtRU5dW3vOJCP1g5bEQ/p9aHwdscYIhzByC3Gn5VubEoY2OxsPPbh xenJ4prcEKVpzOtzNufHptYggOn3KweNOVmARGtoTumqaP6ehE+QTem/fK18Vxdcql SdJxwBNC1Ao/YZLAIz+xULkIyERBb+wW5grcWK2kDHejrCGd7cBR7CBwj9/vnAkGsm LcHRmmLzCk3g3DEi79ZQNJss1WzFmkyi2Hvxh7sjYePNDuoROvQYQ8Cps2u4WvBoQT lZPdIdiiVkshA== Date: Mon, 29 Apr 2024 18:48:42 +0100 From: Simon Horman To: Jesper Dangaard Brouer Cc: tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, yosryahmed@google.com, longman@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, shakeel.butt@linux.dev, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior , mhocko@kernel.org Subject: Re: [PATCH v1 1/3] cgroup/rstat: add cgroup_rstat_lock helpers and tracepoints Message-ID: <20240429174842.GF516117@kernel.org> References: <171328983017.3930751.9484082608778623495.stgit@firesoul> <171328988660.3930751.17537768209042139758.stgit@firesoul> <20240423165350.GY42092@kernel.org> <21dd3b6e-6e7b-4dcb-9050-4d63fc810749@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21dd3b6e-6e7b-4dcb-9050-4d63fc810749@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 46C38140002 X-Stat-Signature: sopeoqqqhjq3ruwx99pngee887ip6qpy X-HE-Tag: 1714413021-860871 X-HE-Meta: U2FsdGVkX1/7qc1llrgDt89CS1wAXy9xgxFo0mY9jSe66vxBoWgcsyiDqw3OtGQcRwQfS0H07FHR9Nc+bFa4uozXkYGx/ODROHbHWLnLXCsp3Ox2Tj5zQYTnImByGY1GO4WHmzMyxaaE0n6JXnE/NUXq9BpmE1RfpA9vFD3oEPAv3pTriHnmOySYbss+ghBrEDbe3RLTsndup8JaIC0tT7FoQCuhiUQGWfP0GveX8s0BvsUFb2bQLQ29rVX3W6RemHdnIV1yKe1wfsGuAwhdR8ZtB2i2RuDColR+IJ5TLq7wqu/ALv3T9m79lzE2DvzW3SARYkmv04Go7cO1labZw+fUF8wOa6/EmOs8pETGqP8oVpL+Ntu9d6Gc1K41qc1g7/1t8n2UVN/6CednvO/jNIdh/DP0A56XljI6C9xYVKTq/bKX37PCqIO6tFUa6nwKI5O/RtQyLTiPLYJv0xRw6pEDvLHMy1qgRZU2RjosDCqgfdKTBV+9bA3Vbx6Q1OxPrr5sSQ31yWjBkzjjBW/IXAE/wsTq+ut/phzSL5XtaQUR37WajnpDQAStEqlCHdFM5tMu5FEd/0JOtCheapW/2vEjQW+Zr7QGbcEv4+K+y/hONeoia+poZnG8wdj1E5K9XKu8EiLyV5LyQtHt9bUwGbmJSNNz0MQLVRmIzLeVo3cm7EmUNIC8VyVfjNrLEAM5eafs0qaw1s0OcwC+nX/K9O3dnvwyb+ctlq4mB/Jzbitv7qW5ZuccPyaFO3kyJbtm/cJ7j5u4fK5wlJoKQWlEO5B0shy8g75MAOwtEtQGV8LTmxTSLFERdfVI4/itGnSsCq9ORwtoGoCdttVOgcXWkBnLD0nSrVQz8ZqGDJMpoLsrmE6eMpQMlEFzGIFzdh7mjhzrX5RwidxwEGGv9G3M4YbcbRtNxoHjcHRHGTKqDK7huUe/X0Z0002eDZI0PlSmU1BXZwBfDQUi8ov0KFZ Wij6jFZF 9fMd1t9jc58B6dlfM2nUHPvNhYUbWsYpfTc+gJBXwmSVTeTIsPWES3m0jGzESdPI4hqGvg0U/Czliu5RPNp4zM3geRMUj8cnKk/SrNUutbfuc9IqND/6gpUk/xoH1wRQZe+7diWab3M+Pfqqfr3170+z6u/dcNU3LVwc2wX+oaYZch3e4nWMozb4dcprGhU3+naguIcM7mykd2dvwbtyjyhsVMLVz7JNlRUOnTI/SODfoLLXn1WLRxa8BloQDMbMUMhQGdhRcA/zdk+E6yZDgw6WNsr2bHZfLWsUPVbzhvY02PNemiweZpHM19VMGmG00Tuod4D+ylCyic93B1k8Mh4PudVj0xoq/tXmZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 01:36:20PM +0200, Jesper Dangaard Brouer wrote: > > > On 23/04/2024 18.53, Simon Horman wrote: > > On Tue, Apr 16, 2024 at 07:51:26PM +0200, Jesper Dangaard Brouer wrote: > > > > ... > > > > > /** > > > * cgroup_rstat_flush_release - release cgroup_rstat_flush_hold() > > > */ > > > > Hi Jesper, > > > > as a follow-up could you add an entry for cgrp to the kernel doc above? > > > > Already fixed in TJ's tree for-6.10 > - https://lore.kernel.org/cgroups/ZiB97v73Fr-wq14f@slm.duckdns.org/ > - https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git/commit/?h=for-6.10&id=97a46a66ad7d9126 > > But thanks Simon for your vigilance in noticing these things :-) Thanks Jesper, I appreciate you letting me know :)