From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8125DC4345F for ; Mon, 29 Apr 2024 20:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 189266B0095; Mon, 29 Apr 2024 16:20:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13A5F6B0096; Mon, 29 Apr 2024 16:20:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 000FB6B0098; Mon, 29 Apr 2024 16:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D5A0F6B0095 for ; Mon, 29 Apr 2024 16:20:47 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CD85120383 for ; Mon, 29 Apr 2024 20:20:47 +0000 (UTC) X-FDA: 82063687734.27.B48C2D1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id CF259C0013 for ; Mon, 29 Apr 2024 20:20:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Uo8u/OKv"; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714422045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c9Ut2LS/Ih17iR+t7RKv3UDiE+5PTmDRlw/NTx3koDQ=; b=IbdsjIMv1JJHhmUAu+zjAtfYPcyS8DFdxSijPkCKzexgpD1SFqAth1JZXVzoMk43JnUoGr PqCzv7qGAOy4DeOTk8OqJTQjUUksYCSeGd57t/BQEJPhhCqtzpm7SSTTg9G34x+ZDBbVt6 fWVwdnQkb/lB2kVcb5692DxLzHXxTNU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Uo8u/OKv"; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714422045; a=rsa-sha256; cv=none; b=Xq8u4J5sJ+ntHBYBdWWFaxYviKcKv9+pxysiZNm+a9AHKCu/lNfFmy4aBAcGlrTucFFUGG zzEDUGRxy6ZJ0DmFKaQnS8RFshljfBWYWdVPhY7I/b2nAhXnjt2ojgIKryGbt7UZgCQFeZ AC+KPCcjmWdUWEhEsrbiwdTV2CMcM5M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B8FE261083; Mon, 29 Apr 2024 20:20:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4EBDC4AF18; Mon, 29 Apr 2024 20:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714422043; bh=wPkf1AvhBcq0B1qbhRRs+Vbu1NpYyvhkCNxOzOM6p18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uo8u/OKvUVKxZhfhuQUBaKTDZlofaBJv5TyfDGjuVGenTpku0rm16lDKssLOaDLQ2 4VLRD6e4or/raRlyHJSKyqSR0Q98es7hIcLhJTyEGGxWdKp+vvQ8nCqy6Bz9DQoAXg C1Ngu4aUxv0LlMbvpoPxAjUqkTZrbDsTgOss5Vrwnl661WFadpsPkztL1oWC1OlN3+ 3pjRec0V6xxIQevVSwsvGjQaWEmGNqhsws0wew0f5UrNDhmtjqkztrRgTkSKryoA85 97ZHY6mo7rzY2QusBP32qZjAp2dzXqq79nxmvWlR8l4weUVFvD6KHfmTtRWYJnyzVf zPDkgyKouv7tQ== From: SeongJae Park To: Lance Yang Cc: SeongJae Park , akpm@linux-foundation.org, willy@infradead.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop Date: Mon, 29 Apr 2024 13:20:40 -0700 Message-Id: <20240429202040.187453-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240429132308.38794-3-ioworker0@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 75d5633qcp87bn3rtwgq9u16phffaq3w X-Rspamd-Queue-Id: CF259C0013 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714422044-705277 X-HE-Meta: U2FsdGVkX1/4CtWu+IwU4zyGVErYlq3FKDLA+H10nMtZig/zI2VUCRulmPuZAYWkew0ywC3j9UIvyHdDyUHMUUg8LFHSO8o0tCS+T4ufOn8cMYAkZRq8bG5NP0TQLmzKSIJ9AEaFws5A1llXiWBY69us6z4arYyKOQ+yWo5mUc3KK/fzssNsXvr8jvi80uwu1i3hb2m11P+UCyS0hsNoQvrMWbX7mSmBz6Y6sW6Bu3GQnIT1V2a5VklJsJlKQgEwyP4EI9a1/W8ByvywF/zJ1uE3QSe7TYlQH6l50Z2yrWQyTTb6ny/wch5b5OFJ5HxzlCkomyEnQdxoBbRQq41khGxIFT78XTo50UNH4bWBXa0fHp/gqL1FtsbZeqN/h/X+7RNdDjKfkvNbj5/9aqsg9F34FGhY+0e7n2yOiw4klVh/qVHtEH1ewhP0y584OrPItaQtzKKsYflVUh3qqIv+7LeW+07bs4Fa8fmWrWbGCakCzLbMRfGt1WHIupzB1EsduDTWlXgyPmZVr89i+KM1m/b2RAK+1GCY62ShltXGRVXBqd6vJcL9O8YjWR3BeMoKcOi23777RWiy0kgqLIslVRb710oXmnWAAa/TwCiG2rWQiLJvFqssI4ZloltfJC/rRGfPVweH94X8bKsrdYFsqbhDIJVXiY1hokAnTPCjlZKCiwAX+e1AagGTzcXpjjFUBrxNapwrDKKo9aUfZ0WuK80s/2KiONMEOy/2jtBbmM5jFKu0xb6yrFeMp+TQps/gAz5NQZ8bL3wquaCEYE03RVp/qV6ZDF2evNHUAOXtLNZSWykTJpn60eAKCnzObrK3ByFY0IumBsgj1V84EFui+F6A52mHyRFRfoAtG/PnOzuUt5iy2OySv/4SS8pnb0Yz5Dtv8cyStkF8t6qKyYlvucstuXiPMNCD1PVndHFlI2DK4HcgBotTEMJ3NTeN89vcZ39kiihMuc1WLpDlwBc HPbee0sO X+AhXm8FYld9Cn+HLO6jhDtlKO0S1JDiBmu1UE+55iSJov+TUU6cPuq/7bR1kaxQrEWJQSRW0I3wEEQaPisScI7JD7rC/PBhQEoY2y5T8FZFaFfCb6cyJ2RCDX5It8rHJ5OXp60Zeu8HWRy8ivqJE5KYVjv14k40UddEc4C1kCrhdnrxE/i9uBJAwQNjJRbscV+xxQ78fnE/aD5VebMCkIW+EumG0xqqxsawEQXwzFxcFQisHrO2hNL0/Boc5MJOvdIya X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lance, On Mon, 29 Apr 2024 21:23:07 +0800 Lance Yang wrote: > In preparation for supporting try_to_unmap_one() to unmap PMD-mapped > folios, start the pagewalk first, then call split_huge_pmd_address() > to split the folio. > > Suggested-by: David Hildenbrand > Signed-off-by: Lance Yang > --- > include/linux/huge_mm.h | 2 ++ > mm/huge_memory.c | 42 +++++++++++++++++++++-------------------- > mm/rmap.c | 26 +++++++++++++++++++------ > 3 files changed, 44 insertions(+), 26 deletions(-) > [...] > diff --git a/mm/rmap.c b/mm/rmap.c > index 7e2575d669a9..e42f436c7ff3 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1636,9 +1636,6 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > if (flags & TTU_SYNC) > pvmw.flags = PVMW_SYNC; > > - if (flags & TTU_SPLIT_HUGE_PMD) > - split_huge_pmd_address(vma, address, false, folio); > - > /* > * For THP, we have to assume the worse case ie pmd for invalidation. > * For hugetlb, it could be much worse if we need to do pud > @@ -1650,6 +1647,10 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > range.end = vma_address_end(&pvmw); > mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm, > address, range.end); > + if (flags & TTU_SPLIT_HUGE_PMD) { > + range.start = address & HPAGE_PMD_MASK; > + range.end = (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE; > + } I found the latest mm-unstable fails one[1] of my build configuration with below error message. And 'git bisect' points this patch. CC mm/rmap.o In file included from : .../linux/mm/rmap.c: In function 'try_to_unmap_one': .../linux/include/linux/compiler_types.h:460:38: error: call to '__compiletime_assert_455' declared with attribute error: BUILD_BUG failed 460 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ .../linux/include/linux/compiler_types.h:441:4: note: in definition of macro '__compiletime_assert' 441 | prefix ## suffix(); \ | ^~~~~~ .../linux/include/linux/compiler_types.h:460:2: note: in expansion of macro '_compiletime_assert' 460 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ .../linux/include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ .../linux/include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ .../linux/include/linux/huge_mm.h:97:28: note: in expansion of macro 'BUILD_BUG' 97 | #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) | ^~~~~~~~~ .../linux/include/linux/huge_mm.h:104:34: note: in expansion of macro 'HPAGE_PMD_SHIFT' 104 | #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) | ^~~~~~~~~~~~~~~ .../linux/include/linux/huge_mm.h:103:27: note: in expansion of macro 'HPAGE_PMD_SIZE' 103 | #define HPAGE_PMD_MASK (~(HPAGE_PMD_SIZE - 1)) | ^~~~~~~~~~~~~~ .../linux/mm/rmap.c:1651:27: note: in expansion of macro 'HPAGE_PMD_MASK' 1651 | range.start = address & HPAGE_PMD_MASK; | ^~~~~~~~~~~~~~ I haven't looked into the code yet, but seems this code need to handle CONFIG_PGTABLE_HAS_HUGE_LEAVES undefined case? May I ask your opinion? [1] https://github.com/awslabs/damon-tests/blob/next/corr/tests/build_arm64.sh Thanks, SJ [...]