linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joey Gouly <joey.gouly@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org,
	aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org,
	catalin.marinas@arm.com, christophe.leroy@csgroup.eu,
	dave.hansen@linux.intel.com, hpa@zytor.com, joey.gouly@arm.com,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com,
	mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com,
	npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org,
	szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org,
	x86@kernel.org, kvmarm@lists.linux.dev
Subject: [PATCH v4 24/29] selftests: mm: move fpregs printing
Date: Fri,  3 May 2024 14:01:42 +0100	[thread overview]
Message-ID: <20240503130147.1154804-25-joey.gouly@arm.com> (raw)
In-Reply-To: <20240503130147.1154804-1-joey.gouly@arm.com>

arm64's fpregs are not at a constant offset from sigcontext. Since this is
not an important part of the test, don't print the fpregs pointer on arm64.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
---
 tools/testing/selftests/mm/pkey-powerpc.h    | 1 +
 tools/testing/selftests/mm/pkey-x86.h        | 2 ++
 tools/testing/selftests/mm/protection_keys.c | 6 ++++++
 3 files changed, 9 insertions(+)

diff --git a/tools/testing/selftests/mm/pkey-powerpc.h b/tools/testing/selftests/mm/pkey-powerpc.h
index ae5df26104e5..6275d0f474b3 100644
--- a/tools/testing/selftests/mm/pkey-powerpc.h
+++ b/tools/testing/selftests/mm/pkey-powerpc.h
@@ -9,6 +9,7 @@
 #endif
 #define REG_IP_IDX		PT_NIP
 #define REG_TRAPNO		PT_TRAP
+#define MCONTEXT_FPREGS
 #define gregs			gp_regs
 #define fpregs			fp_regs
 #define si_pkey_offset		0x20
diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftests/mm/pkey-x86.h
index 814758e109c0..b9170a26bfcb 100644
--- a/tools/testing/selftests/mm/pkey-x86.h
+++ b/tools/testing/selftests/mm/pkey-x86.h
@@ -15,6 +15,8 @@
 
 #endif
 
+#define MCONTEXT_FPREGS
+
 #ifndef PKEY_DISABLE_ACCESS
 # define PKEY_DISABLE_ACCESS	0x1
 #endif
diff --git a/tools/testing/selftests/mm/protection_keys.c b/tools/testing/selftests/mm/protection_keys.c
index 48dc151f8fca..b3dbd76ea27c 100644
--- a/tools/testing/selftests/mm/protection_keys.c
+++ b/tools/testing/selftests/mm/protection_keys.c
@@ -314,7 +314,9 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext)
 	ucontext_t *uctxt = vucontext;
 	int trapno;
 	unsigned long ip;
+#ifdef MCONTEXT_FPREGS
 	char *fpregs;
+#endif
 #if defined(__i386__) || defined(__x86_64__) /* arch */
 	u32 *pkey_reg_ptr;
 	int pkey_reg_offset;
@@ -330,7 +332,9 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext)
 
 	trapno = uctxt->uc_mcontext.gregs[REG_TRAPNO];
 	ip = uctxt->uc_mcontext.gregs[REG_IP_IDX];
+#ifdef MCONTEXT_FPREGS
 	fpregs = (char *) uctxt->uc_mcontext.fpregs;
+#endif
 
 	dprintf2("%s() trapno: %d ip: 0x%016lx info->si_code: %s/%d\n",
 			__func__, trapno, ip, si_code_str(si->si_code),
@@ -359,7 +363,9 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext)
 #endif /* arch */
 
 	dprintf1("siginfo: %p\n", si);
+#ifdef MCONTEXT_FPREGS
 	dprintf1(" fpregs: %p\n", fpregs);
+#endif
 
 	if ((si->si_code == SEGV_MAPERR) ||
 	    (si->si_code == SEGV_ACCERR) ||
-- 
2.25.1



  parent reply	other threads:[~2024-05-03 13:03 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 13:01 [PATCH v4 00/29] arm64: Permission Overlay Extension Joey Gouly
2024-05-03 13:01 ` [PATCH v4 01/29] powerpc/mm: add ARCH_PKEY_BITS to Kconfig Joey Gouly
2024-05-06  8:57   ` Michael Ellerman
2024-05-03 13:01 ` [PATCH v4 02/29] x86/mm: " Joey Gouly
2024-05-03 16:40   ` Dave Hansen
2024-05-03 13:01 ` [PATCH v4 03/29] mm: use ARCH_PKEY_BITS to define VM_PKEY_BITN Joey Gouly
2024-05-03 16:41   ` Dave Hansen
2024-07-15  7:53   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 04/29] arm64: disable trapping of POR_EL0 to EL2 Joey Gouly
2024-07-15  7:47   ` Anshuman Khandual
2024-07-25 15:44   ` Dave Martin
2024-08-06 10:04     ` Joey Gouly
2024-05-03 13:01 ` [PATCH v4 05/29] arm64: cpufeature: add Permission Overlay Extension cpucap Joey Gouly
2024-06-21 16:58   ` Catalin Marinas
2024-06-21 17:01   ` Catalin Marinas
2024-06-21 17:02     ` Catalin Marinas
2024-07-15  7:47   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 06/29] arm64: context switch POR_EL0 register Joey Gouly
2024-06-21 17:03   ` Catalin Marinas
2024-06-21 17:07   ` Catalin Marinas
2024-07-15  8:27   ` Anshuman Khandual
2024-07-16 13:21     ` Mark Brown
2024-07-18 14:16     ` Joey Gouly
2024-07-22 13:40   ` Kevin Brodsky
2024-07-25 15:46   ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 07/29] KVM: arm64: Save/restore POE registers Joey Gouly
2024-05-29 15:43   ` Marc Zyngier
2024-08-16 14:55   ` Marc Zyngier
2024-08-16 15:13     ` Joey Gouly
2024-08-16 15:32       ` Marc Zyngier
2024-05-03 13:01 ` [PATCH v4 08/29] KVM: arm64: make kvm_at() take an OP_AT_* Joey Gouly
2024-05-29 15:46   ` Marc Zyngier
2024-07-15  8:36   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 09/29] KVM: arm64: use `at s1e1a` for POE Joey Gouly
2024-05-29 15:50   ` Marc Zyngier
2024-07-15  8:45   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 10/29] arm64: enable the Permission Overlay Extension for EL0 Joey Gouly
2024-06-21 17:04   ` Catalin Marinas
2024-07-15  9:13   ` Anshuman Khandual
2024-07-15 20:16   ` Mark Brown
2024-07-25 15:49   ` Dave Martin
2024-08-01 16:04     ` Joey Gouly
2024-08-01 16:31       ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 11/29] arm64: re-order MTE VM_ flags Joey Gouly
2024-06-21 17:04   ` Catalin Marinas
2024-07-15  9:21   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 12/29] arm64: add POIndex defines Joey Gouly
2024-06-21 17:05   ` Catalin Marinas
2024-07-15  9:26   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 13/29] arm64: convert protection key into vm_flags and pgprot values Joey Gouly
2024-05-28  6:54   ` Amit Daniel Kachhap
2024-06-19 16:45     ` Catalin Marinas
2024-07-04 12:47       ` Joey Gouly
2024-07-08 17:22         ` Catalin Marinas
2024-07-16  9:05   ` Anshuman Khandual
2024-07-16  9:34     ` Joey Gouly
2024-07-25 15:49   ` Dave Martin
2024-08-01 10:55     ` Joey Gouly
2024-08-01 11:01       ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 14/29] arm64: mask out POIndex when modifying a PTE Joey Gouly
2024-07-16  9:10   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 15/29] arm64: handle PKEY/POE faults Joey Gouly
2024-06-21 16:57   ` Catalin Marinas
2024-07-09 13:03   ` Kevin Brodsky
2024-07-16 10:13   ` Anshuman Khandual
2024-07-25 15:57   ` Dave Martin
2024-08-01 16:01     ` Joey Gouly
2024-08-06 13:33       ` Dave Martin
2024-08-06 13:43         ` Joey Gouly
2024-08-06 14:38           ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 16/29] arm64: add pte_access_permitted_no_overlay() Joey Gouly
2024-06-21 17:15   ` Catalin Marinas
2024-07-16 10:21   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 17/29] arm64: implement PKEYS support Joey Gouly
2024-05-28  6:55   ` Amit Daniel Kachhap
2024-05-28 11:26     ` Joey Gouly
2024-05-31 14:57   ` Szabolcs Nagy
2024-05-31 15:21     ` Joey Gouly
2024-05-31 16:27       ` Szabolcs Nagy
2024-06-17 13:40         ` Florian Weimer
2024-06-17 14:51           ` Szabolcs Nagy
2024-07-08 17:53             ` Catalin Marinas
2024-07-09  8:32               ` Szabolcs Nagy
2024-07-09  8:52                 ` Florian Weimer
2024-07-11  9:50               ` Joey Gouly
2024-07-18 14:45                 ` Szabolcs Nagy
2024-07-05 16:59   ` Catalin Marinas
2024-07-22 13:39     ` Kevin Brodsky
2024-07-09 13:07   ` Kevin Brodsky
2024-07-16 11:40     ` Anshuman Khandual
2024-07-23  4:22   ` Anshuman Khandual
2024-07-25 16:12   ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 18/29] arm64: add POE signal support Joey Gouly
2024-05-28  6:56   ` Amit Daniel Kachhap
2024-05-31 16:39     ` Mark Brown
2024-06-03  9:21       ` Amit Daniel Kachhap
2024-07-25 15:58         ` Dave Martin
2024-07-25 18:11           ` Mark Brown
2024-07-26 16:14             ` Dave Martin
2024-07-26 17:39               ` Mark Brown
2024-07-29 14:27                 ` Dave Martin
2024-07-29 14:41                   ` Mark Brown
2024-07-05 17:04   ` Catalin Marinas
2024-07-09 13:08   ` Kevin Brodsky
2024-07-22  9:16   ` Anshuman Khandual
2024-07-25 16:00   ` Dave Martin
2024-08-01 15:54     ` Joey Gouly
2024-08-01 16:22       ` Dave Martin
2024-08-06 10:35         ` Joey Gouly
2024-08-06 14:31           ` Joey Gouly
2024-08-06 15:00             ` Dave Martin
2024-08-14 15:03             ` Catalin Marinas
2024-08-15 13:18               ` Joey Gouly
2024-08-15 15:09                 ` Dave Martin
2024-08-15 15:24                   ` Mark Brown
2024-08-19 17:09                   ` Catalin Marinas
2024-08-20  9:54                     ` Joey Gouly
2024-08-20 13:54                       ` Dave Martin
2024-08-20 14:06                         ` Joey Gouly
2024-08-20 14:45                           ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 19/29] arm64: enable PKEY support for CPUs with S1POE Joey Gouly
2024-07-16 10:47   ` Anshuman Khandual
2024-07-25 15:48     ` Dave Martin
2024-07-25 16:00   ` Dave Martin
2024-05-03 13:01 ` [PATCH v4 20/29] arm64: enable POE and PIE to coexist Joey Gouly
2024-06-21 17:16   ` Catalin Marinas
2024-07-16 10:41   ` Anshuman Khandual
2024-07-16 13:46     ` Joey Gouly
2024-05-03 13:01 ` [PATCH v4 21/29] arm64/ptrace: add support for FEAT_POE Joey Gouly
2024-07-16 10:35   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 22/29] arm64: add Permission Overlay Extension Kconfig Joey Gouly
2024-07-05 17:05   ` Catalin Marinas
2024-07-09 13:08   ` Kevin Brodsky
2024-07-16 11:02   ` Anshuman Khandual
2024-05-03 13:01 ` [PATCH v4 23/29] kselftest/arm64: move get_header() Joey Gouly
2024-05-03 13:01 ` Joey Gouly [this message]
2024-05-03 13:01 ` [PATCH v4 25/29] selftests: mm: make protection_keys test work on arm64 Joey Gouly
2024-05-03 13:01 ` [PATCH v4 26/29] kselftest/arm64: add HWCAP test for FEAT_S1POE Joey Gouly
2024-05-03 13:01 ` [PATCH v4 27/29] kselftest/arm64: parse POE_MAGIC in a signal frame Joey Gouly
2024-05-03 13:01 ` [PATCH v4 28/29] kselftest/arm64: Add test case for POR_EL0 signal frame records Joey Gouly
2024-05-29 15:51   ` Mark Brown
2024-07-05 19:34     ` Shuah Khan
2024-07-09 13:10   ` Kevin Brodsky
2024-05-03 13:01 ` [PATCH v4 29/29] KVM: selftests: get-reg-list: add Permission Overlay registers Joey Gouly
2024-05-05 14:41 ` [PATCH v4 00/29] arm64: Permission Overlay Extension Mark Brown
2024-05-28 11:30 ` Joey Gouly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240503130147.1154804-25-joey.gouly@arm.com \
    --to=joey.gouly@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@kernel.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maz@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=oliver.upton@linux.dev \
    --cc=shuah@kernel.org \
    --cc=szabolcs.nagy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).