From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A2CBC25B10 for ; Mon, 13 May 2024 08:29:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DA676B020F; Mon, 13 May 2024 04:29:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 089C86B0213; Mon, 13 May 2024 04:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBA8C6B0248; Mon, 13 May 2024 04:29:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CEE5C6B020F for ; Mon, 13 May 2024 04:29:47 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 726041A0CD0 for ; Mon, 13 May 2024 08:29:47 +0000 (UTC) X-FDA: 82112699214.14.3EA57E1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 94EFE4001D for ; Mon, 13 May 2024 08:29:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715588986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=K5weZYDlM9HYwC/58QwF7EZSftYlvZYQrfkF/WhlHWk=; b=Eayxp6V7teW9mJQ4pxxb8cyqi2CFPBTrZmvHE2T/rDBERqegWVGP9zpZYhTIc0hUnOS1Zz pm+26aFE1FdW1ViY5I82ZzyKuWub37qg17pS/r7o5z/dVMqft37Kp+JAurpkzqHQOp0T/0 bISB5F+SzHYu6Kwcu1sBEVSYvc8YpII= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715588986; a=rsa-sha256; cv=none; b=kaynk9c212LqwOYHZSFglOE0LMpiRdMsB6v+3G6RpQI/f2K2S0i09/63xLT6i+I4bV8ncg rNUCF+jvc8Me09F1BIy58hNZb03zaY2Z35mxRomxcq3x8xc/Ztwozdt6hHC2Z2tHW/NSa2 pTIhc8zq6aD3Tb63P8ENqzXJkcpNHzs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F19F21007; Mon, 13 May 2024 01:30:09 -0700 (PDT) Received: from e116581.blr.arm.com (e116581.arm.com [10.162.42.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4A3493F7A6; Mon, 13 May 2024 01:29:42 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com, Dev Jain Subject: [PATCH] selftests/mm: compaction_test: Fix trivial test pass on Aarch64 when nr_hugepages = 0 Date: Mon, 13 May 2024 13:58:42 +0530 Message-Id: <20240513082842.4117782-1-dev.jain@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 94EFE4001D X-Stat-Signature: tatnf6z4ccqk3iaaxx3opm9d8fpao9qo X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1715588985-999129 X-HE-Meta: U2FsdGVkX1/uhBdOdVmgCqiQ0iavjCovCGYQNy/x+Q1OZe9jnRJ73g9DnpqSR5p789eIfMifvOGzAUjUcf7ufwFIhs8iizqFYpdrIgo1+FtNya5r8OGIrmMyQ3VvlPjbrmpJ6P+3fgbyJ4SLqKPayD5VSPDVZeOSUQC2L0FZ1cJhI0J+WTVTHQP/+8eqLq5j9F2Im3t2aQjaZVV7jgVXlwaRnJihAblXBfYYH1cDrqfJhdYfWQF6WtFO8zwW909n3a87LQoaDWheuNVm8nUt1qvXoAUyHhgkrNLL49AO/HLOQS33z3Ouz8aoEOk+IhoeDPQ0jmG/73FD762PTLM1j4M9goofIzbMFqpUbqAt1RHomcE32KnLkhE+9WeuPzc35EDud9m+Qth2o68vGFgqortMnZBCTTyYI+0C9pjMEKX/yuXIk9jdmFzpGALjXC8NDthECxouixZbF2g89YH35C9iov9OJX1x3EWvCkdEcnYLb+hJDKEx1azdEqJQUswmM0e2RqfO4Lr/QOWfJIbng0jH3f1ilbUJdvtrBoOi4THWtUAuxVnGyAmR7Tna1076STPYta81KJQ55pbBDrrU7ip1VSzDoVWPuxY0JV9Du2ugY7qG3Q2Fvn88RoSVtqDhdGDL2WmW09uO5BERbfVKaRwEogncRTBrFr1jz9XJZHRLZRYNYWvN7Js6MesOiSJm0AosFN69MoRWcmIrXBcsv0eAoyq38uPYYl7dzZL7OC2qBas+8/wIp5G5VwIzzEwX4P/amCbroUaxfgvSLQmYmRN5ewy8Q+JR4CXU7jeeRcBD4sr+Yi0jGbjN9A2VWqfkywT6uiWhEIHR99/fzF3GFmdp4NoObM2XOoug8gM9UzpKZCgEuuesQU0z+/1HNslKCtIxrZZD4RRsmFqe8cEIXJeYz5QNTpaetGPjKUQNnaAxmnZvXSOSMauOUb58ERFWQIvARQqrX+pmLWuFhdK +Dyp+1OW 1kQkUJUsBtmCnp2B5uhSA4qYX0kAn5f2aaSF1Q2Naev9O2i/qljzmE4ySeoBxAVBbqCNLRkWsAHCoeSQUs8Bt6qCq1IANc0xXve2ENg1AEqL6JzvaBGWl+FViWcs+wd19vuhR8L1TOdJ0xwj7FtzTRsKMgyHYy8KTcwRLFyYOqaUo6dr2FnRQQG1z4oKeLBt5JLy2FAkdv43EFu4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, if at runtime we are not able to allocate a huge page, the test will trivially pass on Aarch64 due to no exception being raised on division by zero while computing compaction_index. Fix that by checking for nr_hugepages == 0. Anyways, in general, avoid a division by zero by exiting the program beforehand. While at it, fix a typo. Signed-off-by: Dev Jain --- tools/testing/selftests/mm/compaction_test.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/selftests/mm/compaction_test.c index 533999b6c284..df1b76f9c734 100644 --- a/tools/testing/selftests/mm/compaction_test.c +++ b/tools/testing/selftests/mm/compaction_test.c @@ -134,6 +134,10 @@ int check_compaction(unsigned long mem_free, unsigned int hugepage_size) /* We should have been able to request at least 1/3 rd of the memory in huge pages */ + if (!atoi(nr_hugepages)) { + ksft_print_msg("ERROR: No memory is available as huge pages\n"); + goto close_fd; + } compaction_index = mem_free/(atoi(nr_hugepages) * hugepage_size); lseek(fd, 0, SEEK_SET); @@ -149,7 +153,7 @@ int check_compaction(unsigned long mem_free, unsigned int hugepage_size) atoi(nr_hugepages)); if (compaction_index > 3) { - ksft_print_msg("ERROR: Less that 1/%d of memory is available\n" + ksft_print_msg("ERROR: Less than 1/%d of memory is available\n" "as huge pages\n", compaction_index); goto close_fd; } -- 2.39.2