From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C17C04FFE for ; Tue, 14 May 2024 12:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B5D76B031E; Tue, 14 May 2024 08:53:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 318316B0320; Tue, 14 May 2024 08:53:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11D846B027E; Tue, 14 May 2024 08:53:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E78226B031A for ; Tue, 14 May 2024 08:53:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07A7F14125E for ; Tue, 14 May 2024 12:53:36 +0000 (UTC) X-FDA: 82116992832.01.613E642 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf30.hostedemail.com (Postfix) with ESMTP id BA76580002 for ; Tue, 14 May 2024 12:53:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715691213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WMrJbiEWpN5NH6F5AoU86xAjAgWYamOSH4B7klexMUE=; b=XWAZHzJKcdbS0PqGNNJhdXl/+hZ/gd5evv5GItrU5qJQkn3K9ZPDQomEAHAEreIOR223Ei obrKMs2vLy5iq0+6IdZCyojsCfv/vqhfFz5npTMZxLgEoX+/pZLhYeKm1aizSyJ2UAgBvA 2zjC8y061kAGgGyIPUPBmPKP3LHCt6Q= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715691213; a=rsa-sha256; cv=none; b=ICLREui3UEHb9G6OFroMaCe1t2jhCWLGwojxXGZWd7W135X0lvevAH0qJY6GJbPJcknjKb WhLL1KU1hf76lzVC6MP9MZhL/BvASB8NrMZnWwCL7aMd/nFSaW8hK4A1+aw7g0hUL839IR s8AAvDFQ2kmRWs1ybSJ3U6Rc53uoTw4= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4Vdx9W27hRz4f3jcs for ; Tue, 14 May 2024 20:53:19 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id E368B1A0D5E for ; Tue, 14 May 2024 20:53:27 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP4 (Coremail) with SMTP id gCh0CgDHzG7EXkNmCyyLMw--.6596S8; Tue, 14 May 2024 20:53:27 +0800 (CST) From: Kemeng Shi To: willy@infradead.org, akpm@linux-foundation.org, tj@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/8] writeback: factor out balance_domain_limits to remove repeated code Date: Tue, 14 May 2024 20:52:52 +0800 Message-Id: <20240514125254.142203-7-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240514125254.142203-1-shikemeng@huaweicloud.com> References: <20240514125254.142203-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgDHzG7EXkNmCyyLMw--.6596S8 X-Coremail-Antispam: 1UD129KBjvJXoW7AFW5ZFyDKF18Jr4UAFy5urg_yoW8XF47pF 4Ikayq9r4DJF17XFn3CFW7u3y3KrZ7ta15Kw1FkwsIvr17Kr1qgFy7ury09F17Ar18Jrn8 AFsFqas7Gw48CFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvEb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUAV Cq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0 rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E 14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7 xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Y z7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7 v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF 1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIx AIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI 42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWI evJa73UjIFyTuYvjxUFgAwUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Queue-Id: BA76580002 X-Stat-Signature: nmxaomqm84bqf4ow5chdqqwx3e1ga4x7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715691212-434759 X-HE-Meta: U2FsdGVkX194ZeRSYaZ4L3GzjjNrU7L0JrfiQs5yQSiap4su3Ki6CQpGRWfhXPn7qT7akbqGkXe+CqmtCwfxw8hc3YhlK9BlRfQdwELG0e5sl8xXzzgUQSDLcf6L3Lg6sIp1AzcX5hvTnVHeu+ESiKOPBjKMwdKg6G9f/MH8ON2o906u5CuHdxTImTvDxP33rFTAiUzTo/F1k5tlI6F2vRrbIaT4zBc+sUwi69N9B9gncpCClM2NAmVi24bFR2iZwHMDmXXfmYnjfcox5P8ScRXEsRYSgR9U/ym195QRc1kv76aZFl9HZLFqa4bWAwvsKeW4GEGqEH50bH9jN/7uG/UOM+lEL2SOH4DE3WK+QGghMpLGSlcSQrIXxfvtV5IglstpK53A2Z3/B3nbGrvdtpCjf2L9tEXro9cmQATtJs3TFhAXBeBiUSfE8KryjkxQSVgFHAiykel5AbIWN/Gvpb/+bRQry7HyGQwv8UT0PVNQl6Vp2kI/c9T76UGMrYN2ZBp6cAllhGK2UAbuW0ln7Qlhsl3cL2IvXIoVw4cpdCdHU4a+4qBc8OE1sKl7AGV2M/5IrGLSJjtGcDuh9dgzezUx9gX3dHAcQFpXDkXB3TzcBYoizJdoa5mpYLAK9r5KhMG31JjHGo9Phx70TVLslKsOhU0dJMRE0Q2O5A4bLYMq+QcuipsRiMvWqhB3rjH5AXritUnsyFEleV7i82/dPxyWNHasPC3W/XdKTEqBWhrgh0sFe7mnGwlmOrFb8sEKaL8Nox9IPQWR6M3nJOWFVFK86figBGrxn3S1z0XYw/3lYZ0HbLvV2Dclqjax1qfpbdPUYzDAKZ26A+Yr8kIUmFvZ39G3mgwuQIqGkKAfafkFupouwJB0Tmia7f0Z2OaOBqPkoo4yiAIEaYsT3vqC6nH6PTTqFJHUmGcR+YWYNBsI2CY2812bhOU/yJ+oDj7lgc8VTJ+qcppKNFySN2d oLa9MwnQ SNXd8NBIA1NU/O1U7FsIC8MyKNlc921J1GYtW5J+fYvEnDyncRFs+48tVfspOKUM8WLBY7K1Y7wD5IarEnaHXcfF1m8AL/K34r2/bx1pnWrJWP8YobGql6Cjvq4MlLYsywdKsArbOM9dhkXa/9tVvtePS5Z3O9hLF3FQ2yZf/rPr6xS0pZKJeqVu3Gf9bxSfKK6Yq8cf9jpSVz+O4JWV7CJbgQq43kOI8u8icKZX4tRlBSJWWsiPpDHyCuJsdcDkT8hiHuPE9ogWu2WBazVXSVLSYfNLRTMF9rjSX3z0zRBAbYo20WOEoi20Gci0lWYc5Tk3MCCLzArbsd1XNUoWV4JxICLtrRkMvHAE7eUL6Suje6UBrDxSIKjluIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Factor out balance_domain_limits to remove repeated code. Signed-off-by: Kemeng Shi Acked-by: Tejun Heo --- mm/page-writeback.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index b9c8db7089ef..97ee5b32b4ef 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1746,6 +1746,14 @@ static void domain_dirty_freerun(struct dirty_throttle_control *dtc, dtc->freerun = dirty <= dirty_freerun_ceiling(thresh, bg_thresh); } +static void balance_domain_limits(struct dirty_throttle_control *dtc, + bool strictlimit) +{ + domain_dirty_avail(dtc, true); + domain_dirty_limits(dtc); + domain_dirty_freerun(dtc, strictlimit); +} + static void wb_dirty_freerun(struct dirty_throttle_control *dtc, bool strictlimit) { @@ -1802,18 +1810,13 @@ static int balance_dirty_pages(struct bdi_writeback *wb, nr_dirty = global_node_page_state(NR_FILE_DIRTY); - domain_dirty_avail(gdtc, true); - domain_dirty_limits(gdtc); - domain_dirty_freerun(gdtc, strictlimit); - + balance_domain_limits(gdtc, strictlimit); if (mdtc) { /* * If @wb belongs to !root memcg, repeat the same * basic calculations for the memcg domain. */ - domain_dirty_avail(mdtc, true); - domain_dirty_limits(mdtc); - domain_dirty_freerun(mdtc, strictlimit); + balance_domain_limits(mdtc, strictlimit); } /* -- 2.30.0