From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB77C25B75 for ; Wed, 15 May 2024 05:07:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC5C8D006E; Wed, 15 May 2024 01:07:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48C8C8D004F; Wed, 15 May 2024 01:07:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 354ED8D006E; Wed, 15 May 2024 01:07:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 15D278D004F for ; Wed, 15 May 2024 01:07:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 984368143F for ; Wed, 15 May 2024 05:07:13 +0000 (UTC) X-FDA: 82119446346.01.0CF927C Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf26.hostedemail.com (Postfix) with ESMTP id A8CAB14000F for ; Wed, 15 May 2024 05:07:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GmMXvWwF; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715749631; a=rsa-sha256; cv=none; b=SOy79qutWHiZWLb41yRwvPmqklIJd+2h8ciXNXFRznxmY3emwzpuYZHCHQKBSJtcegROXq LnAwWQ4Tinl7m9lt3Io/JK1KFpsRNmQl/tu03K+CGxk4T5uL4BT9BnjGqJNCRlRf1IJ388 6JWx2B6/zzRtNrfm2zBbGagXzwkANXY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GmMXvWwF; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715749631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SzRi7BBK8Kzi4+jUS/kWK3iSCsA+f0xRAjzzQIW1Bf8=; b=GjHxAlDotUl6RbHX8gMdM0ltAYO8ABc2Y7m7QzGSJu4TlhdjH1BDJtwRa+YvzOVZCjIJ6G tiyngUTk20ywaoWfFG7ndztyiyDbEejHxFCPEqJfCuZFmSEVK5kd+o3UYXkBsB05KMz/MK oavNWHklbtvAxgbRIW46rzHKruyHv2g= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6f4178aec15so5489026b3a.0 for ; Tue, 14 May 2024 22:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715749630; x=1716354430; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SzRi7BBK8Kzi4+jUS/kWK3iSCsA+f0xRAjzzQIW1Bf8=; b=GmMXvWwFIebqnbKg+IE2QWeI0y8YLtO5eEh9ezLABjRMPaX/DP2HdODaON3AaNJZWP 7hm7Mw7qqDOaYJf/YUhtqXlNVWO1gme19J3QAxfsRPZ6HcMngvblEezS9kKD7WilZ9f0 N8SYCPsfbGQDDMu3DoMcVfFLPzAgn1re7AkOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715749630; x=1716354430; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SzRi7BBK8Kzi4+jUS/kWK3iSCsA+f0xRAjzzQIW1Bf8=; b=Za4y4HMlqzDszsUnpCZJbFzmyUqJ00RRmHBFGvt4F2nAGVf2oGO2tmRT40cvrx96AT H9m0tdHMzXLNrjGyxWwuH6g7ydVhcJM26VOziOF+p9QRuNEnjhdGiq0FlY4p7mZMsyiv xHWM1hvs06hxMEz+t6R/QtZaR+lk2dKmW1pTHGbjdEMlQB5Ap4UUjrTt2nT8giixJyyT xkDem+NyN6PPo5WXhGpp3RPHU0TU4SU0GhE2P3w+1NmfgQTBXJTa8XBlQy0yrGN6d4ue f0RZH5Kplj4uKMGOADIsNkugmGdyIs66R0bd2kirV2Rks4G+Emk5+npzUDqMqcrpX8ht 2gxw== X-Forwarded-Encrypted: i=1; AJvYcCW8B1rGwd129YI4r5+AZbaOFnc9NgYGgdtbLCFefqvueolR+8cCQmv+W3qJsvFDbr7ENQN2LUjm2mU2LgGECACwSNo= X-Gm-Message-State: AOJu0YxDxa1nRU2q6dym0FMmRRW+g4mTe3nWLvOdlg3VWhOK37Y6NXDk HmJe2FKuvwrBCTMtfThcYDNJ3/VN38yozcX3FWzrxwsJcjDt5tMmW7oTkcWIeA== X-Google-Smtp-Source: AGHT+IFzghujq4lUG5F8pX/TiqRbgCGgm0mozqz8fwsdeFoDVeXza7aCH/TT4k7CROrcXZWoBRaIoA== X-Received: by 2002:a05:6a00:4f86:b0:6f3:e6ac:1a3f with SMTP id d2e1a72fcca58-6f4e02ad970mr17673879b3a.11.1715749630446; Tue, 14 May 2024 22:07:10 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:111d:a618:3172:cd5b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2a663aesm10092200b3a.33.2024.05.14.22.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 22:07:09 -0700 (PDT) Date: Wed, 15 May 2024 14:07:05 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: kernel test robot , Andrew Morton , Minchan Kim , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, "linux-block@vger.kernel.org Nick Terrell" Subject: Re: [PATCHv3 02/19] zram: add lzo and lzorle compression backends support Message-ID: <20240515050705.GF950946@google.com> References: <20240508074223.652784-3-senozhatsky@chromium.org> <202405091921.320BxOyE-lkp@intel.com> <20240510053333.GJ8623@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510053333.GJ8623@google.com> X-Rspamd-Queue-Id: A8CAB14000F X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: nkpuydu5684x66f4suek9w64afwwgbtb X-HE-Tag: 1715749631-646327 X-HE-Meta: U2FsdGVkX18z24q75V0S0Jaev+3KIW37SAQq9qiPvIGgULQCEEPsgIZTa98Q22nl1+eLiKEno9Hnpji/R4wPSmzab+fyd1koGWI7pM2sT/3Dz4sRJm1M3+fZgu25F7uyNsBFs2ayqiNa5jWkVbatrDzK7c8dY2OQWy3P0Xz4iq+x0hFrmWAVDraMWZR3eLRG9xywyf0WvwX4hdx8SkRayt88QNEhavr/03wYR9HdVxbSo6P+msMrj76fRi2z55DL10HeN7o5FImJqCUX7euu0+WXawvWBzIHE3dIEh+IwllBtcle6kMSxWST9sFNvQsCbgM0BXzkovSuRqLBpgxEiE3PIFYA8wQA35GXUqS6ZPIwMFz+9t8SdQU+D+taLkBSvAjsV011gs8L3L+zMyIOIfQhCj2DTnL4w8MAssARbwqp+vAOOAyzuESlKSQvf1nZy1/IvkNRipO4H7jPQ54NjElMbcSWaDJPMhHbSiYwab9H6tjgDYuqy5rwf2vFOA1zEteeSppJWQm+p+XM18FfUrDilw+JExiPHSTgcZdyVjsWXbdYTKxSdIPhUzH66rCfmkaUa2H4IVGPdg79NO59PG8xCgpMOty9wdhNkzQmjflikcB0x4mmZoIFZumsGCrJgMq9mL2wQ+F6Xoym1op+pf4J4Bj1Gl25NEIdmvysz3/ngwUSMQTz983Rq+ppoKvFXcL59Cyopc0Q8fifvLmoFHb7KplN9JPloCwsV0r908JWuWeFdoyt7DooWirsiZefTePh9wkHqe3TzLKVhjqqRmHYTgMBm/aYkpHaP8TCAj7HSUPzoDY0xvNraGUWDwaceZ879sAYZGObzAXkLDn2IqOMALaphIGe/oAhW2+rdBH0FUOGuvmuN7WCa7hR+m2+vaVt3MM1O99n42BtXAFmszc8N9o+ZAGZtrxJwQhV7bhxlCKxUD7qJ37kqwi+gYPlH4Ns9YZF3NGzW1jQ4u0 GiwcsGNE FvD7BZ0YclNXIuvyvx8M76LpzQdGLO3ci139qnRhYZr5yvPOg6UE6ADGOATLiqicIjp1G9zQgARfCWLqFHC50lJvROtUTkHYyHEfYmC5KALnBVqdnDLhda7jwr7rVIbbk9aJ2WPtPSjWVQo9eHnTz8HUWuOb865LmGmqHjLG6vkwE3TJZraijV2VF4fsTXRXn3HlKLh0HkJw4M5TEQ8jsdXMlzJdwDRM4juAe1mZ1afap5gTkmzbeIQPYKQvG34p6xLtwM7fTeaegHyvmQyUallycu0YY83n9CJ415pwEVQ3gzHJAgCaQ2H3W7ua/eaRe3OoVFcLPb79LrH46MypsIElhG1sadRfiD8eg+uZCST3x5fW8k4u9bZwCihdaKwQ2dBbVbBE1fFvhenS13ZFJguUfxaa5t6dAsOw/NzQ4dyIGV1do6RPXCScoyYkUj1cjGkS3vnlPg34kBLPpXEFI68SZBvmwTBJPBTA5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/05/10 14:33), Sergey Senozhatsky wrote: > On (24/05/09 19:23), kernel test robot wrote: > > config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240509/202405091921.320BxOyE-lkp@intel.com/config) > [..] > > >> ERROR: modpost: "backend_lzorle" [drivers/block/zram/zram.ko] undefined! > > >> ERROR: modpost: "backend_lzo" [drivers/block/zram/zram.ko] undefined! > > ... and that's how learned that my .config has ZRAM=y This has revealed several problems. First, lz4hc misses one symbol export, an easy fix. Second, zstd misses pretty much all of the advanced c/d dict, c/d ctx API that we need in order to use dicts in a module. I have fixes for both in v4 on this series (I'll Cc Nick on lz4/zstd patches). I think I'll just send out v4 today, simply because there are patches there that we can re-use even if we scratch zram backends and continue using crypto API.