From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F768C25B75 for ; Wed, 15 May 2024 13:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E3676B0088; Wed, 15 May 2024 09:40:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0424E6B03C4; Wed, 15 May 2024 09:40:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E24A86B03C6; Wed, 15 May 2024 09:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C07956B03C1 for ; Wed, 15 May 2024 09:40:36 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60C0EA0B2C for ; Wed, 15 May 2024 13:40:36 +0000 (UTC) X-FDA: 82120740072.08.6EAFE74 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 161A740007 for ; Wed, 15 May 2024 13:40:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YVQgYek5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FSE1eyv6; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YVQgYek5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FSE1eyv6; dmarc=none; spf=pass (imf04.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715780434; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VLGJev3FA7v3vsYQEjnEowkK3iUYOP0SL3+sW0TN5YI=; b=Gh7oeJ2YkuZgBkM4djeEMLuixKHPESQNiAx/BlqQMUARBVli3Ceu5EKe+4jucoWjO8tf4h ekv/CUPEty2MSY6cCn8iFmWApEMTrhOy6aP9jcq91/ROdZJekf6QPv+07HDZmX//MI4+8b sh6zLbbgMfFnnxKlC4SmcjHdPK8yNAs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YVQgYek5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FSE1eyv6; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YVQgYek5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FSE1eyv6; dmarc=none; spf=pass (imf04.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715780434; a=rsa-sha256; cv=none; b=Jku0ohLqleb8buhYe8PZyGd3d9KYUeSafIMfLUASgITM/njX20hV4lG4AevcyvoGdflaJI qPqOt2/veHDc6hcHnlVbvSqBJ1W1yVXUniscA7Ag2ihJ4snSurvj93uny7+5dpmlcbPela 8q3uDMpwL5mJeWiJlL0VhKujpIoV3eM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2182720717; Wed, 15 May 2024 13:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1715780432; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VLGJev3FA7v3vsYQEjnEowkK3iUYOP0SL3+sW0TN5YI=; b=YVQgYek5HqXmJnE9tcJCykuLrzO9PN2sfMpFunCbmyVy/TxBLs/4EVrvMCA3Ho1MeeeUpn HcTxYXF61ir/CCnp7E7I52Jsfmeuw/XaTKfMIUNw9yvz2m0l9GHcnAO75p3ujoWNQI/bN5 LjlK2EbVHtE0z9KavwMByHNmZj8sCR8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1715780432; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VLGJev3FA7v3vsYQEjnEowkK3iUYOP0SL3+sW0TN5YI=; b=FSE1eyv6Hs3uvUmst4Re4bPPCHocjTNEe6AGCgx8EDcaBxl87s7i0IR/iW9BNScUWaLDj8 9ulRrg6UdfQZzpDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1715780432; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VLGJev3FA7v3vsYQEjnEowkK3iUYOP0SL3+sW0TN5YI=; b=YVQgYek5HqXmJnE9tcJCykuLrzO9PN2sfMpFunCbmyVy/TxBLs/4EVrvMCA3Ho1MeeeUpn HcTxYXF61ir/CCnp7E7I52Jsfmeuw/XaTKfMIUNw9yvz2m0l9GHcnAO75p3ujoWNQI/bN5 LjlK2EbVHtE0z9KavwMByHNmZj8sCR8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1715780432; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VLGJev3FA7v3vsYQEjnEowkK3iUYOP0SL3+sW0TN5YI=; b=FSE1eyv6Hs3uvUmst4Re4bPPCHocjTNEe6AGCgx8EDcaBxl87s7i0IR/iW9BNScUWaLDj8 9ulRrg6UdfQZzpDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 531451372E; Wed, 15 May 2024 13:40:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IP4XEE+7RGbuGwAAD6G6ig (envelope-from ); Wed, 15 May 2024 13:40:31 +0000 Date: Wed, 15 May 2024 15:40:25 +0200 From: Petr Vorel To: Lee Jones Cc: Murphy Zhou , ltp@lists.linux.it, Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Cyril Hrubis Subject: Re: [LTP] [PATCH] readahead01: pass on pidfd Message-ID: <20240515134025.GA225100@pevik> Reply-To: Petr Vorel References: <20240423070643.38577-1-jencce.kernel@gmail.com> <20240515132151.GA557949@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515132151.GA557949@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 161A740007 X-Stat-Signature: krwdzoej7ehzxygcp3pufejgn3dymhky X-HE-Tag: 1715780433-8322 X-HE-Meta: U2FsdGVkX1+wFxyMmu9hntUZkUnetYeqO+h8UuGGSvtMbMtJSJQb5PIArETsAqPk+D//sNzzU1mPAah6uabsZeLz96u2oqd4wfB7cAVhdc1n2oNy5KG495C00DU+gO5Z3JM+n7wCDYwvGDLVGnqKcLfbGj/gh41+MDoDrwUfhkJvambn1CxkFKZxJ1mGHQUdnmaE6sCLiCNVhLs5/c8ZXk08Q4cEBk+z59ei0jYvyAXuUjFO6H7VNRpa9kYVmwJGQpuOUS0WC65aXox7DpUHAWO6MmbgjsQV5lWuyJ/1qvebeXf7dWa+BH8H7h4l8ut29MfepUmWD7wyyFNNaKf/unJ2jHHTxpzo1PXliLtAmbp5W7le9nm5XVT/1QTAAL3jIU+ldtFOj99pdbCVMaVO5ecLGbCaieG0/7nC7fnLA88iFm06RDuDnBWubDdshQstJqqGdCoQw7M+mmzdtQ6SWBxG5PM2N4ST/QOLoub5OPtx2upsaD1N/NCWs9mV3nBDOMrGTfCUhSrQZc/AURgYgakvz0zGrQiwDUUka3akv5S2wZdhn8x0sY6XSdcUSHoScVCni1cDOHOnEiR9fvIPdjeEMKCKP4DMl32OS/fsAjHq5UyB8BOlaqArnG2WZ5xBgP1Oq5b1csdrETwLhg22XSNXtsaDfNpl7jYIa4QDc0D/xrbgbbq/kMsmg8JbMgo4Rj954CBFT9nDZrSXEun0oB+p9cVJbqTPYuL29hxNHG5RE3jKBn+I8NjkUgUVeXLPr21Eu19ZWXJZYC5yL1aq8FjxHXurjDswaYamQiLHfK1/E1N3f+PznGSgOrvyqiOFmgaZkL3H3mluULPZVswOLzmf6VRgh+LySbB0y8UNRp+LzrmZONlBvrcV9T+Pp4/CBaai9tj4nZJAyocx64oeK5MF1NDsQohHQyFyTCkXpYBMKwkdBYntRiCs8UxkttW6TAjIThlGvoYwbTXpO3v 03c78cuO fu4r4EOcr6SA3a7rk+Wu40On0R0cEraLytB2oVA57voqkRriDCmwrQfKLvjRdqyHk3nfKeLlH26DhqVxHLfLGDSLtZ8iABdJmmmNuZnsXT9jsmTDwZWNrv2pQgqrFp6QKyB9tWOs5j/0FApDseKrNrWI8wzssMxG4wLQKd6IizipCGHvyUBm0u/cwaOE5him+xV3Y58z3Dzxnb/Ejews7YfQokd5lfgUSrNYWBv1+e4pIc7Tk/Ee6lusag9Q4x+iHtJZhPEE2lysRe0GeHV8oSSuyFlzPXxORpgLlYQrrptbPzcSMuHCPvBtsj0j4auQEbvMXyFtVntngC4pBgQnj83nI4PcdlcUcAqGtJGqUYY04M+7CpZ1mwHraR4WQc+RsuhDH7EKaxrwrf6nCVyKA2X48gLmzOFKZQ4R5WchtWr8jYIdISDgBXX7pctXyA4gFf2B1b5Zs6hbfCKbGYa9zkM4uCQV7ic8YEGEfN9qnDxsC27sfO7PqCpikqt8TB7rSSTcaKU3mldY8su5muUCkoKM0V4MEKIzMoSxkiuKu6JVzkNw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lee, > On Tue, 23 Apr 2024, Murphy Zhou wrote: > > Linux kernel added pidfs via commit b5683a37c881 in v6.9-rc1 > > release. This patchset ignores readahead request instead of > > returning EINVAL, so mark the test pass. > > https://lkml.iu.edu/hypermail/linux/kernel/2403.2/00762.html > > Signed-off-by: Murphy Zhou > > --- > > testcases/kernel/syscalls/readahead/readahead01.c | 1 + > > 1 file changed, 1 insertion(+) > > diff --git a/testcases/kernel/syscalls/readahead/readahead01.c b/testcases/kernel/syscalls/readahead/readahead01.c > > index d4b3f306f..aed8e7f31 100644 > > --- a/testcases/kernel/syscalls/readahead/readahead01.c > > +++ b/testcases/kernel/syscalls/readahead/readahead01.c > > @@ -53,6 +53,7 @@ static void test_invalid_fd(struct tst_fd *fd) > > case TST_FD_MEMFD: > > case TST_FD_MEMFD_SECRET: > > case TST_FD_PROC_MAPS: > > + case TST_FD_PIDFD: > > return; > > default: > > break; > Any movement on this? Back to Christian Brauner discussing with Cyril Hrubis [1] > Wouldn't it make more sense to actually return EINVAL instead of > ignoring the request if readahead() is not implemented? It would change the return value for a whole bunch of stuff. I'm not sure that wouldn't cause regressions but is in any case a question for the readahead maintainers. For now I'd just remove that test for pidfds imho. That's why I would like to get ack / oppinion of the readahead maintainers. I already asked them under this patch. @Andrew gently ping. Kind regards, Petr [1] https://lore.kernel.org/lkml/20240318-fegen-bezaubern-57b0a9c6f78b@brauner/ Below the patch I have asked kernel maintainers to ack if > Android pre-submit CI testing is failing due to the new unconditional > enable of PIDFD. I believe this patch is required in order to bring it > back to a passing state.