From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A17EC25B75 for ; Wed, 15 May 2024 16:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCE9C6B00B4; Wed, 15 May 2024 12:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C577F6B00C2; Wed, 15 May 2024 12:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1F416B00B5; Wed, 15 May 2024 12:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8DE6A6B03B8 for ; Wed, 15 May 2024 12:10:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3B9611A158E for ; Wed, 15 May 2024 16:10:47 +0000 (UTC) X-FDA: 82121118534.19.FDF5975 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 650E640009 for ; Wed, 15 May 2024 16:10:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AKHNmsvz; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715789444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9O3isuE0DRTbVDZwP0nXvR9s8oWpje51kOATlCFLLqs=; b=Crwrn7nXfG09VDYAhUvfxUSm/5ZWFy4tmlSchyudZL2SbH6EBSgKCIRrjaILqJnHRcvuxq ++gl9N7PUcOAkpHGU82GV0vw/E9VaIOch716u38Y6nsKNRVg3/nxUTg0BGUkmTWHM1lRYc zZQ7POScT8VFlMKFObGglfueAhX1IYY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AKHNmsvz; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715789444; a=rsa-sha256; cv=none; b=BZQnQCSAHjN1Zuf7ou2E3yoWN6xTEPCyG1lVGKW7PR7gnLg5NaEj7CmIitJGNL0MMC7TN7 OYD+lzkdY9xrXcb5ChGiVTdNx3+NA1b+si6ko0bhPyQLmvquIfejdpG0qgfgid/kK2kAmG Li74SfmhSoL/ZFIyrLZbwLjS0TIlL+I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 534D7614A2; Wed, 15 May 2024 16:10:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AEC9C116B1; Wed, 15 May 2024 16:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715789443; bh=5xAfxwaPOj0PDLQIrXWQC4UVdY3a65c4Z2mw1Rdp9lY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AKHNmsvzGiiFfggvMDXWGtz/DhV6rLSJn3ZEn8DZFy3hpSs9v4PGz+g9dyi9zorG/ NUdyzYo54aI4xVkH0aA0j+xd6NtcR4ukkR7RLlgge9OQsV2ohM9EXIKtNM4s/6y55P gDSDCuIlD5vTvglTeUgUW4L4xtyz7Pw/SIxbCbD7I9ew4kP2juhacSy3Q7KFlgOSRC 2ZGBqE/B0rTxKFAc2vKqJFqiE4m0zfQK/468RI0UJFni7ETDuvYzh3ZitnEMOo2ZzO GQ+fmUgd6f34aeIcdy/dDp+iAgfC1eiTHZMloiBNvJ7krLAmQKCPw/QcSqlqXoRugT Kf4uAjMuZlEJg== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel_team@skhynix.com Subject: Re: [RFC PATCH v4 1/5] mm: make alloc_demote_folio externally invokable for migration Date: Wed, 15 May 2024 09:10:40 -0700 Message-Id: <20240515161040.69242-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240513120358.1503-1-honggyu.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 650E640009 X-Stat-Signature: 5x8ws9yzod41375u76ef33wibzyekmz5 X-Rspam-User: X-HE-Tag: 1715789444-743965 X-HE-Meta: U2FsdGVkX1/wMrEpKyLWpEGe+hays1k0dpaunLTuZwlB458bS7LYBwI6bCutT6YxeWSOrIXgZZjNEW+liA7r0qHCO7NIrrcQnFMB7bs4PkRIgE+pjJ8aAGUYwG6JKAnVhOA2eIAfey9egSlMMSX5oXYFaouiZphfCVFw1F3I4RKu9nA0atT/dbLtrH+tjQQpb7ytzko8FgKmXJYpi/iCmkLBt39yE66meSqRwFFRH68o4eP94m4JVXnPv0DnoHH9rW1EKhEkAjYYI5Npb3ieCQ9ViYfFKNPlZwEFr/qzS5c+5iHSboF+4U/IU81FhlRvCE1H0R57kzMcjkyoZVsK28UuXqzB2C1lyKUwcx5zVRDCT8cQnTG0MgDXU8seX3s8NpmPjZYtzFOPvAxOedJsXL55A8g8Kqqojn8ofTACLhk9FOr9WLpZqnqPNxZgKEWP8URHn44XswxwPu4Z+dMYVhyw2U77PtmJOa/aHTPtUv/kACcyNa+xVprAhl2R0ePIuXxnILunKwrIMofTbtxgKCgFWWY7sUASMs1tlQA9wwjHlPIAk3TjfMVYtZNkVlZQ9WfZ5nSRxbetB1qy34R2o9Zps9kwh9YnaW8i0IEbKA/sJr+yDbUwKSsj5jZEtXjhKKHueyBpsftmjY/811wvvGMVzZdx7vvJjG7G3AIXRmRjdSCUvfB2Q4DZRkIQanK8LwhuJl4pxRS8qR70z+enZnsqma6sJS1Hs2ry9UWdBmen4eM2Jb7GEEVsp3cUwI/u8zOO9TfJW3R4KQkZQA/RP599RjhEmJHfMgPssi/6KFxeG3l4T0CAyG9vqa1rI+70MAYTveOgY2k7t1zef6hDlGLaGLHHZ6N4gN74GIthmXg6L7+Yp3fxZIoLPePduw3c/vlAxVlQWgTCLxWBMGu35kLzM5nJ6mHcrqZNZKCQPpoNhGcrjUSs67Di2cX/TgXCXypij59Zn6NFGQaJEn0 JSmnebfl LQla8BwaiZYtnAmj5K086nG+/0g67pKrEJbXtx19FSSkhhdpBPEjQO3fNLcyr9fNqsE2t5b8Eijt0sXgy2TnExTGI+FKEttXqR5Y6HkOsnBpiizcJaQAu+jVSLwMPyX9sgKEP1/i/brAb6GBBBGSWdwH4amFwKrdfdhXrFVMM43+qWhpNWSWa91bI2JURRVfteljfcSw67j9gJLsvwpqAUtI4SMGbGY7kMvC3TNDGKfs3Ici/5+HJkxd+fCpCohym+Bv1I27oVmGXFh/cbzFNnWQtC+J3NXxCzSg3UWa2ydMfgecc5Bx0chr6aWHSeHXq61etzQRzq568qGhv5G/dFuFDvHoNqaJw5iIi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 13 May 2024 21:03:56 +0900 Honggyu Kim wrote: > On Sun, 12 May 2024 10:54:43 -0700 SeongJae Park wrote: > > From: Honggyu Kim > > > > The alloc_demote_folio can be used out of vmscan.c so it'd be better to > > remove static keyword from it. > > > > This function can also be used for both demotion and promotion so it'd > > be better to rename it from alloc_demote_folio to alloc_migrate_folio. > > This description doesn't match with the changes below. You're right. Thank you for checking this. > > > Signed-off-by: Honggyu Kim > > Reviewed-by: SeongJae Park > > Signed-off-by: SeongJae Park > > --- > > mm/internal.h | 1 + > > mm/vmscan.c | 3 +-- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index b2c75b12014e..b3ca996a4efc 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -1052,6 +1052,7 @@ extern unsigned long __must_check vm_mmap_pgoff(struct file *, unsigned long, > > unsigned long, unsigned long); > > > > extern void set_pageblock_order(void); > > +struct folio *alloc_demote_folio(struct folio *src, unsigned long private); > > I still prefer to rename it to alloc_migrate_folio. And I still have no objection at renaming. I didn't make the change here not because I want the change removed, but just because I wrote this RFC v4 in hope of seeing how minimum this patchset can be while addressing my comments. Please feel free to add the change back on the next revision of this patch if you write. Maybe keeping this patchset without the renaming change, and discussing the renaming with a separate patch is also an option in my opinion. > > > unsigned long reclaim_pages(struct list_head *folio_list); > > unsigned int reclaim_clean_pages_from_list(struct zone *zone, > > struct list_head *folio_list); > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 6981a71c8ef0..27269bc2bcc5 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -933,8 +933,7 @@ static void folio_check_dirty_writeback(struct folio *folio, > > mapping->a_ops->is_dirty_writeback(folio, dirty, writeback); > > } > > > > -static struct folio *alloc_demote_folio(struct folio *src, > > - unsigned long private) > > +struct folio *alloc_demote_folio(struct folio *src, unsigned long private) > > Here as well. Ditto. > > > { > > struct folio *dst; > > nodemask_t *allowed_mask; > > -- > > 2.39.2 > > > > Thanks, > Honggyu Thanks, SJ