From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73ADEC25B79 for ; Wed, 15 May 2024 16:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 078BF8D0076; Wed, 15 May 2024 12:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 027BE8D004F; Wed, 15 May 2024 12:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E32628D0076; Wed, 15 May 2024 12:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C5D298D004F for ; Wed, 15 May 2024 12:18:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 67885140203 for ; Wed, 15 May 2024 16:18:48 +0000 (UTC) X-FDA: 82121138736.18.25BC9DE Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 0860E180012 for ; Wed, 15 May 2024 16:18:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lHXMfcKa; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715789926; a=rsa-sha256; cv=none; b=alrCBgbv0gmWJ6pPhzyHjoUizBwrWcDWasnzCm8HHG0KrNApDmK/DaKO3T9tLcqwg2DUaS usfpiK2nPPoeo5udk5/bN/K2UeAvKIsRHm7Jd5d/uafBThqKCe2eGp3i5Wy37c83Cf7Vi6 cTtUwgftKWLGhfufP9GkU7tQ00gUv8w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lHXMfcKa; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715789926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2OjokeVFcr9828fglIUuGuE/odoEzFBNx0PICQiro8=; b=FWO6tX+hZ5xEtqhaI7nraVxNd+M51S/iXOSdplpyIXiEg51TfeqKUCQ+C0nEBkaq/CIxMr Gx/b2haoFUg/rnJXJrBc49N4rBd9tWG+++GO36xDa0a1BDsx+d7w8ZbXXN5aVCDso6V1Mo TF14T97YQ0lwfklTs6CUSyvFYonpVG8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1639FCE171C; Wed, 15 May 2024 16:18:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B679C116B1; Wed, 15 May 2024 16:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715789919; bh=UMfHPJyXzxgzFEud5yIQpsOUvadwlPqB7VqN5ZzAC3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lHXMfcKav5r0I7ORkDgFdS5FZtTc2v/NsQTQTv2TlwmceVoCi2/Dk2+3se4u+ukdD yembcZx6USAJww2YGhH5koDlQ4w+eUTtADowT22gZ7Yitu7qBK98tsVJpWo7w24oOA i0wfT3SrO0DGfRUxETRRf299eLdJ7Q7W8P47iP5dmqwyJw4GyxGm/xL9gWzB8oDiwD LcHAqQA0dn+ZV+NMZhVOEqVfQrmDGNv66KxfKiW4V28l50BDoxo2ZocRy/1Hh8MDv0 gDKqjrNIryOlWaxpOA3wWrHFmA0vEhoHmFCiDpJu8LkeZJtGW4uWKNg4En7hqxKlHP xfhuoPzGaq58Q== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , Steven Rostedt , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Hyeongtak Ji , Rakie Kim , kernel_team@skhynix.com Subject: Re: [RFC PATCH v4 0/5] DAMON based tiered memory management for CXL memory Date: Wed, 15 May 2024 09:18:35 -0700 Message-Id: <20240515161835.69311-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240513115918.1479-1-honggyu.kim@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0860E180012 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: fxcckm1zcr3jy3nx4sp14xb56z8gibfy X-HE-Tag: 1715789925-114798 X-HE-Meta: U2FsdGVkX1/nwE2+Z0+NWQA6w17Jr3Niu1q4czYZ4pBJHuuUsAER/7ZGYRVndwhh20B/NQWW1iYQbtckDO7VBFBO+NDAJ7qiWBaod4qfEBXAQBUcuFAC1V2aiTX0bMxAtIt/5ICBYWsA6mKiiP+jsqEs4htb6RG33jqnGkoJS5wxWpDe87jz+O+42u5lqVGhyxJKROu40WOXD78Vn3HzF32/YTXk0QCv6dTZQAP9tAZ7DCi0HBEqhbh4c5q6f3Cxj1L5vYVPpM04Syepkuk7/fDQxb0cZe56TZvA5SQ8p13yDgxGE6cOyLG3m3BwnTKqBW2k7m8BYRPmZFiDvSWs6xrr38X0WenfDcentu4y4gM43Zg3Cj3uzNUGuiD18wfUnKwTod+A7Arh+FrmPPUsG5vsQhTTuihnldirsDFDdGZ6U4wgnT8NzvYVPe0DplycXwu8xKo/4ewJaQO92fJEKAmc+nLILwLoSMJzI2mTXmVhqcGiXrNt4XqFRQFsgxkKeLnLI+7gTtn6PNE7shEFtd65aA38jEpoB/cG4njUjIYnc3qT5878dXsEmVb5B1Yuc4RtdEBOI90LGa0QhbrqRCqo7b9O6fjGtoy9aVG9CxlGfp+mUvQTn7TfMp9FyR/L45WM/nNZ2CbniMwzI9ZoE2W1qySQYQKd9mRH2epSYyTQXWdYBe6mDhQkkUzoIRjVDQBuyELRTkpvyZrCCDcVcAnOawIPWEDDy2q51za8e6foYJAQqaLjhP/ayGj1IP4cGgg8el8lublU0tbMIi/S3mp1pDmdQ2TXpBHIRkYXxbwKe4GEfsbG5Qw9IH85y7D92ff90E+blgnzqJ/WQKJr9NacV801QQMzhGE5sKh0zHpBOYfr0ObLhWWVIDtyALnjLBPfvVockrqhmewt/3abYLPWpQ2nkxkibtsTAXhWshbK+Pq0Qux/0oR2/Z4QH4XACohNWqbGQtvLMWhPPac 990bDQ2Z NpIS/c7nUuKtq+nwDGhtXNF+wmYDGtai2njl9NTiddvg9zy7iZKpMpf6JRRfN+qC1YRmhig7JJjERgdVzQ+MgTrUC1yPMjHd0UpR+u7alPFkjX2X1eIFrxmhAz8+X3rtjusowFcWmRTASq+MkhNqIbjuigeFf6hAKlv8o+IrWQTBmup7k2+folGE9y4hpQAOO9TxWMdt5mlnqB2wFsLuC44ehrw96L30+jHLEWPzQZwcYV8k87ZIUp6Q6WfBdnU8qhEKh1jt4kj6HuNK5jY88zH3wCBX5rS8gndPa5Zq9wc7WfprPndYbU1831ebWz9grESO1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Honggyu, On Mon, 13 May 2024 20:59:15 +0900 Honggyu Kim wrote: > Hi SeongJae, > > Thanks very much for your work! It got delayed due to the priority > changes in my workplace for building another heterogeneous memory > allocator. > https://github.com/skhynix/hmsdk/wiki/hmalloc No problem at all. We all work on our own schedule and nobody can chase/push anybody :) > > On Sun, 12 May 2024 10:54:42 -0700 SeongJae Park wrote: > > There was an RFC IDEA "DAMOS-based Tiered-Memory Management" previously > > posted at [1]. > > > > It says there is no implementation of the demote/promote DAMOS action > > are made. This RFC is about its implementation for physical address > > space. > > > > Changes from RFC v3 > > (https://lore.kernel.org/20240405060858.2818-1-honggyu.kim@sk.com): > > This link cannot be opened. I will share the link again here. > https://lore.kernel.org/all/20240405060858.2818-1-honggyu.kim@sk.com Thank you for checking the link! It's weird though, since I can open the link on my Chrome browser. > > > 0. updated from v3 and posted by SJ on behalf of Hunggyu under his > > approval. > > 1. Do not reuse damon_pa_pageout() and drop 'enum migration_mode' > > 2. Drop vmstat change > > I haven't checked whether I can collect useful information without > vmstat, but the changes look good in general except for that. I was thinking you could use DAMOS stat[1] for the schemes and assuming no reply to it as an agreement, but maybe I should made it clear. Do you think DAMOS stat cannot be used instead? If so, what would be the limitation of DAMOS stat for your usage? > > > 3. Drop unnecessary page reference check > > I will compare this patch series with my previous v3 patchset and get > back to you later maybe next week. Thank you very much! Unless I get a good enough test setup and results from it on my own or from others' help, your test result would be the last requirement for dropping RFC from this patchset. > Sorry, I will have another break this week. No problem, I hope you to have nice break. Nobody can chase/push others. We all do this work voluntarily for our own fun and profit, right? ;) [1] https://lore.kernel.org/damon/20240405060858.2818-1-honggyu.kim@sk.com Thanks, SJ > > Thanks, > Honggyu