From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C37C25B75 for ; Sun, 19 May 2024 23:48:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69B756B007B; Sun, 19 May 2024 19:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64B306B0083; Sun, 19 May 2024 19:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 539CD6B0085; Sun, 19 May 2024 19:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35B426B007B for ; Sun, 19 May 2024 19:48:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8156F140AF7 for ; Sun, 19 May 2024 23:48:28 +0000 (UTC) X-FDA: 82136787096.11.AB18640 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id C7FA8100018 for ; Sun, 19 May 2024 23:48:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=o63afiyR; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716162506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cFGU5bAz0x+imcqqlUmsqaU9ounYWaoMEBofiHID3O4=; b=NpOfvge41lNpcWK71dlj3Ir1zJUE8L8APMJbcNIhlsJ9aQ/FfzDaGEAtDdZv/4DYptkl6D 6jjpswXEtYmycALuWkHgHMee1+BP3kd5Lo4OUDjuJgjoAAZvLY4lcpK5JfGBdtcVyGtn1X QDnS6ghBaFSXDKNm6tfNyG4cFN0Pi2w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716162506; a=rsa-sha256; cv=none; b=A/MahvLV1WkazkgJQY1dzLbkGFUqubbagrZPRwyAYOpbDy1nUzkp+asl3PsUZpV1AhEI8x WcmlEmvDcHql/oQREv+IUjwFH5zVghd4Xquzye7r4Gp7ObXlnAPOC+9iUQLpXGhamKbmHz oRwGjYdqcMMGN6I3vyV0Y8+ZY9VpyTg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=o63afiyR; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9E178616C5; Sun, 19 May 2024 23:48:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D331C32781; Sun, 19 May 2024 23:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1716162505; bh=a5IqfGM8Xs0u8K/8KiCDxhps6dGg21MfbLPXNVbgILw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o63afiyR83+KBRwq41skI3q3A+V1GfTG/mO0OMqwZKAYVJ/Lu1hFXMVR6BSnO364e ELVQ64z8AJ9n92mv25r+SfyfU2wVgplSoD4yjHe+6dztoXWG1nvMFQePscRHGV/3Mr ZenLf2A1bm11k7GlaTypTAjU5iikZF9IF3pJ4zsU= Date: Sun, 19 May 2024 16:48:23 -0700 From: Andrew Morton To: Dev Jain Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com, kirill.shutemov@linux.intel.com, AneeshKumar.KizhakeVeetil@arm.com Subject: Re: [PATCH] selftests/mm: va_high_addr_switch: Do not skip test and give warning message post FEAT_LPA2 Message-Id: <20240519164823.8e21acfd2bf9ad13f7798f1a@linux-foundation.org> In-Reply-To: <20240516035633.143793-1-dev.jain@arm.com> References: <20240516035633.143793-1-dev.jain@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: h93nqezm445pfsk9gsp7bew8pdb6awcq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C7FA8100018 X-HE-Tag: 1716162506-921085 X-HE-Meta: U2FsdGVkX18x/ZQyl1/+n6xYjPNCLyZp5xf1sYOAx62iiLXEHjMjDcxQ+u8CoVCTvJtC12q41B0GqoTUqHkkqAjnRY6Vywfl6B61VkKKhI6X/vHrLvmtaHnVHBkyxLdv3Mg5af5QPhP4gVXw77ABb1rZdnKlJxywYUeoyDTYOqVrd0Nz8dnv9dg2fjlstvTjepngal9cmE0KVanv/X/AIG5GyeSdq+0JbOG+V3WKY5qhDV1GwX0x4S1HlleAj8ktrUzc/ISQ5Ph0/cB0lGI6/ksQUzVX+4RE2Uuj7fjn4ZPr2mIORECsurAtUgF9aJOWpsw2KnTfOsL735I7dXqgKbfCjjYqAvOCLAOwz0ppZPPAy0XrqXSkiTYzep8A14m5i1ZPFZe4QIOnmuFFTIr2vGvlhVuv5MOIu/hOmoinBkPSnGDQzsgW6NNzk6GYMQWMTldriaLbsEfsASeeSCdmuTPs9X5fMWw4Aszi36u/zo9Hj6Fuclvtbnr0hFsGsKGSTG8Ckd2iDEC78yXu7/npGQjWFXk22R+GyiPfsOFigndPBKds0UPQvdSUhzgrGQ78X7BqOmnhMBkEFAT2EjnvnL0Mi9DdzXDPdVezS7Mng1TLQe/CJGSmIrL/jlPgAtBL9ypZ6tqGYmO87NU4JDEaDa8/ewRNAxGF5mdNeXJOyp1u+Li3nY9kvsCxxXyjBVFNpCugJsyveJEeI2rjgUwGcGmZEm5yfHenmUCPDyEZwfltgxUdJcCfLgW1GPd5EPB8GQvPHIP7Wz+iS72AMXjsZRaX/eyekbBELjHpGJto40GIRcPkTsZ/iNqSIY5ExCOKgoRV2D9xPsziWN9zNCHM2wa2VuqhNGyrliAIc3JORlP/vWYSIzz+w6+5UN6ofsjrtF3IMNWoQEb2ycO+Cyh0dnLwUiCQCb+gAZ9K+ZTCKGTnOBqqYDcqTNnw5IXL5dF8i+c9LsizVMzLLLnz1+q snlGeahU uIozBzAXCDBGXfpMBRzyIv29gLlYBIqSte42VH7Et+8KX/f30mYKHRIs/h5Ms5qvDD31xUZgHARSIxj4xInPfpqP5vTBXk+0C5J246ZCo19DvKKsFVpX6FPOwrKIRXfW6W9MgtiEZE8nuqpSsff+GClvujThXPCApYaljswZt5Q5pVVxr2pMsbNeLmAubx80KjWV1s0LTfXw4DSnnWTKpGsqgS4/zoTJ6XUVIGN3mhwTLE48zmqmURDvzseNygUTI8swZEhG+B2hG+AdDQlLqX+LMYyaZBWIyFz+sDUGdErLm68RXL3HQ4dmueI39MDlcFuVsan5jsZDyASg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 May 2024 09:26:33 +0530 Dev Jain wrote: > Post FEAT_LPA2, Aarch64 extends the 4KB and 16KB translation granule to > large virtual addresses. Currently, the test is being skipped for said > granule sizes, because the page sizes have been statically defined; to > work around that would mean breaking the nice array of structs used for > adding testcases. Which array is that? testcases[]? If so, we could keep if fairly nice by doing the array population at runtime. Something like: static struct testcase *testcases; static void init_thing() { struct testcase t[] = { ... }; testcases = malloc(sizeof(t)); memcpy(testcases, t, sizeof(t)); } > > +#if defined(__aarch64__) > +void failure_message(void) > +{ > + printf("TEST MAY FAIL: Are you running on a pagesize other than 64K?\n"); > + printf("If yes, please change macros manually. Ensure to change the\n"); > + printf("address macros too if running defconfig on 16K pagesize,\n"); > + printf("since userspace VA = 47 bits post FEAT_LPA2.\n"); > +} > +#else > +void failure_message(void) {} > +#endif > + > int main(int argc, char **argv) > { > int ret; > @@ -308,5 +320,8 @@ int main(int argc, char **argv) > ret = run_test(testcases, ARRAY_SIZE(testcases)); > if (argc == 2 && !strcmp(argv[1], "--run-hugetlb")) > ret = run_test(hugetlb_testcases, ARRAY_SIZE(hugetlb_testcases)); > + > + if (ret) > + failure_message(); > return ret; > } This seems rather lame :(. It would be nice to fix this for once and for all.