From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC00C25B75 for ; Mon, 20 May 2024 00:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFCBB6B0083; Sun, 19 May 2024 20:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAD1E6B0088; Sun, 19 May 2024 20:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9BC96B0089; Sun, 19 May 2024 20:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D7A06B0083 for ; Sun, 19 May 2024 20:00:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 421DA160B33 for ; Mon, 20 May 2024 00:00:30 +0000 (UTC) X-FDA: 82136817420.25.E99EC16 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 8BCD218000F for ; Mon, 20 May 2024 00:00:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uJZPEt6u; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716163228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V5Uixl3CtpDv5Q6rCKFx0U7He6H+TxRQtbN4bXKiRHw=; b=QnrIKq9a6kraDtSZ7eHyrgQJ+Mku7gyQfH+kdw2ZomXn1KSTH5v2UYwws7Sf7Rl8S3vFen e6lGEgLh1HyI8qVNq8HZeOqs1bU4MW+flKJQMYlF74gk4vQeFAJxkLgsz8V/fa/HHgbcn9 k9EfIQmqdia9TG/nLO9a/jk91l4jjkE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uJZPEt6u; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716163228; a=rsa-sha256; cv=none; b=y4TrLDYTA3V1fNC/Z82eL54SgNJJppNaoEYM/iMrM3qZS4y8W/t5rLWlj+hj7LL6yVg0gT kLR0oMEFCF3wPxeLDWu3+cRKj7NTU2ahgWyTdfaVuV5QD7dbvUZmrNOUrD5mu5F5SrquWj MCHh3MVdjL8l06eJN1IMp/koMzpIGTw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 83DF061756; Mon, 20 May 2024 00:00:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC232C32781; Mon, 20 May 2024 00:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1716163227; bh=K7ZdYke6mZmulP4ruJdT4qcASJpvqUrfFF/cByhd60g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uJZPEt6u0yI4sB5B3ecpMDU9I0b6fOLkd9ufi2t25EcTCkJKF5Lia2tXV7gf9Avum MnrGy/0w34CNeNEdRg2NI7CcRNv242+GLp7YI/xpMfLJHn97CdGU08TwiSeK/TnpJG +ThJICjFGkaWjfRwa0FQWU1+eEIqbY31jKGiRHrE= Date: Sun, 19 May 2024 17:00:24 -0700 From: Andrew Morton To: Dev Jain Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com, sjayaram@akamai.com, stable@vger.kernel.org Subject: Re: [PATCH 1/2] selftests/mm: compaction_test: Fix incorrect write of zero to nr_hugepages Message-Id: <20240519170024.c2e62a7b69b00bb30e86a157@linux-foundation.org> In-Reply-To: <20240515093633.54814-2-dev.jain@arm.com> References: <20240515093633.54814-1-dev.jain@arm.com> <20240515093633.54814-2-dev.jain@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8BCD218000F X-Stat-Signature: u37aeo9myqmt55d9psnfkwnbyicykkgt X-HE-Tag: 1716163228-759277 X-HE-Meta: U2FsdGVkX19Wg9CRF42dsMGB91vq+mPPE568PWnZsJKruJf8Gi9ibPvNvz0Ty6Jag3BR+F3j+Jb7fylgSZ6A34S0rMpqP6hLKVRvRpXmgF6rscpFKWLKcDz90EQxmCrXpYSgdhIuNGGcJUw87QUTPpxcygVB9Nm0BBhliivGXOsw3pyk96lX1OLD0P3ghlfN7pifCv5iu+lq1XvrYHKOzA6LPj4xjYHDainXq2NVWYbiv7u9dUEEzYgvktQymoraIV9bCpKdgruXyOlkLt3usm4iJEbYR5iGer+g1Bt7Vg4dCljFSvjLyF+7WC6QD0p7GfHBrMFIp2EL4ONaEv37hgRdiT8AvpBBeqXQnrf1GQsrbxasPSUDz5zL6ywZomc3iwWXjYQhTbaSZxRSAdP0ag1fleB/GhXXshQg+B9wzsdwQA6Eh2TNvVxs+aojE21a9KQKtXLHFQoK1PcixsQ4SeapC/LuKrIiq7SXisYZTyeQK4i29+sLjoEaPEdIJK2DKqnWbILj12pPYKaYpDAa6gm++abwbOxOiMlFLbHvLuuS/IuCiNPsk4TnFWZ775lK792pD8c7gij9ddTYcdxrEUxiYtoXBJJgPj0BTklvpY/Ga8wwMSHoJPtR24m75zkq+VvyQN3SeRgRmpQDRY94MaaPn+WkwNi67ieLNrCmI7mK97fZOJLxdyby5wBRzNqHnL8etpvYqEwLPEqRZxKo+xINUW/83C9EjrvpOB7BS9pd8CKZN854E0+Kx2iqTC1m94KZ09dBGKHB26nYWOrsafNgc39YpfuwyCAtBBF5EtvWD3aLgCRwJwbvy/2scjixOLJN+2gZnDwIeXxfsrV0+cy1CNAHSvNvGjvVKS7ZnBvWzWqw1+BIKWOHdefzaSLzrNt/pmo6yJjOwl8oFVcSLum7tNqhJ0iHQ+xWZKDjesTy3XzIOAs598jM/eJBoEjMzXQjqm6z8yEx38HWE65 clSLftmN D1iRwwnJGLynISevu6gTD6+NVh83Rc5rDHKIRLn+DOCuMc/f5d/kdaY9/RFyhLi54vxlkD72ndwdg+Y2rKFKcXqwavYpQQ9hqWB6h9kJ0la0rZj1LEN57w0bA8KVm2RLp4yhxUTD9H9b8zKnCbIFvNhokHHBCU47oDNUlC/JwGieJC9SM9BIyny+/UyYB3gIWTN67tOPWcQFdMZwBbrd6ywuz1wN96IHVtsor7ZeN1hBuN8Po/ETu1AWpxMlwov6LfXhGBG68MCwp3cygwFj5ATCmG0bRQEjiLw9JV3ZaoC0wJG39YmN7/tWSCJ0A2+bV+A3BBu23KumE40eUr7qKvZoyJbpkEp6gERTOpXKSSRZ065k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 15 May 2024 15:06:32 +0530 Dev Jain wrote: > nr_hugepages is not set to zero because the file offset has not been reset > after read(). Fix that using lseek(). > Please fully describe the runtime effects of this bug.