From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89927C25B78 for ; Tue, 28 May 2024 08:12:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28E496B0096; Tue, 28 May 2024 04:12:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 218346B0098; Tue, 28 May 2024 04:12:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DF336B0099; Tue, 28 May 2024 04:12:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E02C56B0096 for ; Tue, 28 May 2024 04:12:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 584471C2A10 for ; Tue, 28 May 2024 08:12:56 +0000 (UTC) X-FDA: 82167088752.29.FF3E9F4 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP id 63EDD140002 for ; Tue, 28 May 2024 08:12:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716883974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HxV8BzlC4d8oc971uwAuFJbg7m+U49jGxWYEK5ArcBs=; b=QaZApp7pEFRAK7rGk0bIEmTc23gPRyJnmTfJ5jxQsV9PGWDm9eUZTykHqfkG36lfjLHb23 9W5iZRmfL+oCdF1HuBMXFch5s9bn6Dia7MtmthmWGjmy0UZfcussE2+upxCPU2qfaxX2eI LHoARtz18D+J2W5dZL9HoVJ3aPoCdFE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716883974; a=rsa-sha256; cv=none; b=8DtnYvP+ed3Oqd0qi5krVMfjXxtdfovIqFEi+148R7GMqG3nCzabvyaHlDOnD3f0cU4slM t+wZOFDIIKlJEpG6/6+J1B5enEsCiX7UV28qRLTci150vaXr4O/QUGnBHuv5ojUQemoZti GGPKXT3JWt/EkokcuIN4vOTnj9K5Z+Y= Received: by verein.lst.de (Postfix, from userid 2407) id EF8E568B05; Tue, 28 May 2024 10:12:48 +0200 (CEST) Date: Tue, 28 May 2024 10:12:48 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Message-ID: <20240528081248.GA3192@lst.de> References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 63EDD140002 X-Stat-Signature: 6gt144pww3byktbts6nbkdjekqx7c7qo X-HE-Tag: 1716883974-353243 X-HE-Meta: U2FsdGVkX1/B5oU4Pjs78Dg/2xJnFy9wkR6E4e4rZRs9FRaW5pZhM5Wv741D0cKdPC7FsTxpp4LY2/Dso6EemjY7BrjAIQqbv7UzNIAx6qn+rotQWFrgltdy9uE32OEV3hdUuwvbPaszxUHwG47VACupwx0XKQdHSaf+khELWi/Rhb/tnvBIptD5Ns7zr/zpM11jrBM9MmwMh4WIRF3mWL+HZZUpBBBbezLgR+dRch0qvX0dRIk+e/+dVeg635/KDvsPduqgAwwEp6djav/+EUHkaTOBQ7JZ8jTbo1uNVHjsZ0YhVTbhBK494yi0J8/kVeCrAS/UeV5HMngDvNeGB2RTtoaKTqHFFJUtjL2kuvtntOVDxc4K11JKOLb/kvWRfL1ZI5WQikemfjJdW+NyLBA/0HtpqhleZKbHOw1WRW3SqVDBvNsh5qS3IZAqtKZvArMgHMK42/UbCvnYHC7H05+um2bqA6kUUBZGu7qmeZnndYycXpOfbJzlYl3/bJdV+f6j/kkUz5VNftJI4q7JlnMB/RcAe7sXFZSe7kdtCityGsXMsD4EnfH0bOGtb6PqJZZ6/t2AAuWYXaqSHHKeUku0XTVKdEE//K+euMszrS+0Ydj519ngbtv7SpGEMllW8zYOuIhFUuxIgq4l/bewVy5mFQ1e7SgX5kzlWDgC8XoWRkh20U3JOgInxDVQtWVqyQiCtiTmRAxrgK9dfBZCXi+g5Ck0PKXGh7aJ+rnpjpzIlxENoyB9KuGV1T4/JuSDW9puy4a4xSLW91vpuj9OrUPW+JjCADI+g1JBaYvkCv4oQShyVLC8YPcGRuHjzTy+YWdFADDM00hjNg3gZgyK+4tSaK0FJsyupMKqITuCjKztGeUJrbWBexGfoxxt0pV0fcwtlE88Oz0CgxBMD/BESiYJot/dyz6ekVLBmqRnGAoqOQ4dgeDzqpMZd26f8z24iw/LQGNclOxPg1n+fwx sxVq5KGW nhQ2RKgzF9D5CRlOwMp746Ma2sM4KD1CjmC/6GKQjpWihRaXyyV3SF6UFKpzCviV5bZsEVLo5iU3M5H/UFzyM5iUOFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 07:17:18PM +0100, Matthew Wilcox wrote: > Could you remind me why we need to call flush_dcache_folio() in > generic_perform_write() while we don't in iomap_write_iter()? > > - copied = copy_page_from_iter_atomic(page, offset, bytes, i); > > - flush_dcache_page(page); > > + copied = copy_folio_from_iter_atomic(folio, offset, bytes, i); > > + flush_dcache_folio(folio); > > (this one has no equivalent in iomap) The iomap equivalent is in __iomap_write_end and iomap_write_end_inline and block_write_end.