From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E258C25B75 for ; Wed, 29 May 2024 05:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C65166B0098; Wed, 29 May 2024 01:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C13CB6B0099; Wed, 29 May 2024 01:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B03486B009A; Wed, 29 May 2024 01:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 90B0C6B0098 for ; Wed, 29 May 2024 01:14:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0D96380839 for ; Wed, 29 May 2024 05:14:40 +0000 (UTC) X-FDA: 82170268320.11.C962297 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf19.hostedemail.com (Postfix) with ESMTP id 200171A001F for ; Wed, 29 May 2024 05:14:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716959678; a=rsa-sha256; cv=none; b=KgY06y3hsO9XnVm30eueluceaGSjFcaHh+K4UY2l6b86bwp35urAKYvX4dewivXY+UkyVg +/utEaUO60H7GWMq/Gtj4pywIWQzvtXyRo1W/LHAAkMP2YtD9wo+0GN/aURbCJnxddhzB5 XUf0S0OB1e312erB91iu4UrunT5bPXM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716959678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qM+iX7HJjbRYfy6yt2uSJ6+tJDaWSxKJAufKNw8ME0c=; b=WtMWLCYbtk2L92T0C2/sOfb7QD4SB9yrhGJGRfalOJ2uchoWxZDLKQjlHmobgJS89cZNZA l+yL83rq94XBtTRFD2xWZ0tj43xWoyCI5LTDnYA01ii1m3QLmztzr8weXX+XNQuvy1fqon da9IpsAylfeepEs3T6zGdihJdZWu3uo= Received: by verein.lst.de (Postfix, from userid 2407) id D9EB968AFE; Wed, 29 May 2024 07:14:32 +0200 (CEST) Date: Wed, 29 May 2024 07:14:32 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: support large folios for NFS Message-ID: <20240529051432.GA15188@lst.de> References: <20240527163616.1135968-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 200171A001F X-Stat-Signature: rmnytksxe4i1gzsgozpfd13s9md8nawe X-HE-Tag: 1716959677-259977 X-HE-Meta: U2FsdGVkX1+Yft9KoUft0o4o2rhlkJrqHA8VQK9f1M2vM91VVbxKm888HThad06+mgRBAJqFK3iQcGF6cuyiYwji7fNmC+QB4PRNyyA6pmBlmPuiUgbgGnzgg5uPyW4hXywE0GkXP1ha25fn8foDH8jlULsGNtg+TWxE4EQ7e/YaSXKiCkcTLzI3hzU4p8cBbA97b7LBhmUOCKSpan3HNxdi527GFugc3uaiXDECW5TSQ9OANEOYJ341SxyBsCYL7l6izonvy/4EUZ11tAdn/HlIvR3ITusOQUf4KPHLWDT91HvOrW+yKWVkp5Om5aq6usraqeGF6jxt/17jJ4xnl4mA/Y+RN87lnlH15DBjhTHCj8Mh50zW7sfppdTUE5zwPnF693HmKfwcscVWerldh027agosjChMu6QHCKWOkqXypN7Lo373AQlnYqWO+cqP0FtzDhtDRSHwtKgZkBH3KFmOxIhajQXNNURVHMqrUtOE25zVwMoW1cMaxaosAlZ0uNDVwxIQi09rDB9S9/37kGDtFj9NiT6ZSLRZ89skjyi4z3M7JNm04brDk8IimjHlMJWVglcYOhhKeyScLn4fGJFP+JT+6IaK97k5iGxrFLFx3Vvg/0pxCj/9RqtVDRzrbmqBGaUsk1n4HvhFlSOmBFRrkJK6II2wTZ89Gn9qi8yEaOJE070QNMIMnfUg4mr/hvRjLb7v7/4Xou/yMw2OSdRSRMekv4niN09O3iqAZut5rkjDIAgAK7wlEV/If+vmS+XFzMMrSUPsDHO1iiPZfaU/oUJuRk8ryjQdh8/Av8GU7tOkJVR3GbGRIBwecDeWHtJKGO4nDrFNgr6VojPrcvYTEYepIXaa7UcaWINUorkTV14S9EcW3T8Mu5SU9nxcj3trkPtX8dGYj472PwlEuVoQAsdley8WGAQOkR1Z+uBVxVSg48pqQHSYLxFnWE7NhXxI5mPm3NO+3mcqg1M Othx+JFs JhSB7bdoYIwlkE3JdoGzmjcCMAfCqhEb3akNg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 10:05:58PM +0100, Matthew Wilcox wrote: > On Mon, May 27, 2024 at 06:36:07PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > this series adds large folio support to NFS, and almost doubles the > > buffered write throughput from the previous bottleneck of ~2.5GB/s > > (just like for other file systems). > > > > The first patch is an old one from willy that I've updated very slightly. > > Note that this update now requires the mapping_max_folio_size helper > > merged into Linus' tree only a few minutes ago. > > Kind of surprised this didn't fall over given the bugs I just sent a > patch for ... misinterpreting the folio indices seems like it should > have caused a failure in _some_ fstest. I've run quite few tests with different NFS protocol versions, and there were no new failures, and the existing one is a MM one also reproducible with local XFS. That's indeed a bit odd.