From: Barry Song <21cnbao@gmail.com>
To: yuzhao@google.com
Cc: corbet@lwn.net, linux-mm@kvack.org, lsf-pc@lists.linux-foundation.org
Subject: Re: [Chapter Two] THP shattering: the reverse of collapsing
Date: Tue, 11 Jun 2024 20:32:24 +1200 [thread overview]
Message-ID: <20240611083224.281772-1-21cnbao@gmail.com> (raw)
In-Reply-To: <20240229183436.4110845-3-yuzhao@google.com>
> In contrast to split, shatter migrates occupied pages in a partially
> mapped THP to a bunch of base folios. IOW, unlike split done in place,
> shatter is the exact opposite of collapse.
>
> +static void copy_page_owner(struct folio *src)
> +{
> + int i;
> + int nr_pages = folio_nr_pages(src);
> +
> + if (folio_can_split(src))
> + return;
> +
> + if (WARN_ON_ONCE(!src->_dst_pp))
> + return;
> +
> + for (i = 0; i < nr_pages; i++) {
> + struct page *dst = folio_dst_page(src, i);
> +
> + if (dst)
> + folio_copy_owner(src, page_folio(dst));
folio_copy_owner(page_folio(dst), src) ?
or can we drop this? then dst will have shatter as allocation
stack. this seems more helpful for debugging.
or it is even better we can reflect both the src pageowner and
shatter stack by enhancing pageowner mechinism?
> + }
> +}
Thanks
Barry
next prev parent reply other threads:[~2024-06-11 8:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 18:34 [LSF/MM/BPF TOPIC] TAO: THP Allocator Optimizations Yu Zhao
2024-02-29 18:34 ` [Chapter One] THP zones: the use cases of policy zones Yu Zhao
2024-02-29 20:28 ` Matthew Wilcox
2024-03-06 3:51 ` Yu Zhao
2024-03-06 4:33 ` Matthew Wilcox
2024-02-29 23:31 ` Yang Shi
2024-03-03 2:47 ` Yu Zhao
2024-03-04 15:19 ` Matthew Wilcox
2024-03-05 17:22 ` Matthew Wilcox
2024-03-05 8:41 ` Barry Song
2024-03-05 10:07 ` Vlastimil Babka
2024-03-05 21:04 ` Barry Song
2024-03-06 3:05 ` Yu Zhao
2024-05-24 8:38 ` Barry Song
2024-11-01 2:35 ` Charan Teja Kalla
2024-11-01 16:55 ` Yu Zhao
2024-02-29 18:34 ` [Chapter Two] THP shattering: the reverse of collapsing Yu Zhao
2024-02-29 21:55 ` Zi Yan
2024-03-03 1:17 ` Yu Zhao
2024-03-03 1:21 ` Zi Yan
2024-06-11 8:32 ` Barry Song [this message]
2024-02-29 18:34 ` [Chapter Three] THP HVO: bring the hugeTLB feature to THP Yu Zhao
2024-02-29 22:54 ` Yang Shi
2024-03-01 15:42 ` David Hildenbrand
2024-03-03 1:46 ` Yu Zhao
2024-02-29 18:34 ` [Epilogue] Profile-Guided Heap Optimization and THP fungibility Yu Zhao
2024-03-05 8:37 ` [LSF/MM/BPF TOPIC] TAO: THP Allocator Optimizations Barry Song
2024-03-06 15:51 ` Johannes Weiner
2024-03-06 16:40 ` Zi Yan
2024-03-13 22:09 ` Kaiyang Zhao
2024-05-15 21:17 ` Yu Zhao
2024-05-15 21:52 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611083224.281772-1-21cnbao@gmail.com \
--to=21cnbao@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-mm@kvack.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).