From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB3FC27C6E for ; Sat, 15 Jun 2024 01:29:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF8B36B0120; Fri, 14 Jun 2024 21:21:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDC286B0127; Fri, 14 Jun 2024 21:21:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C630D6B02B5; Fri, 14 Jun 2024 21:21:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 808096B0127 for ; Fri, 14 Jun 2024 21:19:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A749EC0A09 for ; Sat, 15 Jun 2024 01:19:58 +0000 (UTC) X-FDA: 82231366476.24.4277F7A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 79F8740008 for ; Sat, 15 Jun 2024 01:19:56 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gpBsYYuM; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718414394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IObPrJ94tAI7XxmQ3jJQOyeLKVgAAAIM25MkSPZRZDM=; b=8KqnodL2l4Mcjh35rxH38W3y2aWk0gYbLKEUfMPeOKvwjWPGmIJW/2wZ/fYrcZc0wDBpX2 LQ9DUTJPw0hM3crkZVJ7TzsUOVRFyKu7P5Th8WZ+GzZqGsR0o+xMoKT7fx5E8LSJbeOhU9 FYix71GfErcO4weH7p1lArYkmScmRpo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gpBsYYuM; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718414394; a=rsa-sha256; cv=none; b=EkxIF8GrTtphArdosxwwBHD9+DlGSL20n9+TUD6ooLVg8CR2fo2MOSLHWTE/RA5o1qaiwL a5C/F0ea9Kmfl94A1HSZTNyxSI3quPFQDpA2ovimOjk/FWJ7EYXvefJNqeBY0PXrUGCHjE MQeAs8woZpXMOXKGAtbOgFDD0qSJIXU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 87583CE2D3A; Sat, 15 Jun 2024 01:19:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A5BDC2BD10; Sat, 15 Jun 2024 01:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718414391; bh=ilNXTmA99Z0S3RmVkDwTAq3gTOlyn5NNkcxVzym5pxo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gpBsYYuMFqpgRL4nip0qVXAWMcvM2hVCCIGgF6FeqesFYqYu5gsDug5FV8kGGtYUk XI1XdXs8YSQsZSQuZoXLqMEUec/2i2AiLk73P8KOq/azYdsqJm0yakL/8FY6VhU3iJ blbPXAXB9IxUFxyND049OFuSImTIHfDwAZNVln+w= Date: Fri, 14 Jun 2024 18:19:50 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm: handle profiling for fake memory allocations during compaction Message-Id: <20240614181950.d5cd06acba24339401c98d6d@linux-foundation.org> In-Reply-To: <20240614230504.3849136-1-surenb@google.com> References: <20240614230504.3849136-1-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 79F8740008 X-Stat-Signature: 3od17xkyxrytm5f155gkphj8nyj6ahdm X-Rspam-User: X-HE-Tag: 1718414396-194548 X-HE-Meta: U2FsdGVkX1/0BfV6Sfnavx59Ur/LYWalGOvISuQiH1yWgfaCpOC1xjc4L3Jx4Euuh/kVEjyL1Jqcdrp6Y3hDTdF68HKhbPTT9GAr38sYFRcKfRses/1W1xKgeQWAyat7qYyEMpqXvNsJcqEnb3XDFIXVSIJuUH0FhBixw/wC4I7HsQIOszGWXUmbvWj/k3/0WN1/mDS7lX3PVLAi8fUsSbjHxFUKEanCl4duVOX5/nHOLjc+lT9YHTofh7nJHsxXN4Xq23KMr3rYZKinVQcTX5QdS9oaWkPbYDBiDGpRolEHlAqvXlg7DROV+1s51biIj0lP53OpHNB4x7SiANjo4DXtxdwp9d/93YCIHPyYn/jjbcRH3tFUd/Ref2dI49KFZFAl3mSisS7XA+Vi6TxNHUMJ9fQITs51+DhD9j+ZeQ9o8CKKxlghNPJjtroGkDHtahgkfSOGsvz9TtVtcDwlDIbgOD8O95/Z3DVpi+RXINeoOfQHrqqWACaQ1vsWO+IonLKjZYIC9BZS2N1RKdhFrMAnlZzonkbbNFTclBOQfmt1VL0LpxbLRqMLhYJLKRaKh73A0HlDKxywK5ON9LPxsY6rktxPEJCJIjdlGV+c5Cz8xRBG7vs0UgF0q/0vTGM9LI7LY/CZcWZvnkMojWFCNNRkJZ6X0n5KHWurQCP7INiL4apK0sjvLftwrGoAIIyZAhCQlNM6yb7FjCi8JVamdN3gQhxgI+pCd5+Sf0bKbSUlTqXD07pO5CuSUDM4CaOAAztunwLfVS1N1lzitYLcJxZPaS305SKYDHq/FL1csDZDG9KCGRh+MUlaRIiSx3Wh3UYTh3EJ8kjZAlFQiHFrfrnBZZnUg+k4enEWOR5i9NkjGZK7zPGL0rtRV9HJc2J9wPw34LNd8y0SviqLaGaANfLZk++pxp0hTT1/ERoSxfljIWFHV0OvwuBb8U+dGBigQbDGDXnS1O/muR9LtgH dHm3eE1X CjhGqbUQ5/8kSkIcMBfi4CU8u1vyNP2TppJtP3s2sDVBXxPsDVEBpACDQgWTkU6fkfT6QGjHPlM2/n2mNYi6YLL7daF9G5HJLZxP9oOnE+d4erOSof/Y5euJ+Dli1/m+tPEFtxGWtXpO4FiIn4+PyjNq+ARTlqfJphC5SUiI03qUlVqmKyVEd6oszEwdjQB6adquB6NkJTfz/OwgHH31KIgHf56pBJllzoXzkCUXxSt8rhLeq3krnD4L0tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Jun 2024 16:05:04 -0700 Suren Baghdasaryan wrote: > During compaction isolated free pages are marked allocated so that they > can be split and/or freed. For that, post_alloc_hook() is used inside > split_map_pages() and release_free_list(). split_map_pages() marks free > pages allocated, splits the pages and then lets alloc_contig_range_noprof() > free those pages. release_free_list() marks free pages and immediately > frees them. This usage of post_alloc_hook() affect memory allocation > profiling because these functions might not be called from an instrumented > allocator, therefore current->alloc_tag is NULL and when debugging is > enabled (CONFIG_MEM_ALLOC_PROFILING_DEBUG=y) that causes warnings. It would be helpful to quote the warnings for the changelog. And a Reported-by:/Closes: if appropriate. I'm assuming we want this in 6.10-rcX? Please help in identifying the Fixes:, for anyone who might be backporting allocation profiling.