Re: [PATCH 00/15] add zpdesc memory descriptor for zswap.zpool

Alex Shi
2024-06-25T13:39:53Z

On 6/25/24 5:28 PM, Hyeonggon Yoo wrote:
>
>
> On Tue, Jun 25, 2024 at 5:11 PM Alex Shi <seakeel@gmail.com <mailto:seakeel@gmail.com>> wrote:
>
>
>
> On 6/25/24 5:46 AM, Yosry Ahmed wrote:
> > On Thu, Jun 20, 2024 at 10:42 PM <alexs@kernel.org <mailto:alexs@kernel.org>> wrote:
> >>
> >> From: Alex Shi <alexs@kernel.org <mailto:alexs@kernel.org>>
> >>
> >> According to Metthew's plan, the page descriptor will be replace by a 8
> >> bytes mem_desc on destination purpose.
> >> https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/ <https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/>
> >>
> >> Here is a implement on z3fold to replace page descriptor by zpdesc,
> >> which is still overlay on struct page now. but it's a step move forward
> >> above destination.
> >>
> >> To name the struct zpdesc instead of z3fold_desc, since there are 3 zpool
> >> usages under zswap, zbud, z3fold, zsmalloc. It looks like we may extend the
> >> zpdesc to zbud and zsmalloc, combined their usage into one.
> >
> > For zsmalloc, there is already an ongoing effort to split zsdesc from
> > struct page [2].
> >
> > [2]https://lore.kernel.org/lkml/20230713042037.980211-1-42.hyeyoo@gmail.com/ <https://lore.kernel.org/lkml/20230713042037.980211-1-42.hyeyoo@gmail.com/>
>
> David had pointed out this to me few weeks ago too. This patchset hasn't updated nearly a year. If Yoo don't object I'd like to pick up from his left and update it to latest zsmalloc.c.
>
>
> Hi Alex and Yosry,
>
> Thank you for mentioning this! I still believe the work is worth pursuing, but recently I haven't had the capacity to push it further.
>
> I'm on board with you taking it over and updating it with the latest source code. If you have any questions while bringing it up to date, don't hesitate please reach out to me.

Hi Yoo,

Thanks a lot for generous offer! I will update the patchset and send you for review ASAP. :)

Cheers!
Alex