From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Klara Modin <klarasmodin@gmail.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Suren Baghdasaryan <surenb@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH] sched/task_struct: Move alloc_tag to the end of the struct.
Date: Fri, 21 Jun 2024 12:27:50 +0200 [thread overview]
Message-ID: <20240621102750.oH9p1FQq@linutronix.de> (raw)
The alloc_tag member has been added to task_struct at the very
beginning. This is a pointer and on 64bit architectures it forces 4 byte
padding after `ptrace' and then forcing another another 4 byte padding
after `on_cpu'. A few members later, `se' requires a cacheline aligned
due to struct sched_avg resulting in 52 hole before `se'.
This is the case on 64bit-SMP architectures.
The 52 byte hole can be avoided by moving alloc_tag away where it
currently resides.
Move alloc_tag to the end of task_struct. There is likely a hole before
`thread' due to its alignment requirement and the previous members are
likely to be already pointer-aligned.
Fixes: 22d407b164ff7 ("lib: add allocation tagging support for memory allocation profiling")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/linux/sched.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 61591ac6eab6d..d76c61510ef1d 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -770,10 +770,6 @@ struct task_struct {
unsigned int flags;
unsigned int ptrace;
-#ifdef CONFIG_MEM_ALLOC_PROFILING
- struct alloc_tag *alloc_tag;
-#endif
-
#ifdef CONFIG_SMP
int on_cpu;
struct __call_single_node wake_entry;
@@ -1553,6 +1549,9 @@ struct task_struct {
#ifdef CONFIG_USER_EVENTS
struct user_event_mm *user_event_mm;
#endif
+#ifdef CONFIG_MEM_ALLOC_PROFILING
+ struct alloc_tag *alloc_tag;
+#endif
/*
* New fields for task_struct should be added above here, so that
--
2.45.2
next reply other threads:[~2024-06-21 10:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 10:27 Sebastian Andrzej Siewior [this message]
2024-06-21 14:20 ` [PATCH] sched/task_struct: Move alloc_tag to the end of the struct Kent Overstreet
2024-06-21 18:29 ` Sebastian Andrzej Siewior
2024-06-21 18:49 ` Kent Overstreet
2024-06-21 19:07 ` Sebastian Andrzej Siewior
2024-06-21 19:13 ` Kent Overstreet
2024-06-21 19:22 ` Sebastian Andrzej Siewior
2024-06-28 9:49 ` Sebastian Andrzej Siewior
2024-06-28 19:20 ` Andrew Morton
2024-06-28 19:35 ` Kent Overstreet
2024-06-28 19:55 ` Sebastian Andrzej Siewior
2024-06-28 20:20 ` Kent Overstreet
2024-06-30 21:11 ` Sebastian Andrzej Siewior
2024-06-30 21:23 ` Kent Overstreet
2024-07-01 8:05 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621102750.oH9p1FQq@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=klarasmodin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).