From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDAC5C2BD09 for ; Mon, 24 Jun 2024 23:43:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 742A76B0373; Mon, 24 Jun 2024 19:43:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F1F26B0374; Mon, 24 Jun 2024 19:43:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 593556B0375; Mon, 24 Jun 2024 19:43:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B50B6B0373 for ; Mon, 24 Jun 2024 19:43:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E1FEA161411 for ; Mon, 24 Jun 2024 23:43:22 +0000 (UTC) X-FDA: 82267411044.04.11D2DEC Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf11.hostedemail.com (Postfix) with ESMTP id 0656540016 for ; Mon, 24 Jun 2024 23:43:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="e/kknAwx"; spf=pass (imf11.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719272594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hY2K9GopRcIQo+YJLXvn9mGgJ92g9HFvHPeUzyN20HQ=; b=l1Y8JQUszxqbQv0I15RujTcxAnG9N9VXvZJuVFGlD8HFXIbBpY2c7HgK+bySq+JSOyRR0c sW8Lm4jG+51JwGdOgXm2zr0322uSaX+XqHgIJ05dLNE2nb/cDOC4Bpc8NU3Uq38nNSs+Ah TqFlHaX6i6LCvLcvqSK7wTC+GgdmSyk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="e/kknAwx"; spf=pass (imf11.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719272594; a=rsa-sha256; cv=none; b=NL7riEhkJJY1QsNhlxhIyu8zkilSA0zzGd/9ZXOvIoTHWKLJodyVQ/Giv1w0oM2tzZjGmF xAQAmJcyTfhMPJeD/3RFcjlPt0eF/ZD8CTGUEPaU41tGxGnpQgHu7axr3fqdZvtDJCpOyu jX75Joa1253xELJiVcKZruJTN0lBYrk= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f65a3abd01so39822515ad.3 for ; Mon, 24 Jun 2024 16:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719272600; x=1719877400; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hY2K9GopRcIQo+YJLXvn9mGgJ92g9HFvHPeUzyN20HQ=; b=e/kknAwxVUObGjZOmp9Xu+3Yd8lDb5CJuMcw8wrywKwu1Bm+2cfZiqyBmPfZXpWm14 5xy2hEs8OdR3IgydfabxdXtt+y2hmP5hxwR06n6B2pX5towHZHoVefwoEH6CXOkOGWqM Vd8w/AkhRx3V771bJn56ClXLnRfW/qeTRqqGqgD0kDjDP9OBtNzSrmBJ9le8Zv+pZO/k FXy4nJfk598INim2MYKAUnJz2FBcSBQHwYpIcPPNoiGbnPeAn/4XstlsuHvf8bwL7OR0 NFg0YK1mCV1+UgnG5OLwfeJQFhRxBqhN0f0Lb7N4v5NuQQ0KLFaWJrK3QtGbItwRI+F1 TZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719272600; x=1719877400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hY2K9GopRcIQo+YJLXvn9mGgJ92g9HFvHPeUzyN20HQ=; b=RmAMc19N9kI95/vaVq2DS63BESIv8LPrBbMd851fu0qSulW3QRL4UGE4aCxv8VWbWK 1O351SrqR6l7Xfh4wwGHY9UUK35GdZMpLg3Lri8g9DVCXvPcj2+VN2795WNuNIKYG4AR sZndvYuXjQMLVtEGa71bqt5CBOfsF+/tvE776TaSZA4oLlV6TAAxtxTv2lpixhiFWCC3 gVibwyJsJzM5EiMBNj70KzBe+i2NPVsUxwwS9rn0I6i1hPZ2XezmOknXHuEKxJG5RXy7 bznvVs6lDBPSr+tj0MYhbPozFBk9J2nqYDw5W78l8gp6wuhCug1MIo/dA3rJheUPjrlf ljWg== X-Forwarded-Encrypted: i=1; AJvYcCUiEtJANR+0HHeUpFmgjavMeIymKyqBvTpvSwvK+sWhLFnAjAuuvFd5VSoRPDj+NIlS6Bk1TdyJqVSHCnyV0cCgIyc= X-Gm-Message-State: AOJu0YwJrAtpxN3IqZlslXDewQ5PV/2iDuvhYUR9zbmQ8mxTVa6rsuhK 9Qz7tVz8iljfHkjOQSOG7CYa+KNgWXw4AitKO1PfIZa5FwjiIDOK X-Google-Smtp-Source: AGHT+IGSxorLizB8AR7/J3uCktEH93ZdZ4u3fCevV9GzYQT1KAzX86bCpFjKQ9gbyeEhBYh+XcIrvA== X-Received: by 2002:a17:902:d2cc:b0:1f8:64e2:73e4 with SMTP id d9443c01a7336-1fa23ecacd5mr92527845ad.21.1719272599693; Mon, 24 Jun 2024 16:43:19 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3c6156sm68035245ad.138.2024.06.24.16.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 16:43:19 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuanshuai@oppo.com, yuzhao@google.com Subject: Re: [PATCH v2 2/3] mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)==false Date: Tue, 25 Jun 2024 11:42:53 +1200 Message-Id: <20240624234253.14513-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624162503.61996134e5e148eea93960af@linux-foundation.org> References: <20240624162503.61996134e5e148eea93960af@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0656540016 X-Stat-Signature: 17dqjz75ofjddhbjhbmxfrsuy6q4aaa4 X-HE-Tag: 1719272600-147472 X-HE-Meta: U2FsdGVkX19R4VSDxC3jdp4K7OCZh6OVwr6mDRimS2n7yP8PYEEgXnOOW7WPH6+8NtiH1IYAWvtptZvHYJdKUhPbbiMC+83RDqeEwGKmeJLcvVDmHNiF/WrqJ2wYdW5K4JyrpZYsgijHplHO05E4lFXRRRCMvcBUCEuKPomB/Y5fhuixDaMUMH+UBCK86aFSQGdZup18HlqYtRNb3UdmDEoaLDAte9CDXsmSrP9TrRM3489cVDOzXWG29ugbn7HmKMgZ6Grbf2zFYMyAPWzLnBat4URiBcpZPQgTpdKhIjFOGmHrhTVrUfCGK1r9THgr/ap1TkgASh4vyLPJMXRMztSjCM/McyQlnycv60iiz2RaC2qiNB3Jdm5l8q0oBPF5E7ZJuTy4S54/3hc4EiiWIVm/8QchULXMJPEpnQT4EBiULk8B398RqKxqcCINynx2TTcN4YWaHx6Kr0r3ahLrXDGq7mGKoPuj6SUjvGm++ERzdpRwRMgPMTfFoU4zuv2JMTo1sq2boClWI9bsECLvlr44VHPiha6yc0otT34c2I3R0VvGrmZEUrQx55Sk9+rQcFa9NWLTIvSxTEIWouvVyMoEaFeG/jEX0pJT5PfYSPJTk+jnyPREB3EI91TBhJrRhd8XS4qh+OteQcfXOoSz5GMCtiYPfTcoHzR6rKu8Tqne4+GWx5yjCq+ocsiKIo1HfIUVEADh7Y6mdKPUIww2XCyr9nfzx3RzHYy7IR9GLty3QBe6lHrNOUzU+AMqBN2r1sjZHbcKBMP8waRAASeOVUu9PV+rAtKu1b2RTA/+/8RfPBpt31IKFRGrkS+neBc3cyfkogGN5tMXYavgulJsM1NEdpFa9uC3vppyhb9745JDIDEgw4fYZsrePbymNvkIpr55dIYS7i+QGrt0YFj9qnwSKCG7h9CpC69AnAwdB4m1xxqF3ojqZDp3dtf3WknTSaY8WF7+XzF55D3KbnZ 7PgCt/aY aElBwR9aGMHbNKFTnYowr9HCjda63zxaxjTjs2g1SjfoL7pK2Sz4HCbeqHXkA2EARhknM7ce2Qcu/Lmn3a4iLL2ioQyDF0W9IMbHs8IdY41JQbJP2iv8aqXOWEdvTATRI3XPg1X/EwRZWGzFDxbmpBU3Mdu0t5UFyiQLDdQ13e+TLyCkoYIMmROvNtSeBYCI7S+B4mIhdafV+kLGgGwycSvs2YzD4PXV0o3bfNT+lzR5JVI0JgZ6BlqMN+IZIjfCb+0DWKgJ6yeFeXHlrk1GOpx7a0zMH65BxM7t47geliBQubuzAwXxs668iHuxa5W1ZkB3jHlgztWn0ekiThlb21syV6YyjIFAXKO6ojzA4oxgFXU6dXX1VEja4in3bODGRT9u+oAa1FhDQitvkeIwxVmM5/Iv6AU6NkVlYxvN9MIBARHF+QJwOHhR880/hAo5OoStcruFBxG5fmELRjTwOhXhspnZZCIdDZC/yPJzrKXARKOiAg35Sbbi7YRpWqJHU2zOjBNDCBwvBqn29s3Bk9bPb3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 11:25 AM Andrew Morton wrote: > > On Sat, 22 Jun 2024 15:20:02 +1200 Barry Song <21cnbao@gmail.com> wrote: > > > > > > > > > Since this is primarily a documentation update, I'll wait for two or > > > > three days to see if > > > > there are any more Linux-next reports before sending v3 combining these fixes > > > > together(I've already fixed another doc warn reported by lkp) and seek Andrew's > > > > assistance to drop v2 and apply v3. > > > > > > Feel free to send fixup patches for such small stuff (for example, as > > > reply to this mail). Usually, no need for a new series. Andrew will > > > squash all fixups before merging it to mm-stable. > > > > Hi Andrew, > > > > Can you please squash this change(another one suggested by David)? > > sure, but... > > > From: Barry Song > > Date: Sat, 22 Jun 2024 15:14:53 +1200 > > Subject: [PATCH] enhance doc- mm: use folio_add_new_anon_rmap() if > >  folio_test_anon(folio)==false > > The only description we have here is "enhance doc" > > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -4346,6 +4346,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > >                * here, we have to be careful. > >                */ > >               VM_WARN_ON_ONCE(folio_test_large(folio)); > > +             VM_WARN_ON_FOLIO(!folio_test_locked(folio), folio); > > And these aren't documentation changes.  Please send along a small > changelog for this patch. Thanks for the suggestion. Could we have this in changelog? For new anon(!anon), there's a possibility that multiple concurrent threads might execute "if (!anon) folio_add_new_anon_rmap()" in parallel. In such cases, the threads should lock the folio before executing this sequence. We use VM_WARN_ON_FOLIO() to verify if this condition holds true. > Thanks Barry