Re: [PATCH v8 02/10] filemap: allocate mapping_min_order folios in the page cache

Matthew Wilcox
2024-06-25T15:52:16Z

On Tue, Jun 25, 2024 at 11:44:12AM +0000, Pankaj Raghav (Samsung) wrote:
> Co-developed-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

after fixing the nits below

> +/**
> + * mapping_align_index() - Align index based on the min
> + * folio order of the page cache.

+ * mapping_align_index - Align index for this mapping.

> @@ -1165,7 +1186,7 @@ static inline vm_fault_t folio_lock_or_retry(struct folio *folio,
> void folio_wait_bit(struct folio *folio, int bit_nr);
> int folio_wait_bit_killable(struct folio *folio, int bit_nr);
>
> -/*
> +/*
> * Wait for a folio to be unlocked.
> *
> * This must be called with the caller "holding" the folio,

Unnecessary whitespace change