Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size

Christoph Hellwig
2024-07-03T05:16:24Z

On Tue, Jul 02, 2024 at 05:10:14PM +0000, Pankaj Raghav (Samsung) wrote:
> > > Yes, I will rename it to ZERO_PAGE_SZ_64K as you suggested.
> >
> > No. It needs a symbolic name that doesn't include the actual size.
> > Maybe ZERO_PAGE_IO_MAX. Christoph suggested using SZ_64K to define
> > it, not to include it in the name.
>
> Initially I kept the name as ZERO_FSB_PAGE as it is used to do sub-block
> zeroing. But I know John from Oracle is already working on using it for
> rt extent zeroing. So I will just go with ZERO_PAGE_IO_MAX for now.
> Understood about the SZ_64K part. Thanks for the clarification.

IOMAP_ZERO_PAGE_SIZE ?

(I kind regret not going for just adding zero page as originally
suggested, but then we'd keep arguing about the nr_vecs sizing and
naming :))