linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	 Steven Rostedt <rostedt@goodmis.org>,
	 Masami Hiramatsu <mhiramat@kernel.org>,
	 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	 Chandan Babu R <chandan.babu@oracle.com>,
	 "Darrick J. Wong" <djwong@kernel.org>,
	Theodore Ts'o <tytso@mit.edu>,
	 Andreas Dilger <adilger.kernel@dilger.ca>,
	Chris Mason <clm@fb.com>,  Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,  Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,  linux-xfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,  linux-btrfs@vger.kernel.org,
	linux-mm@kvack.org, linux-nfs@vger.kernel.org,
	 Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 03/10] fs: tracepoints for inode_needs_update_time and inode_set_ctime_to_ts
Date: Wed, 26 Jun 2024 21:00:23 -0400	[thread overview]
Message-ID: <20240626-mgtime-v1-3-a189352d0f8f@kernel.org> (raw)
In-Reply-To: <20240626-mgtime-v1-0-a189352d0f8f@kernel.org>

Add a new tracepoint for when we're testing whether the timestamps need
updating, and around the update itself.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/inode.c                       |  4 +++
 include/trace/events/timestamp.h | 76 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+)

diff --git a/fs/inode.c b/fs/inode.c
index 7b0a73ed499d..5d2b0dfe48c3 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -22,6 +22,8 @@
 #include <linux/iversion.h>
 #include <linux/rw_hint.h>
 #include <trace/events/writeback.h>
+#define CREATE_TRACE_POINTS
+#include <trace/events/timestamp.h>
 #include "internal.h"
 
 /*
@@ -2096,6 +2098,7 @@ static int inode_needs_update_time(struct inode *inode)
 	if (IS_I_VERSION(inode) && inode_iversion_need_inc(inode))
 		sync_it |= S_VERSION;
 
+	trace_inode_needs_update_time(inode, &now, &ts, sync_it);
 	return sync_it;
 }
 
@@ -2522,6 +2525,7 @@ EXPORT_SYMBOL(inode_get_ctime);
 struct timespec64 inode_set_ctime_to_ts(struct inode *inode, struct timespec64 ts)
 {
 	inode->__i_ctime = ktime_set(ts.tv_sec, ts.tv_nsec);
+	trace_inode_set_ctime_to_ts(inode, &ts);
 	return ts;
 }
 EXPORT_SYMBOL(inode_set_ctime_to_ts);
diff --git a/include/trace/events/timestamp.h b/include/trace/events/timestamp.h
new file mode 100644
index 000000000000..35ff875d3800
--- /dev/null
+++ b/include/trace/events/timestamp.h
@@ -0,0 +1,76 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM timestamp
+
+#if !defined(_TRACE_TIMESTAMP_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_TIMESTAMP_H
+
+#include <linux/tracepoint.h>
+#include <linux/fs.h>
+
+TRACE_EVENT(inode_needs_update_time,
+	TP_PROTO(struct inode *inode,
+		 struct timespec64 *now,
+		 struct timespec64 *ctime,
+		 int sync_it),
+
+	TP_ARGS(inode, now, ctime, sync_it),
+
+	TP_STRUCT__entry(
+		__field(dev_t,			dev)
+		__field(ino_t,			ino)
+		__field(time64_t,		now_sec)
+		__field(time64_t,		ctime_sec)
+		__field(long,			now_nsec)
+		__field(long,			ctime_nsec)
+		__field(int,			sync_it)
+	),
+
+	TP_fast_assign(
+		__entry->dev		= inode->i_sb->s_dev;
+		__entry->ino		= inode->i_ino;
+		__entry->sync_it	= sync_it;
+		__entry->now_sec	= now->tv_sec;
+		__entry->ctime_sec	= ctime->tv_sec;
+		__entry->now_nsec	= now->tv_nsec;
+		__entry->ctime_nsec	= ctime->tv_nsec;
+		__entry->sync_it	= sync_it;
+	),
+
+	TP_printk("ino=%d:%d:%ld sync_it=%d now=%llu.%ld ctime=%llu.%lu",
+		MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino,
+		__entry->sync_it,
+		__entry->now_sec, __entry->now_nsec,
+		__entry->ctime_sec, __entry->ctime_nsec
+	)
+);
+
+TRACE_EVENT(inode_set_ctime_to_ts,
+	TP_PROTO(struct inode *inode,
+		 struct timespec64 *ts),
+
+	TP_ARGS(inode, ts),
+
+	TP_STRUCT__entry(
+		__field(dev_t,			dev)
+		__field(ino_t,			ino)
+		__field(time64_t,		ts_sec)
+		__field(long,			ts_nsec)
+	),
+
+	TP_fast_assign(
+		__entry->dev		= inode->i_sb->s_dev;
+		__entry->ino		= inode->i_ino;
+		__entry->ts_sec		= ts->tv_sec;
+		__entry->ts_nsec	= ts->tv_nsec;
+	),
+
+	TP_printk("ino=%d:%d:%ld ts=%llu.%lu",
+		MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino,
+		__entry->ts_sec, __entry->ts_nsec
+	)
+);
+#endif /* _TRACE_TIMESTAMP_H */
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>

-- 
2.45.2



  parent reply	other threads:[~2024-06-27  1:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  1:00 [PATCH 00/10] fs: multigrain timestamp redux Jeff Layton
2024-06-27  1:00 ` [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Jeff Layton
2024-07-01 22:49   ` Darrick J. Wong
2024-07-02  0:22     ` Jeff Layton
2024-07-02  7:37       ` Christoph Hellwig
2024-07-02  9:56         ` Jeff Layton
2024-07-02 10:19           ` Jan Kara
2024-07-02 11:42             ` Christian Brauner
2024-07-02 11:44             ` Jeff Layton
2024-07-02 12:04               ` Christoph Hellwig
2024-07-02 12:09                 ` Jeff Layton
2024-07-02 12:15                   ` Christoph Hellwig
2024-07-02 12:21                     ` Jeff Layton
2024-07-02 15:12                       ` Christoph Hellwig
2024-07-02 15:58                         ` Jeff Layton
2024-07-03  5:26                           ` Christoph Hellwig
2024-07-03  5:27                             ` Christoph Hellwig
2024-07-02 16:18                       ` Christian Brauner
2024-06-27  1:00 ` [PATCH 02/10] fs: uninline inode_get_ctime and inode_set_ctime_to_ts Jeff Layton
2024-06-27  1:00 ` Jeff Layton [this message]
2024-06-27  1:00 ` [PATCH 04/10] fs: add infrastructure for multigrain timestamps Jeff Layton
2024-06-27 15:02   ` Chuck Lever
2024-06-27 15:35     ` Jeff Layton
2024-06-27  1:00 ` [PATCH 05/10] fs: add percpu counters to count fine vs. coarse timestamps Jeff Layton
2024-06-27  1:00 ` [PATCH 06/10] fs: have setattr_copy handle multigrain timestamps appropriately Jeff Layton
2024-06-27  1:00 ` [PATCH 07/10] xfs: switch to multigrain timestamps Jeff Layton
2024-06-27  1:00 ` [PATCH 08/10] ext4: " Jeff Layton
2024-06-27  1:00 ` [PATCH 09/10] btrfs: convert " Jeff Layton
2024-06-27  1:00 ` [PATCH 10/10] tmpfs: add support for " Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240626-mgtime-v1-3-a189352d0f8f@kernel.org \
    --to=jlayton@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=chandan.babu@oracle.com \
    --cc=clm@fb.com \
    --cc=djwong@kernel.org \
    --cc=dsterba@suse.com \
    --cc=hughd@google.com \
    --cc=jack@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).