From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75739C2BD09 for ; Thu, 27 Jun 2024 05:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A4786B0089; Thu, 27 Jun 2024 01:23:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 954936B008A; Thu, 27 Jun 2024 01:23:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843536B008C; Thu, 27 Jun 2024 01:23:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 67B376B0089 for ; Thu, 27 Jun 2024 01:23:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CB17C161A49 for ; Thu, 27 Jun 2024 05:23:06 +0000 (UTC) X-FDA: 82275524772.19.E622321 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id D6FB0C0012 for ; Thu, 27 Jun 2024 05:23:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719465772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZrhS5j2tpNuapMBjnR2OBbRY3cDgyEXdp08RHEurYmQ=; b=oBPSusmVVOz2nEyhdWfql5YBysoSIE/pkXecf8vMizP/cp19IgQONg7hl/ciAIh6W2ET19 hLRxhrGUxLlSShSUuOAx8uKIJneRje41P0FmjON6iUZ/Fh0bVUAJAKb9iTx1HhCbNAzTRE ndIsgPQ19K5Yx1m94CdBsqcCdwo9zKw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719465772; a=rsa-sha256; cv=none; b=odzyauOKUMfwBsOs3FRHPA1hLg7u6/hMJ5X1P++4k5DliGJXOYXG/wG0x8iIGw6OHPztj4 yqTfpWQWQ2dDLqpH9G+S+rNqEULYV7QFxt0yP/DJLTbh/FW5sGAyJ7KeEUbvfHh3VgTU8l Z0HSbKK4FjzBcpcKAb+lWJWkxBlqO4A= Received: by verein.lst.de (Postfix, from userid 2407) id 316B468AFE; Thu, 27 Jun 2024 07:22:59 +0200 (CEST) Date: Thu, 27 Jun 2024 07:22:59 +0200 From: Christoph Hellwig To: Alistair Popple Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com Subject: Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn Message-ID: <20240627052259.GA14837@lst.de> References: <50013c1ee52b5bb1213571bff66780568455f54c.1719386613.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50013c1ee52b5bb1213571bff66780568455f54c.1719386613.git-series.apopple@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: nt5q4gqzzqeukz1quxfirph5fe3ccpya X-Rspam-User: X-Rspamd-Queue-Id: D6FB0C0012 X-Rspamd-Server: rspam02 X-HE-Tag: 1719465784-715040 X-HE-Meta: U2FsdGVkX1/yaQFUr33LrnX2j0NP/bVxvWshyas+mB0GR1o5d4NKTFLMrAqSoAt9wPpBY46qYkHC1HhqxOupfdccO4SS0+lkLzQRwDn4G7E74dPM0luB788AV/U48yEW+IuOOCkw45cuJBKmnAlXfJDkP61tfTfEBjfz9ThmBu5zO5S8DBeHBR++8vcOvfQxvA49PCYN6TGjPaCrMXU82eB6oCPMLBxS5fPvRk28nC6nnyfdKp/+0ZmvkQuBddD6Fe/ddigkMhqSzrHl/KKubD/7yWZszUS3NEwJ0fTHFpefQPt4MhYcUlZEmkG1lP5tAS1QIUdgYpq2WZ9hnfa4+rVcYkuEDG7tZvg8wCaGl3bIQm3DOM+6dXifxB+nTvcqHklRaxRR7BtX/vsdHCa9ItCbAIxqrm/1LDErnD0wZJP72BjYVb083brUnO7GaKScx0/2XnOxew/nuAItPMtDP0Ue01nbdGrqfbX0FxbMvXt67Yj5kIkO+CU1nL6+tPixbUkmq7tm82/FhbzyLCdbuZ344+78dNj4ZLfDvtSeSx2692IYPoV89bke0Iiequ5tR2uEmdcG8ix3xHZ7DXUY4htK8unHYnLt9ZQHFx6RtLqt0xD5HPhNlm/2RM8OotWycIZFWDk30FcTptPZ9dHmBDAVX2rJKw+qrZ3Y8+b7+m22Xh9R6ny0Hpt26f7bICDzTtD4bZViR2USbIxP9brAm/nYXy96WXrmwjbjpj5iOCEJ0hrrEX3lCs8AFsYSAdtTwAcDLh0aNjLbDtzWCW2wciAlL38epVtrf7k8szRkcl9tz+CjIQetlgj93ta4q1aTSCi9mgyy4DLubDQrRmL6001GenvzuFBuKyrAwavZVSiwnSPbkKXycnIkoLnTsOlfNBiRKb2vvSwOYbuo7+65mw7WufS1dSfyMdz/99wRUY50e4ps38xBXlFmbmRz1E67Mlx5Y3IDnYJ+BdMQFWv P8iL6Mjp 0HqRDTWpdnbNUfkkv+3UKOPW0fXvXtY5qbVMaUTxmQtM3lVybOcqJlW68Y0kmoLZGfYfD25D5QUBoPFqNC+OnGBDVPhjXsOd4bTLlx2jm8I3U2K8wXkEJHwxy8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 10:54:21AM +1000, Alistair Popple wrote: > +extern void prep_compound_page(struct page *page, unsigned int order); No need for the extern. > static int insert_page_into_pte_locked(struct vm_area_struct *vma, pte_t *pte, > - unsigned long addr, struct page *page, pgprot_t prot) > + unsigned long addr, struct page *page, pgprot_t prot, bool mkwrite) Overly long line. > + retval = insert_page_into_pte_locked(vma, pte, addr, page, prot, mkwrite); .. same here. > +vm_fault_t dax_insert_pfn(struct vm_area_struct *vma, > + unsigned long addr, pfn_t pfn_t, bool write) This could probably use a kerneldoc comment.