From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4705EC3064D for ; Thu, 27 Jun 2024 05:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE2EC6B0088; Thu, 27 Jun 2024 01:31:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A92CA6B0089; Thu, 27 Jun 2024 01:31:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 982416B008A; Thu, 27 Jun 2024 01:31:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7C6C66B0088 for ; Thu, 27 Jun 2024 01:31:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 30CD8161A64 for ; Thu, 27 Jun 2024 05:31:29 +0000 (UTC) X-FDA: 82275545898.10.9537C29 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf18.hostedemail.com (Postfix) with ESMTP id 7A3F61C000B for ; Thu, 27 Jun 2024 05:31:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719466274; a=rsa-sha256; cv=none; b=DsJpIV0J7vygfuONNfN5B86QUMuwR0nYjShDAUZ98Q86Cufwwrx7hUP18CLOFWvnAlYdHs ChlPJW9zrw4qdw5TetT17+c3j8B6cvuOdQMGiqXogid2te/n+CoRsSOesFc/oUVsvCN88d Getl4MyvMiNMAhhSBzOBKkSlfZOkOVo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719466274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKvZZB2/j2QGUN7plpqzQdBsrGB8EoUhz+a1ph+qvAM=; b=2eCBEdLTV5JUdJVbam29xLd8BOuVWyj7OVYO5FD2XW/p3FJL0ngtUfvUlOee/KTj8Ps3CD zA3OvlBTt24Cr1Yr5zGW4YwuDUGZVnlFP77r8xwS5p2syeDVXNmoE30zvuugsgViPUuT/8 +GB3wdEJ4JmP+qBZgthU491qerzkpkE= Received: by verein.lst.de (Postfix, from userid 2407) id A5B7B68AFE; Thu, 27 Jun 2024 07:31:24 +0200 (CEST) Date: Thu, 27 Jun 2024 07:31:24 +0200 From: Christoph Hellwig To: Alistair Popple Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com Subject: Re: [PATCH 03/13] fs/dax: Refactor wait for dax idle page Message-ID: <20240627053124.GC14837@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7A3F61C000B X-Stat-Signature: n3eeakh74bmwpfsanm6ei531mcmg99xi X-Rspam-User: X-HE-Tag: 1719466287-573461 X-HE-Meta: U2FsdGVkX18ukE/sqcAV6z84r7TuOC1gtL7mo9iUnrNC47CRO35Dd7AMZIoBaEmu5WzXYtXU0rEjTs1bAwIGiROhZse/FPRwHmBHb1TeFT4AQkuCu43xb9/Lf4e477b4W82Z7hdBmCO4rMZSa7Cb5pkutOQcFuhNBmoHtCp4kDHXL3ghLxnBKNBMdMsu6ikBHLSkb7Ea2iYffbX/oegyZSNCR/kWJRy7uGPvy3km+vCc/QRWlsqpriRFKTGzHN6KWsbpg0oL7T5zHVTBcTEr4DC4xFGgvwe1CTq0OUbrsNZhkbyy75p/ztcujJySzE3kxrbVqR4aTXKD0ex/MqaMzPAXQn6KUVL7QfiD2Kwz0PrQZGUCf6Q1edYPcodRV8G0jCOBzptJKsgEeWdzmyNw5NNuLEW5vYzg5Fp0Ng99BxRkuZoSSBvTdm3WZCuwm860Kk2Krm1hymROVEuG398N4f8ORjaa3AIyfL8uU+8cBqQyl0KzIc4/yCxWvR0i9fLwYXpJHgQtA9yzBXxeytuZRcXd5b9hiaHMGP96jd7OiKrVPrSMOI3NC3qi8vO6VhRD2WzTdCmiOK/1I1qBKGCDVbDYqHK+V55hF+HabXY6pEToLotka51rlw5tWwhrIISUrX3vgjRGmCArgcLnvXe5cjXU1cPFdLssWsXZEQlQYPq8cICLoitmi790aXB1tYgN3HWxN0BHh7az0+SIgmDeakxGJSGuoB7zKZwS3DwgEgnYioK/dFe2IZkVkhw3yipvX8GLnLY8r9V/xoQplCsQ1f5HIZo2EMgmZzS/kV1TCjjzVX4ViM5OSgEZRDJxeJd3wgHvZ+9i5fpUI8pTTCjNmxzWAMY2z1nQDxtMirLsd16QIGfnPY/UTkSfYNK+TP4o12y5MoSguJdZEmRqmLaTtGgk6RK4Bwhe+TXpLU2PmBIJXfc/QvJY1T9QVkb4ezDafFFKrzdT68YgbhieEdx ONQoD+ZE Ctf5fBSyx7COTgcVAfObfjLUqUPdSUx9iYkbNquogFVY+JSqHELJRwjraUVhve7RZRKusP1KNkCxuD01kzJhBn2EF8inJ3JY/2yo5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 10:54:18AM +1000, Alistair Popple wrote: > A FS DAX page is considered idle when its refcount drops to one. This > is currently open-coded in all file systems supporting FS DAX. Move > the idle detection to a common function to make future changes easier. > > Signed-off-by: Alistair Popple > Reviewed-by: Jan Kara I'm pretty sure I already review this ages ago, but: Reviewed-by: Christoph Hellwig