From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C94BC2BD09 for ; Thu, 27 Jun 2024 21:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93BCB6B008C; Thu, 27 Jun 2024 17:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C4746B0092; Thu, 27 Jun 2024 17:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7642C6B0096; Thu, 27 Jun 2024 17:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5475D6B008C for ; Thu, 27 Jun 2024 17:11:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 01AE6A1084 for ; Thu, 27 Jun 2024 21:11:30 +0000 (UTC) X-FDA: 82277914782.11.451B57E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 389E540019 for ; Thu, 27 Jun 2024 21:11:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=graBvNMx; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719522676; a=rsa-sha256; cv=none; b=UEyqwd6R/uSFmGo/AhgA2r691R4zqFlqMWc7OgWVx4mhSbkkAiFnMRkUCzzJQJLj08cvRl 740DTAJBhRfiSf5J5UBp6ifdlu8Dl9VznM78baEsFoum7g+gIX2I+1sH6sYM17A7FdtuAr Nj5jYmhrd7bIxodm7yIPf4jQSZUxFxk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=graBvNMx; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719522676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=39HhuwkWrHc9h7+onEkyKJV8ejYTfzsToOfVPoxCNBs=; b=CWResqn4lYQve00tqpWKgkg77jpo2Eu4fXgmgGABn1sNbV/bc2RvKWDtpE/1HqxY0DXHdx LH5peRkN7v05LA4iScCemUawFYo3YpCFREi+Hk53scYkHkRxM/VtwhfhDDyXxqhgLTCaMC O9XwcTvwILtchP6QAudSZCelThwjJdw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0465061EDB; Thu, 27 Jun 2024 21:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B704C2BBFC; Thu, 27 Jun 2024 21:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719522687; bh=h4fznHZ9EntuAr9QS1NNKb31QjCnz8JZ/U98Q+re5wM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=graBvNMx8coJNsHdTjJ9iXpx8DFJ5PLgHyiN9wF+ufjij7NYD/yQDRoACOewsLcGV xwoS4wT25CwQWUBbJJ+gQYG7OtHo1pMdoCj6eu8SC6kXfVppzh+qrQgmuBhEWx4QsG WWuKX0xXfO1kQ40CfL4zAVQ8ZfBWIibD5SZlogXo= Date: Thu, 27 Jun 2024 14:11:26 -0700 From: Andrew Morton To: Andrii Nakryiko Cc: Andrii Nakryiko , linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, liam.howlett@oracle.com, surenb@google.com, rppt@kernel.org, adobriyan@gmail.com Subject: Re: [PATCH v6 0/6] ioctl()-based API to query VMAs from /proc//maps Message-Id: <20240627141126.2ce3b4981e4f580713e31be0@linux-foundation.org> In-Reply-To: References: <20240627170900.1672542-1-andrii@kernel.org> <20240627125938.da3541c6babfe046f955df7a@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 389E540019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k6cqdsz5zz78tkmhy7mupfejd8g6ow6a X-HE-Tag: 1719522689-519755 X-HE-Meta: U2FsdGVkX1+/YaOo3hX6ne5v1soBg8vfmTD2m1hKD4GWyN+P0Nw0TAhVHx7Drr5xWAAUOuqp6xwE8569UmdpG5+4GAMlvOLx0pKWmkqtN7v3EyVqrg+XYliPLPRFmGT4HV/1DpG7ej0yKOCiqdfetYPezh/o6cVr5IrTq89pU+QudoBdL0Tv39FG/cIf0Dsi1LAGuQhzTR/Wq2wd1d2pnDCdNmQ+PRljyUDxI4XukNHluWafWBQbVw60mftvnKMntDxH/I+hCmhtfNP9q/UmEeYu5mEF49k3kZcdJDgfNql3+qO1/l2K4ecKco2vimR+d3FyNq807R2LARmbQAWG1uIM3sAsjAMHg/nB4sRn1eqjDjTUfTS9/BhusKN3ZZpi/H6i3L2mF6aGAh4JH8Lcz6uL1CzaxinX8F34KBTYEVuDgLwqwoUweaz3dyLLo/wG+kumQv2ee4+VhoUnGZmaP1GSe8mCgAIhqev1ZhCRSbPMOtI/r5JVjn3MlD4OFRfXPeVgY1zQ0aOVwEIKEKanPSdigd8KJVKPL7mh5QGVC/FwLm0ksTM3ZTf188ZQheuzZlX1n8MXkkK6IOrIsfAB2Eim196/qNxqD6FqHW+EI3EE1FYtjFh83CdVCRqRbNX6hrJoCEaCJtCRx6uJ7FLojirmwBuztFoJziy8VKQGhhBPMLl/Ths3lmre7g7dVslvaf/zTM/HVMyGeaBwDRp3PqkA/NJM4mzamjfWYyE/X/pGzjlQQcs72rqTJM6SiMHqgtaJRAJzkb15KRRAOWakBXGDJwXMCx88JgI9L1lkq94aln5pzmdaVXzI4IQGmSzgIjk7zeJW84U/Ttx/TtchjyKlvwiR0z4eZInzC/sAgwrna/cMhCtgz1hcgaLyi8H2KieYasObdEBxEDbYmzmokSAZseIn2j/yFC+EiIINZm8CDBe+GLoohnvgEeOkaeimtYPdcAPqJBTdOVJA3/o RNTsq+ST 9lOTSMwCFfnVURNOenemg6AYG8bnNDuJNIA7UzIJfMLqu0nX/TOaKdpGar8owUYUwN7FfAqSmcTINfK4YzY9WHqm3156w9fxBNAXC7IiCFdfXjPGoFCSjgsxz59QOirw03+ilGLKKYbIq7WITXOa/yAKdu9pmw9pyUbvhcws76snXkOQBkaakXEZeIzjH4fMaQbdQ7JxdeMzimW/iiayIPKAe8hE7m2v58cTRodmCLoRqz0iAyDYOn12vhB/Pm0Cibi6J1vT+GETtyqnUaDBs8taaSnkCv/4L12RwjZNSVKl/ICpo9yV/8j3NxQ/w82zIR5AhCY7rMxDmZCFGS69RQ3/j/YwCw7H3UGLC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 27 Jun 2024 13:50:22 -0700 Andrii Nakryiko wrote: > On Thu, Jun 27, 2024 at 12:59 PM Andrew Morton > > Is it possible/sensible to make this feature Kconfigurable so that people who > > don't need it can omit it? > > It's just a matter of #ifdef/#endif, so not hard, technically > speaking. But I'm wondering what's the concern? This is mostly newly > added code (except factoring out get_vma_name logic, which won't be > #ifdef'ed anyways), so if no one is using this new API, then it should > cause no issue. > > Generally speaking, I'd say if we don't *have to* add the Kconfig > option, I'd prefer that. But if you feel strongly, it's not hard for > me to do, of course. > > Or are you concerned with the vmlinux code size increase? It doesn't > seem to be large enough to warrant a Kconfig, IMO (from > bloat-o-meter): > > do_procmap_query - 1308 +1308 > get_vma_name - 283 +283 > procfs_procmap_ioctl - 47 +47 > show_map_vma 444 274 -170 > > But again, do let me know if you insist. Yes, I'm thinking about being nice to small systems ("make tinyconfig"!). The kernel just gets bigger and bigger over time, little bit by little bit. It's a judgment call - if making it configurable is ugly and/or adds maintenance overhead then no.